diff mbox series

[v6,03/12] net/ice: cleanup Tx buffers

Message ID 20220427181301.1414196-4-kevinx.liu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series complete common VF features for DCF |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Kevin Liu April 27, 2022, 6:12 p.m. UTC 
  From: Robin Zhang <robinx.zhang@intel.com>

Add support for ops rte_eth_tx_done_cleanup in dcf

Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
---
 doc/guides/rel_notes/release_22_07.rst | 1 +
 drivers/net/ice/ice_dcf_ethdev.c       | 1 +
 2 files changed, 2 insertions(+)

Comments

Qi Zhang April 27, 2022, 10:41 a.m. UTC | #1 
> -----Original Message-----
> From: Liu, KevinX <kevinx.liu@intel.com>
> Sent: Thursday, April 28, 2022 2:13 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Zhang,
> RobinX <robinx.zhang@intel.com>; Liu, KevinX <kevinx.liu@intel.com>
> Subject: [PATCH v6 03/12] net/ice: cleanup Tx buffers
> 
> From: Robin Zhang <robinx.zhang@intel.com>
> 
> Add support for ops rte_eth_tx_done_cleanup in dcf
> 
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
> Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> ---
>  doc/guides/rel_notes/release_22_07.rst | 1 +
>  drivers/net/ice/ice_dcf_ethdev.c       | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_22_07.rst
> b/doc/guides/rel_notes/release_22_07.rst
> index cc2c243e81..bbd3d296de 100644
> --- a/doc/guides/rel_notes/release_22_07.rst
> +++ b/doc/guides/rel_notes/release_22_07.rst
> @@ -64,6 +64,7 @@ New Features
> 
>   * Added enable RSS RETA ops for DCF hardware.
>   * Added enable RSS HASH ops for DCF hardware.
> + * Added cleanup Tx buffers.

Please keep the pattern be consistent,

Added support for Tx buffer cleanup in DCF mode.

Anyway, this is not worth for a release note update, you can remove it.

> 
>  Removed Items
>  -------------
> diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
> index ccad7fc304..d8b5961514 100644
> --- a/drivers/net/ice/ice_dcf_ethdev.c
> +++ b/drivers/net/ice/ice_dcf_ethdev.c
> @@ -1235,6 +1235,7 @@ static const struct eth_dev_ops
> ice_dcf_eth_dev_ops = {
>  	.reta_query              = ice_dcf_dev_rss_reta_query,
>  	.rss_hash_update         = ice_dcf_dev_rss_hash_update,
>  	.rss_hash_conf_get       = ice_dcf_dev_rss_hash_conf_get,
> +	.tx_done_cleanup         = ice_tx_done_cleanup,
>  };
> 
>  static int
> --
> 2.33.1
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst
index cc2c243e81..bbd3d296de 100644
--- a/doc/guides/rel_notes/release_22_07.rst
+++ b/doc/guides/rel_notes/release_22_07.rst
@@ -64,6 +64,7 @@  New Features
 
  * Added enable RSS RETA ops for DCF hardware.
  * Added enable RSS HASH ops for DCF hardware.
+ * Added cleanup Tx buffers.
 
 Removed Items
 -------------
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
index ccad7fc304..d8b5961514 100644
--- a/drivers/net/ice/ice_dcf_ethdev.c
+++ b/drivers/net/ice/ice_dcf_ethdev.c
@@ -1235,6 +1235,7 @@  static const struct eth_dev_ops ice_dcf_eth_dev_ops = {
 	.reta_query              = ice_dcf_dev_rss_reta_query,
 	.rss_hash_update         = ice_dcf_dev_rss_hash_update,
 	.rss_hash_conf_get       = ice_dcf_dev_rss_hash_conf_get,
+	.tx_done_cleanup         = ice_tx_done_cleanup,
 };
 
 static int