net/i40e: fix max frmame size config at port level
Checks
Commit Message
From: Wenxuan Wu <wenxuanx.wu@intel.com>
Previously, max frame size can only be set when link is up, and the wait
time is 1 sec. But for nic media type of I40E_10G_BASET would consume longer
time which is too short to up would result in error.
Acctually, max frame size of media type I40E_MEDIA_TYPE_BASET can be set
regardless of link status.
This patch omit the status check of 10G_MEDIA_TYPE_BASET.
Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level")
Cc: stable@dpdk.org
Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
@@ -12102,23 +12102,21 @@ i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size)
struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint32_t rep_cnt = MAX_REPEAT_TIME;
struct rte_eth_link link;
- enum i40e_status_code status;
+ enum i40e_status_code status = I40E_ERR_DEVICE_NOT_SUPPORTED;
do {
update_link_reg(hw, &link);
if (link.link_status)
break;
-
rte_delay_ms(CHECK_INTERVAL);
} while (--rep_cnt);
- if (link.link_status) {
+ /* Only I40E_MEDIA_TYPE_FIBER link up should be guaranteed */
+ if (hw->phy.media_type == I40E_MEDIA_TYPE_BASET || link.link_status)
status = i40e_aq_set_mac_config(hw, size, TRUE, 0, false, NULL);
- if (status != I40E_SUCCESS)
- PMD_DRV_LOG(ERR, "Failed to set max frame size at port level");
- } else {
- PMD_DRV_LOG(ERR, "Set max frame size at port level not applicable on link down");
- }
+
+ if (status != I40E_SUCCESS)
+ PMD_DRV_LOG(ERR, "Failed to set max frame size at port level");
}
RTE_LOG_REGISTER_SUFFIX(i40e_logtype_init, init, NOTICE);