From patchwork Tue May 10 20:17:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 111004 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7BCDA0093; Tue, 10 May 2022 22:17:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83E7242843; Tue, 10 May 2022 22:17:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 517994283D for ; Tue, 10 May 2022 22:17:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652213852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yFu7BPzhj5bgAx7KzgOL+m2MSJOw5UoX67igMnn4JpA=; b=hPJDwsBn9/qHxF0Ldh6ehK44gmfgWZ9rYlUdN0SbUfrepVJ/4AMLjV9MGjoWMEtFMttBTf q3xCTySf9lA9kX9bglVYhVUkNqTgVzES3NKeTK+DH0X9aRl2BB3cL1vFipavKhIfeTVeiq Il9hZMJFoC+Y6amRSyBh00mHmpFc5k4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-121-DlgbJX-iNWOcVSd5YTcxsg-1; Tue, 10 May 2022 16:17:29 -0400 X-MC-Unique: DlgbJX-iNWOcVSd5YTcxsg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D6BFD802819; Tue, 10 May 2022 20:17:28 +0000 (UTC) Received: from max-t490s.redhat.com (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBA4040CF8ED; Tue, 10 May 2022 20:17:27 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com, i.maximets@ovn.org Cc: Maxime Coquelin Subject: [PATCH 4/5] vhost: add statistics for IOTLB Date: Tue, 10 May 2022 22:17:19 +0200 Message-Id: <20220510201720.1262368-5-maxime.coquelin@redhat.com> In-Reply-To: <20220510201720.1262368-1-maxime.coquelin@redhat.com> References: <20220510201720.1262368-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch adds statistics for IOTLB hits and misses. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vhost.c | 10 +++++++++- lib/vhost/vhost.h | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index fa708c1f9c..721b3a3247 100644 --- a/lib/vhost/vhost.c +++ b/lib/vhost/vhost.c @@ -43,6 +43,8 @@ static const struct vhost_vq_stats_name_off vhost_vq_stat_strings[] = { {"size_1024_1518_packets", offsetof(struct vhost_virtqueue, stats.size_bins[6])}, {"size_1519_max_packets", offsetof(struct vhost_virtqueue, stats.size_bins[7])}, {"guest_notifications", offsetof(struct vhost_virtqueue, stats.guest_notifications)}, + {"iotlb_hits", offsetof(struct vhost_virtqueue, stats.iotlb_hits)}, + {"iotlb_misses", offsetof(struct vhost_virtqueue, stats.iotlb_misses)}, }; #define VHOST_NB_VQ_STATS RTE_DIM(vhost_vq_stat_strings) @@ -60,8 +62,14 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq, tmp_size = *size; vva = vhost_user_iotlb_cache_find(vq, iova, &tmp_size, perm); - if (tmp_size == *size) + if (tmp_size == *size) { + if (dev->flags & VIRTIO_DEV_STATS_ENABLED) + vq->stats.iotlb_hits++; return vva; + } + + if (dev->flags & VIRTIO_DEV_STATS_ENABLED) + vq->stats.iotlb_misses++; iova += tmp_size; diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h index 13c5c2266d..872675207e 100644 --- a/lib/vhost/vhost.h +++ b/lib/vhost/vhost.h @@ -134,6 +134,8 @@ struct virtqueue_stats { /* Size bins in array as RFC 2819, undersized [0], 64 [1], etc */ uint64_t size_bins[8]; uint64_t guest_notifications; + uint64_t iotlb_hits; + uint64_t iotlb_misses; }; /**