diff mbox series

[v2,05/14] cryptodev: clarify usage of private key in dh

Message ID	20220525155324.9288-6-arkadiuszx.kusztal@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	akhil goyal
Headers	From: Arek Kusztal <arkadiuszx.kusztal@intel.com> To: dev@dpdk.org Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, Arek Kusztal <arkadiuszx.kusztal@intel.com> Subject: [PATCH v2 05/14] cryptodev: clarify usage of private key in dh Date: Wed, 25 May 2022 16:53:15 +0100 Message-Id: <20220525155324.9288-6-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> Precedence: list Errors-To: dev-bounces@dpdk.org
Series	cryptodev: rsa, dh, ecdh changes \| [v2,00/14] cryptodev: rsa, dh, ecdh changes [v2,01/14] cryptodev: redefine ec group enum [v2,02/14] cryptodev: reduce number of comments in asym xform [v2,03/14] cryptodev: separate key exchange operation enum [v2,04/14] cryptodev: remove comment about using ephemeral key in dsa [v2,05/14] cryptodev: clarify usage of private key in dh [v2,06/14] cryptodev: move dh type from xform to dh op [v2,07/14] cryptodev: add elliptic curve diffie hellman [v2,08/14] cryptodev: add public key verify option [v2,09/14] cryptodev: add asym op flags [v2,10/14] cryptodev: clarify usage of rsa padding hash [v2,11/14] cryptodev: move RSA padding into separate struct [v2,12/14] cryptodev: clarify rsa verify with none padding [v2,13/14] cryptodev: add salt length and optional label [v2,14/14] cryptodev: add asym algorithms capabilities

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Arkadiusz Kusztal May 25, 2022, 3:53 p.m. UTC

  - Clarified usage of private key in Diffie-Hellman.
CSRNG capable device should generate private key and then
use it for public key generation.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 lib/cryptodev/rte_crypto_asym.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Akhil Goyal May 26, 2022, 11:04 a.m. UTC | #1

> - Clarified usage of private key in Diffie-Hellman.
> CSRNG capable device should generate private key and then
> use it for public key generation.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  lib/cryptodev/rte_crypto_asym.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
> index ef8686fda8..1a77a74478 100644
> --- a/lib/cryptodev/rte_crypto_asym.h
> +++ b/lib/cryptodev/rte_crypto_asym.h
> @@ -394,6 +394,11 @@ struct rte_crypto_dh_op_param {
>  	 * Input - private key, when xform type is one of:
>  	 * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE,
>  	 * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE.
> +	 *
> +	 * In case priv_key.length is 0 and xform type is set with
> +	 * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, CSRNG capable
> +	 * device will generate private key and use it for public
> +	 * key generation.
>  	 */
Capability for CSRNG?

Acked-by: Akhil Goyal <gakhil@marvell.com>

diff mbox series

Patch

diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
index ef8686fda8..1a77a74478 100644
--- a/lib/cryptodev/rte_crypto_asym.h
+++ b/lib/cryptodev/rte_crypto_asym.h
@@ -394,6 +394,11 @@  struct rte_crypto_dh_op_param {
 	 * Input - private key, when xform type is one of:
 	 * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE,
 	 * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE.
+	 *
+	 * In case priv_key.length is 0 and xform type is set with
+	 * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, CSRNG capable
+	 * device will generate private key and use it for public
+	 * key generation.
 	 */
 
 	rte_crypto_uint shared_secret;