From patchwork Wed Jun 1 09:02:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 112216 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B576DA0548; Wed, 1 Jun 2022 12:11:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E68F242B8B; Wed, 1 Jun 2022 12:10:55 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7ED4442B73 for ; Wed, 1 Jun 2022 12:10:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654078252; x=1685614252; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=IuJhLKwdALm2Ah89zLG227OykCZeaKU5GTSyE3kbS2Q=; b=ZNZHPgCtl7QnPgDzLXpv9qLryaLAPxks4Pw+B+Px7ptBAEMnbOgODLeF JbIiMt+0+8kftoH1i/2PbFMmGpZlIq3bz4K280jOBO878aZfWZx7OZNqZ ABnRikY4Klg2eN7bdgGlXUzheFcdlDHqk8zICFtr49s2QBtVtiKsBp7e7 h+n1xcsJIDr6Bz+3SkEPdPkIg4ejNZYcuojI8UavOTLUIfhMfDiM6KNh/ DTrxz/shgvb8nhKx4fC4nmsMKL6+k0Qh+jiD7cjBKf3mDuU8RKVoXGABt SE8maxKKoX/0CEdxqvab3Ruvl/I75j+68EA7qkU+TYfMlTGDYTChokF2w g==; X-IronPort-AV: E=McAfee;i="6400,9594,10364"; a="275616427" X-IronPort-AV: E=Sophos;i="5.91,266,1647327600"; d="scan'208";a="275616427" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2022 03:10:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,266,1647327600"; d="scan'208";a="606185953" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by orsmga008.jf.intel.com with ESMTP; 01 Jun 2022 03:10:39 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, Arek Kusztal Subject: [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman Date: Wed, 1 Jun 2022 10:02:43 +0100 Message-Id: <20220601090249.86865-7-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20220601090249.86865-1-arkadiuszx.kusztal@intel.com> References: <20220601090249.86865-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org - Added elliptic curve Diffie-Hellman parameters. Point multiplication allows the user to process every phase of ECDH, but for phase 1, user should not really care about the generator. The user does not even need to know what the generator looks like, therefore setting ec xform would make this work. Signed-off-by: Arek Kusztal --- devtools/libabigail.abignore | 3 +++ doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/prog_guide/cryptodev_lib.rst | 7 +++--- doc/guides/rel_notes/release_22_07.rst | 2 ++ lib/cryptodev/rte_crypto_asym.h | 38 ++++++++++++++++++++++++++++++ 5 files changed, 48 insertions(+), 3 deletions(-) diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index 79ff15dc4e..6d174b291f 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -27,6 +27,9 @@ ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental [suppress_type] name = rte_crypto_asym_op +; Ignore changes to rte_crypto_asym_xform_type, asymmetric crypto API is experimental +[suppress_type] + name = rte_crypto_asym_xform_type ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ; Temporary exceptions till next major ABI version ; diff --git a/doc/guides/cryptodevs/features/default.ini b/doc/guides/cryptodevs/features/default.ini index 018fe0221e..7371ca6644 100644 --- a/doc/guides/cryptodevs/features/default.ini +++ b/doc/guides/cryptodevs/features/default.ini @@ -118,6 +118,7 @@ Modular Inversion = Diffie-hellman = ECDSA = ECPM = +ECDH = ; ; Supported Operating systems of a default crypto driver. diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst index edd11059bc..9e54683aa1 100644 --- a/doc/guides/prog_guide/cryptodev_lib.rst +++ b/doc/guides/prog_guide/cryptodev_lib.rst @@ -1018,9 +1018,9 @@ Asymmetric Cryptography ----------------------- The cryptodev library currently provides support for the following asymmetric -Crypto operations; RSA, Modular exponentiation and inversion, Diffie-Hellman -public and/or private key generation and shared secret compute, DSA Signature -generation and verification. +Crypto operations; RSA, Modular exponentiation and inversion, Diffie-Hellman and +Elliptic Curve Diffie-Hellman public and/or private key generation and shared +secret compute, DSA Signature generation and verification. Session and Session Management ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -1088,6 +1088,7 @@ Each xform defines specific asymmetric crypto algo. Currently supported are: * Modular operations (Exponentiation and Inverse) * Diffie-Hellman * DSA +* Elliptic Curve Diffie-Hellman * None - special case where PMD may support a passthrough mode. More for diagnostic purpose See *DPDK API Reference* for details on each rte_crypto_xxx_xform struct diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst index 73a2434f86..ef6eaf0ad2 100644 --- a/doc/guides/rel_notes/release_22_07.rst +++ b/doc/guides/rel_notes/release_22_07.rst @@ -130,6 +130,8 @@ Removed Items API Changes ----------- +* cryptodev: Added Elliptic Curve Diffie-Hellman (ECDH) algorithm. + .. This section should contain API changes. Sample format: * sample: Add a short 1-2 sentence description of the API change diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index 88bc34dc8c..f61a2ddce8 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -99,6 +99,8 @@ enum rte_crypto_asym_xform_type { /**< Elliptic Curve Digital Signature Algorithm * Perform Signature Generation and Verification. */ + RTE_CRYPTO_ASYM_XFORM_ECDH, + /**< Elliptic Curve Diffie Hellman */ RTE_CRYPTO_ASYM_XFORM_ECPM, /**< Elliptic Curve Point Multiplication */ RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END @@ -429,6 +431,41 @@ struct rte_crypto_dh_op_param { }; /** + * Elliptic Curve Diffie-Hellman Operations params. + */ +struct rte_crypto_ecdh_op_param { + enum rte_crypto_asym_ke_type ke_type; + /**< Key exchange operation type */ + rte_crypto_uint priv_key; + /**< + * Output - generated private key when ke_type is + * RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE. + * + * Input - private key when ke_type is one of: + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. + * + * In case priv_key.length is 0 and ke_type is set with + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, CSRNG capable + * device will generate private key and use it for public + * key generation. + */ + struct rte_crypto_ec_point pub_key; + /**< + * Output - generated public key when ke_type is + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE. + * + * Input - peer's public key when ke_type is + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. + */ + struct rte_crypto_ec_point shared_secret; + /**< + * Output - calculated shared secret when ke_type is + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. + */ +}; + +/** * DSA Operations params * */ @@ -566,6 +603,7 @@ struct rte_crypto_asym_op { struct rte_crypto_mod_op_param modex; struct rte_crypto_mod_op_param modinv; struct rte_crypto_dh_op_param dh; + struct rte_crypto_ecdh_op_param ecdh; struct rte_crypto_dsa_op_param dsa; struct rte_crypto_ecdsa_op_param ecdsa; struct rte_crypto_ecpm_op_param ecpm;