diff mbox series

crypto/scheduler: fix qp_id in scheduler failover

Message ID 20220615131349.20315-1-jakubx.wysocki@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series crypto/scheduler: fix qp_id in scheduler failover |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/iol-intel-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Jakub Wysocki June 15, 2022, 1:13 p.m. UTC 
  This commit fixes wrong qp_id value in cryptodev scheduler in failover
mode.

Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode")
Cc: roy.fan.zhang@intel.com

Signed-off-by: Jakub Wysocki <jakubx.wysocki@intel.com>
---
 drivers/crypto/scheduler/scheduler_failover.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Fan Zhang June 16, 2022, 8:54 a.m. UTC | #1 
> -----Original Message-----
> From: Wysocki, JakubX <jakubx.wysocki@intel.com>
> Sent: Wednesday, June 15, 2022 2:14 PM
> To: dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> Wysocki, JakubX <jakubx.wysocki@intel.com>
> Subject: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
> 
> This commit fixes wrong qp_id value in cryptodev scheduler in failover
> mode.
> 
> Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode")
> Cc: roy.fan.zhang@intel.com
> 
> Signed-off-by: Jakub Wysocki <jakubx.wysocki@intel.com>
> ---
>  drivers/crypto/scheduler/scheduler_failover.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/crypto/scheduler/scheduler_failover.c
> b/drivers/crypto/scheduler/scheduler_failover.c
> index 5023577ef8..247aeb2f22 100644
> --- a/drivers/crypto/scheduler/scheduler_failover.c
> +++ b/drivers/crypto/scheduler/scheduler_failover.c
> @@ -157,6 +157,9 @@ scheduler_start(struct rte_cryptodev *dev)
>  			((struct scheduler_qp_ctx *)
>  				dev->data->queue_pairs[i])->private_qp_ctx;
> 
> +        sched_ctx->workers[PRIMARY_WORKER_IDX].qp_id = i;
> +        sched_ctx->workers[SECONDARY_WORKER_IDX].qp_id = i;
> +
>  		rte_memcpy(&qp_ctx->primary_worker,
>  				&sched_ctx->workers[PRIMARY_WORKER_IDX],
>  				sizeof(struct scheduler_worker));
> --
> 2.17.1
Thanks Jakub!
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Fan Zhang June 20, 2022, 9:12 a.m. UTC | #2 
> -----Original Message-----
> From: Wysocki, JakubX <jakubx.wysocki@intel.com>
> Sent: Wednesday, June 15, 2022 2:14 PM
> To: dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> Wysocki, JakubX <jakubx.wysocki@intel.com>
> Subject: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
> 
> This commit fixes wrong qp_id value in cryptodev scheduler in failover
> mode.
> 
> Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode")
> Cc: roy.fan.zhang@intel.com
> 
> Signed-off-by: Jakub Wysocki <jakubx.wysocki@intel.com>
> ---
>  drivers/crypto/scheduler/scheduler_failover.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/crypto/scheduler/scheduler_failover.c
> b/drivers/crypto/scheduler/scheduler_failover.c
> index 5023577ef8..247aeb2f22 100644
> --- a/drivers/crypto/scheduler/scheduler_failover.c
> +++ b/drivers/crypto/scheduler/scheduler_failover.c
> @@ -157,6 +157,9 @@ scheduler_start(struct rte_cryptodev *dev)
>  			((struct scheduler_qp_ctx *)
>  				dev->data->queue_pairs[i])->private_qp_ctx;
> 
> +        sched_ctx->workers[PRIMARY_WORKER_IDX].qp_id = i;
> +        sched_ctx->workers[SECONDARY_WORKER_IDX].qp_id = i;
> +
>  		rte_memcpy(&qp_ctx->primary_worker,
>  				&sched_ctx->workers[PRIMARY_WORKER_IDX],
>  				sizeof(struct scheduler_worker));
> --
> 2.17.1
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
diff mbox series

Patch

diff --git a/drivers/crypto/scheduler/scheduler_failover.c b/drivers/crypto/scheduler/scheduler_failover.c
index 5023577ef8..247aeb2f22 100644
--- a/drivers/crypto/scheduler/scheduler_failover.c
+++ b/drivers/crypto/scheduler/scheduler_failover.c
@@ -157,6 +157,9 @@  scheduler_start(struct rte_cryptodev *dev)
 			((struct scheduler_qp_ctx *)
 				dev->data->queue_pairs[i])->private_qp_ctx;
 
+        sched_ctx->workers[PRIMARY_WORKER_IDX].qp_id = i;
+        sched_ctx->workers[SECONDARY_WORKER_IDX].qp_id = i;
+        
 		rte_memcpy(&qp_ctx->primary_worker,
 				&sched_ctx->workers[PRIMARY_WORKER_IDX],
 				sizeof(struct scheduler_worker));