From patchwork Wed Jun 15 17:10:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 112790 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C877BA0548; Wed, 15 Jun 2022 19:11:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF65442B9D; Wed, 15 Jun 2022 19:11:14 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 508F4410D0 for ; Wed, 15 Jun 2022 19:11:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655313072; x=1686849072; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=95tIDPViLHKcZOIXaveqyO38eoGbvaiGVJv6rTbc0aE=; b=Wt6mAuRpv0OBnSB9/BXUFN4GEit38WyD6MVkKiQwxcuoL7PNilwKEq8V G02b1UeEZYyxUAkbWBFKCJNYe5LLqGGvZG1mr92djZ3u2XdMzCWNcRY4t W3OJcxCiYVKpKWhOz8YujVKlNPDGrLQWHp//M+bdYN/iTxhGpJLXGUTdj k08hqvkc5eEHkMTP6lEMGjzwdE0IrsF9CdeYMAbB5rA52UiMf1okMDnyB c3+CblR7XhgF3B7rxstQ4xbEa0v3aWk9RKjuTJsvNJXXHOBU1W2L4B2GT qzX7zTyLOoh4aaOI0IxH5Rf2tlXxiUuFD8uuodFOgR/T1nyDV9ZV+WyX0 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10379"; a="276612819" X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="276612819" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 10:10:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="713032214" Received: from silpixa00401385.ir.intel.com (HELO silpixa00401385.ger.corp.intel.com.) ([10.237.223.181]) by orsmga004.jf.intel.com with ESMTP; 15 Jun 2022 10:10:23 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v2 2/2] common/cnxk: add include for macro definition Date: Wed, 15 Jun 2022 18:10:13 +0100 Message-Id: <20220615171013.36426-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220615171013.36426-1-bruce.richardson@intel.com> References: <20220614122904.159946-1-bruce.richardson@intel.com> <20220615171013.36426-1-bruce.richardson@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The header file "roc_io.h" uses the "__plt_always_inline" macro but don't include "roc_platform.h" to get the definition of it. This inclusion is not necessary for compilation, but the lack of it can confuse some indexers - such as those in eclipse, which reports the lines: "static __plt_always_inline uint64_t" as possible definitions of a variable called "uint64_t". This confusion leads to uint64_t being flagged as an unknown type in all other parts of the project being indexed, e.g. across all of DPDK code. Adding in the include of roc_platform.h makes it clear to the indexer that those lines are part of a function definition, and that allows eclipse to correctly recognise uint64_t as a type from stdint.h Signed-off-by: Bruce Richardson Acked-by: Jerin Jacob --- V2: fix copy-paste error, where header name replacement was missed --- drivers/common/cnxk/roc_io.h | 2 ++ 1 file changed, 2 insertions(+) -- 2.34.1 diff --git a/drivers/common/cnxk/roc_io.h b/drivers/common/cnxk/roc_io.h index 62e98d9d00..9d73e263f7 100644 --- a/drivers/common/cnxk/roc_io.h +++ b/drivers/common/cnxk/roc_io.h @@ -5,6 +5,8 @@ #ifndef _ROC_IO_H_ #define _ROC_IO_H_ +#include "roc_platform.h" /* for __plt_always_inline macro */ + #define ROC_LMT_BASE_ID_GET(lmt_addr, lmt_id) \ do { \ /* 32 Lines per core */ \