diff mbox series

dma/idxd: fix missing default for workqueue options

Message ID 20220617111750.356481-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series dma/idxd: fix missing default for workqueue options |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Bruce Richardson June 17, 2022, 11:17 a.m. UTC 
  When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the
default value used by argparse is None. This leads to later errors which
are expecting an array value:

	TypeError: 'NoneType' object is not iterable

This is fixed by specifying that the empty array should be the default
if no flags are passed.

Fixes: 94b0f04dc0e3 ("dma/idxd: add generic option for queue config")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/dma/idxd/dpdk_idxd_cfg.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sunil Pai G June 20, 2022, 4:09 a.m. UTC | #1 
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Friday, June 17, 2022 4:48 PM
> To: dev@dpdk.org
> Cc: Laatz, Kevin <kevin.laatz@intel.com>; Pai G, Sunil
> <sunil.pai.g@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: [PATCH] dma/idxd: fix missing default for workqueue options
> 
> When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the default
> value used by argparse is None. This leads to later errors which are
> expecting an array value:
> 
> 	TypeError: 'NoneType' object is not iterable
> 
> This is fixed by specifying that the empty array should be the default if
> no flags are passed.
> 
> Fixes: 94b0f04dc0e3 ("dma/idxd: add generic option for queue config")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

LGTM
Acked-by: Sunil Pai G <sunil.pai.g@intel.com>
Conor Walsh June 20, 2022, 9:21 a.m. UTC | #2 
> When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the
> default value used by argparse is None. This leads to later errors which
> are expecting an array value:
> 
> 	TypeError: 'NoneType' object is not iterable
> 
> This is fixed by specifying that the empty array should be the default
> if no flags are passed.
> 
> Fixes: 94b0f04dc0e3 ("dma/idxd: add generic option for queue config")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

Acked-by: Conor Walsh <conor.walsh@intel.com>
Thomas Monjalon June 21, 2022, 3:35 p.m. UTC | #3 
20/06/2022 06:09, Pai G, Sunil:
> > From: Richardson, Bruce <bruce.richardson@intel.com>
> > Sent: Friday, June 17, 2022 4:48 PM
> > To: dev@dpdk.org
> > Cc: Laatz, Kevin <kevin.laatz@intel.com>; Pai G, Sunil
> > <sunil.pai.g@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>
> > Subject: [PATCH] dma/idxd: fix missing default for workqueue options
> > 
> > When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the default
> > value used by argparse is None. This leads to later errors which are
> > expecting an array value:
> > 
> > 	TypeError: 'NoneType' object is not iterable
> > 
> > This is fixed by specifying that the empty array should be the default if
> > no flags are passed.
> > 
> > Fixes: 94b0f04dc0e3 ("dma/idxd: add generic option for queue config")
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> 
> LGTM
> Acked-by: Sunil Pai G <sunil.pai.g@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/dma/idxd/dpdk_idxd_cfg.py b/drivers/dma/idxd/dpdk_idxd_cfg.py
index 77c473b240..41b4d13b9c 100755
--- a/drivers/dma/idxd/dpdk_idxd_cfg.py
+++ b/drivers/dma/idxd/dpdk_idxd_cfg.py
@@ -122,7 +122,7 @@  def main(args):
     arg_p.add_argument('--name-prefix', metavar='prefix', dest='prefix',
                        default="dpdk",
                        help="Prefix for workqueue name to mark for DPDK use [default: 'dpdk']")
-    arg_p.add_argument('--wq-option', action='append',
+    arg_p.add_argument('--wq-option', action='append', default=[],
                        help="Provide additional config option for queues (format 'x=y')")
     arg_p.add_argument('--reset', action='store_true',
                        help="Reset DSA device and its queues")