diff mbox series

examples/distributor: fix syntax on single core rx and distributor

Message ID 20220620163146.51435-1-omer.yamac@ceng.metu.edu.tr (mailing list archive)
State Accepted
Delegated to: Thomas Monjalon
Headers show
Series examples/distributor: fix syntax on single core rx and distributor | expand

Checks

Context Check Description
ci/github-robot: build success github build: passed
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Abdullah Ömer Yamaç June 20, 2022, 4:31 p.m. UTC
This patch fixes the syntax error when using the single-core
for both rx and distributor functions.

Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
Cc: stable@dpdk.org

Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
---
Cc: david.hunt@intel.com
---
 examples/distributor/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit June 20, 2022, 5:10 p.m. UTC | #1
On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
> This patch fixes the syntax error when using the single-core
> for both rx and distributor functions.
> 
> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>

Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>


Can we convert compile time macro to dynamic configuration to prevent 
build errors like this?
Hunt, David June 21, 2022, 8:44 a.m. UTC | #2
Hi Ferruh,

On 20/06/2022 18:10, Ferruh Yigit wrote:
> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
>> This patch fixes the syntax error when using the single-core
>> for both rx and distributor functions.
>>
>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>
>
> Can we convert compile time macro to dynamic configuration to prevent 
> build errors like this?


+1 for the dynamic config. Maybe a "-c" on the command line for "combine 
rx and dist threads"?


Tested-by: David Hunt <david.hunt@intel.com>
Ferruh Yigit June 21, 2022, 10:26 a.m. UTC | #3
On 6/21/2022 9:44 AM, Hunt, David wrote:
> 
> Hi Ferruh,
> 
> On 20/06/2022 18:10, Ferruh Yigit wrote:
>> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
>>> This patch fixes the syntax error when using the single-core
>>> for both rx and distributor functions.
>>>
>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>>
>>
>> Can we convert compile time macro to dynamic configuration to prevent
>> build errors like this?
> 
> 
> +1 for the dynamic config. Maybe a "-c" on the command line for "combine
> rx and dist threads"?
> 

Hi Dave,

'-c' sounds good,

Can you, or someone you delegate, address this, or should we create a 
bugzilla to record?

Or Omer if you are interested in doing this change, please let us know.

> 
> Tested-by: David Hunt <david.hunt@intel.com>
> 
>
Abdullah Ömer Yamaç June 21, 2022, 11:18 a.m. UTC | #4
On 21.06.2022 13:26, Ferruh Yigit wrote:
> On 6/21/2022 9:44 AM, Hunt, David wrote:
>> 
>> Hi Ferruh,
>> 
>> On 20/06/2022 18:10, Ferruh Yigit wrote:
>>> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
>>>> This patch fixes the syntax error when using the single-core
>>>> for both rx and distributor functions.
>>>> 
>>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>>>> Cc: stable@dpdk.org
>>>> 
>>>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>>> 
>>> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>>> 
>>> 
>>> Can we convert compile time macro to dynamic configuration to prevent
>>> build errors like this?
>> 
>> 
>> +1 for the dynamic config. Maybe a "-c" on the command line for 
>> "combine
>> rx and dist threads"?
>> 
> 
> Hi Dave,
> 
> '-c' sounds good,
> 
> Can you, or someone you delegate, address this, or should we create a
> bugzilla to record?
> 
> Or Omer if you are interested in doing this change, please let us know.

Hi Ferruh,
I can do it, if you can review it. Because I am trying to getting 
familiar of your coding style.

> 
>> 
>> Tested-by: David Hunt <david.hunt@intel.com>
>> 
>>
Ferruh Yigit June 21, 2022, 11:24 a.m. UTC | #5
On 6/21/2022 12:18 PM, Omer Yamac wrote:
> On 21.06.2022 13:26, Ferruh Yigit wrote:
>> On 6/21/2022 9:44 AM, Hunt, David wrote:
>>>
>>> Hi Ferruh,
>>>
>>> On 20/06/2022 18:10, Ferruh Yigit wrote:
>>>> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
>>>>> This patch fixes the syntax error when using the single-core
>>>>> for both rx and distributor functions.
>>>>>
>>>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>>>>
>>>> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>>>>
>>>>
>>>> Can we convert compile time macro to dynamic configuration to prevent
>>>> build errors like this?
>>>
>>>
>>> +1 for the dynamic config. Maybe a "-c" on the command line for "combine
>>> rx and dist threads"?
>>>
>>
>> Hi Dave,
>>
>> '-c' sounds good,
>>
>> Can you, or someone you delegate, address this, or should we create a
>> bugzilla to record?
>>
>> Or Omer if you are interested in doing this change, please let us know.
> 
> Hi Ferruh,
> I can do it, if you can review it. Because I am trying to getting 
> familiar of your coding style.
> 

Cool, thanks. I think main person here who will set the bar for the 
acceptance is Dave as maintainer of the component :), but sure we all 
can help/review.

>>
>>>
>>> Tested-by: David Hunt <david.hunt@intel.com>
>>>
>>>
Thomas Monjalon June 26, 2022, 9:30 p.m. UTC | #6
21/06/2022 10:44, Hunt, David:
> On 20/06/2022 18:10, Ferruh Yigit wrote:
> > On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
> >> This patch fixes the syntax error when using the single-core
> >> for both rx and distributor functions.
> >>
> >> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
> >
> > Can we convert compile time macro to dynamic configuration to prevent 
> > build errors like this?
> 
> +1 for the dynamic config. Maybe a "-c" on the command line for "combine 
> rx and dist threads"?
> 
> Tested-by: David Hunt <david.hunt@intel.com>

Applied this fix, thanks.
Improvement with dynamic option can come later.
diff mbox series

Patch

diff --git a/examples/distributor/main.c b/examples/distributor/main.c
index 02bf91f555..8995806b4e 100644
--- a/examples/distributor/main.c
+++ b/examples/distributor/main.c
@@ -261,8 +261,8 @@  lcore_rx(struct lcore_params *p)
  * packets are then send straight to the tx core.
  */
 #if 0
-	rte_distributor_process(d, bufs, nb_rx);
-	const uint16_t nb_ret = rte_distributor_returned_pktsd,
+		rte_distributor_process(p->d, bufs, nb_rx);
+		const uint16_t nb_ret = rte_distributor_returned_pkts(p->d,
 			bufs, BURST_SIZE*2);
 
 		app_stats.rx.returned_pkts += nb_ret;