| Message ID | 20220623143142.1258343-1-ciara.power@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | akhil goyal |
| Headers | show |
| Series | test/crypto: fix authentication IV for zuc SGL | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-abi-testing | warning | Testing issues |
| ci/iol-x86_64-unit-testing | success | Testing PASS |
| ci/iol-x86_64-compile-testing | success | Testing PASS |
| ci/iol-aarch64-unit-testing | success | Testing PASS |
| ci/iol-aarch64-compile-testing | success | Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/github-robot: build | success | github build: passed |
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
Hi Ciara, > -----Original Message----- > From: Power, Ciara <ciara.power@intel.com> > Sent: Thursday, June 23, 2022 4:32 PM > To: Akhil Goyal <gakhil@marvell.com>; Zhang, Roy Fan > <roy.fan.zhang@intel.com> > Cc: dev@dpdk.org; Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com>; Power, Ciara <ciara.power@intel.com>; > stable@dpdk.org > Subject: [PATCH] test/crypto: fix authentication IV for zuc SGL > > The wireless operation for ZUC SGL tests was being passed NULL instead of a > pointer to the test data authentication IV, and IV length 0. > This is now corrected to use the IV from the test data. > > Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP") > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power <ciara.power@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > > The wireless operation for ZUC SGL tests was being passed NULL instead of a > > pointer to the test data authentication IV, and IV length 0. > > This is now corrected to use the IV from the test data. > > > > Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ciara Power <ciara.power@intel.com> > > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Applied to dpdk-next-crypto Thanks.
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 1cac76a64a..d08f786324 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -6563,7 +6563,7 @@ test_zuc_auth_cipher_sgl(const struct wireless_test_data *tdata, retval = create_wireless_algo_auth_cipher_operation( tdata->digest.data, tdata->digest.len, tdata->cipher_iv.data, tdata->cipher_iv.len, - NULL, 0, + tdata->auth_iv.data, tdata->auth_iv.len, (tdata->digest.offset_bytes == 0 ? (verify ? ciphertext_pad_len : plaintext_pad_len) : tdata->digest.offset_bytes),
The wireless operation for ZUC SGL tests was being passed NULL instead of a pointer to the test data authentication IV, and IV length 0. This is now corrected to use the IV from the test data. Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP") Cc: stable@dpdk.org Signed-off-by: Ciara Power <ciara.power@intel.com> --- app/test/test_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)