net/vhost: fix compliant offloading flag
Checks
Commit Message
From: Xuan Ding <xuan.ding@intel.com>
This patch fixes the check to set compliant offloading flag.
Compliant offloading flag should be set when the
'legacy-ol-flags' is true.
Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")
Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
drivers/net/vhost/rte_eth_vhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 6/28/22 11:42, xuan.ding@intel.com wrote:
> From: Xuan Ding <xuan.ding@intel.com>
>
> This patch fixes the check to set compliant offloading flag.
> Compliant offloading flag should be set when the
> 'legacy-ol-flags' is true.
>
> Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> drivers/net/vhost/rte_eth_vhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index d75d256040..24049df58a 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1735,7 +1735,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
> goto out_free;
> }
>
> - if (legacy_ol_flags == 0)
> + if (legacy_ol_flags == 1)
> flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
>
> if (dev->device.numa_node == SOCKET_ID_ANY)
Nack, legacy OL flags is NOT compliant. So current implementation is
good.
Regards,
Maxime
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, June 28, 2022 5:57 PM
> To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> Subject: Re: [PATCH] net/vhost: fix compliant offloading flag
>
>
>
> On 6/28/22 11:42, xuan.ding@intel.com wrote:
> > From: Xuan Ding <xuan.ding@intel.com>
> >
> > This patch fixes the check to set compliant offloading flag.
> > Compliant offloading flag should be set when the 'legacy-ol-flags' is
> > true.
> >
> > Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")
> >
> > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > ---
> > drivers/net/vhost/rte_eth_vhost.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/vhost/rte_eth_vhost.c
> > b/drivers/net/vhost/rte_eth_vhost.c
> > index d75d256040..24049df58a 100644
> > --- a/drivers/net/vhost/rte_eth_vhost.c
> > +++ b/drivers/net/vhost/rte_eth_vhost.c
> > @@ -1735,7 +1735,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device
> *dev)
> > goto out_free;
> > }
> >
> > - if (legacy_ol_flags == 0)
> > + if (legacy_ol_flags == 1)
> > flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
> >
> > if (dev->device.numa_node == SOCKET_ID_ANY)
>
> Nack, legacy OL flags is NOT compliant. So current implementation is good.
Sorry, it's a wrong fix, the compliant mode is enabled by default.
Regards,
Xuan
>
> Regards,
> Maxime
> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Tuesday, June 28, 2022 6:29 PM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> Subject: RE: [PATCH] net/vhost: fix compliant offloading flag
>
>
>
> > -----Original Message-----
> > From: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Sent: Tuesday, June 28, 2022 5:57 PM
> > To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo
> > <chenbo.xia@intel.com>
> > Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> > Subject: Re: [PATCH] net/vhost: fix compliant offloading flag
> >
> >
> >
> > On 6/28/22 11:42, xuan.ding@intel.com wrote:
> > > From: Xuan Ding <xuan.ding@intel.com>
> > >
> > > This patch fixes the check to set compliant offloading flag.
> > > Compliant offloading flag should be set when the 'legacy-ol-flags'
> > > is true.
> > >
> > > Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")
> > >
> > > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > > ---
Tested-by: Wei Ling <weix.ling@intel.com>
@@ -1735,7 +1735,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
goto out_free;
}
- if (legacy_ol_flags == 0)
+ if (legacy_ol_flags == 1)
flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
if (dev->device.numa_node == SOCKET_ID_ANY)