From patchwork Wed Jul 6 14:02:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 113750 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B015A0540; Wed, 6 Jul 2022 16:03:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C939E40691; Wed, 6 Jul 2022 16:03:00 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2076.outbound.protection.outlook.com [40.107.93.76]) by mails.dpdk.org (Postfix) with ESMTP id 1762640150; Wed, 6 Jul 2022 16:02:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fPtdmJgfH7rAHY0a4x/fC11ItwJwRcnUKky9BlFEuNZzYdcI73SbBedDxFoXjRiM4nphFM5+71wJr4mQyLO03NpP8TG1vpuey1zOv9vJqhQTNiBkkPgCJPLOPq4XKt28cxShyx4MtsDN+1ZqFVEdTErlhhAF/Di1HdsaBerlsvCbLNBuyerYxlyhDtinZkGvrH3725CpAdaEMwSBOq3HCvjeMlGx2buTGRuE8YSk9U8nppC9QC4HIeYNlA0M4t61vmfkmJhx+5RBnS/w6mpqAwAZ7ICrzvMLlZ5KdQIuSxh+VNH4fZ5tR1QnjH0CZZ2isbzKgsHzOaKEd1Tg9kJauA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oT4UDYoF1q5w2StF+q335PS6RxjfcvD1NmZL9qXvTEI=; b=b0seq3MrnynYuN78Vb+kgI9U3HEAPkbGY+WDLjVxUdk8PGuHMgpVwwk0lfNQjh5PYw0OUSJ+HeUketSd09hppZ+K2/KgtYP55di8uzg2oxPY8hiJApr0x5znNUW3dhDdFQdOWYBK1oY7M/xpAU9v0wzhRw7W5qUmc+L0sbdhsB2tA1kJT3FY3EQUutgYHJzvWZv9pVuxXTqoyNYwhJZ1UNrSalQFg3oObEH4q/XUq2+c1Jyye6h+6mJL+G2a/CzwZBpgPN+6kYo4d1vEYQ6Rm5wnDPxx9qq6wmL9jl9Oi8h354JFd8g7y7rN6I1NguaM2baTU29WmxRxiUx7/S4ubw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oT4UDYoF1q5w2StF+q335PS6RxjfcvD1NmZL9qXvTEI=; b=t4l8v8+vxscUqdqzZAdlGOWOlfCJjulGynmKB05qsbP5uyc0WTTjKuFyFDhdvBNRgZiT4YSeOuxjGHr/ddk2jdaDyxZreMHL69txC/ZU/f8PIxuJHFb8TXYvJugeQ+DaLECizAM3Nq5xeL1R2KV2r32C/0smW60JXe5cgCE3VUOC0jgu5wgm21P47uloE6jS+k5zWKxcR9FeyB++i9ocu2BL9h5oZO0pmTGw+vfo3eZMbo+P8E0qUADIoaKQWtpI9Vhegcfd7675l3/nAzft7KkTis9s/uAxeFn6qEscQezHryihYpZVS8MOR9BNwkodHDA/N8HET63iWVcKrDRmIg== Received: from DM5PR07CA0066.namprd07.prod.outlook.com (2603:10b6:4:ad::31) by MWHPR1201MB0190.namprd12.prod.outlook.com (2603:10b6:301:55::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 14:02:57 +0000 Received: from DM6NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ad:cafe::4f) by DM5PR07CA0066.outlook.office365.com (2603:10b6:4:ad::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Wed, 6 Jul 2022 14:02:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.234) by DM6NAM11FT017.mail.protection.outlook.com (10.13.172.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 14:02:56 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 6 Jul 2022 14:02:56 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 6 Jul 2022 07:02:53 -0700 From: Gregory Etelson To: CC: , , , , Viacheslav Ovsiienko Subject: [PATCH v2] common/mlx5: update DevX error logging Date: Wed, 6 Jul 2022 17:02:36 +0300 Message-ID: <20220706140236.16887-1-getelson@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705144831.27945-1-getelson@nvidia.com> References: <20220705144831.27945-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d90fa30-1e61-48c9-1a8d-08da5f583a89 X-MS-TrafficTypeDiagnostic: MWHPR1201MB0190:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vLIZQG9otf9IO9gsncBicYkLuZya/6df/ND8nlAndEBB0VX3z2k55hJaswhmnZwuKpyFk2HFebkFTVAb2FASe7YzlLpJHmkT67aiSs2ekf8S7nmYx/7xO6J/+wqy2rKpNA55n5kO6lG0sarSCUH/1KWF56tJ8TQ1QSeh1w+aR1Z2/UfIhIQifBmFQep2AEsaTjrqArOm7G7putmBE1oDAxqSL2axWsyubj+KEwUTm9YKRkdXf9YCxm6YHgGU4NIe7/s2iLW+f4COArHNC7nuFKPPrGzxnrmJMo/fdMZYAeraIRZ5hawG4IELu+sHmmNCMu74d/bURugvBeIYnX+tNHitwfDWu+dRO0I/sfNXvl9Upj76uX1eYcRRX3Lgf12SmsKt1124XBVL7PY98c2QrhS5H18f8t3rycNz384nf2+b/eTawdE9he0uqhsXJmw1zg4zUWamL8f2PiaMwGlKmU9b2NxfuQw0kJlTGX4mD/zNZPOAEs3PnYk5qD9zaiu57r+AEcfC7Bu6BG1oEJRuUqLMFGKJlXnlsZUUTduvau8iDvIsBVC25AeG7RtiF2bWkBy7zQ2ou/w6dMZqJ3/xojjnDVrT8b7j/EEp3er4H8/2ItFwis1EIY2wXC1sZnvWKzjQjI3iGI24FFsZ04ORpWl12SijEEMks4kSNP5eugP1W+E3zsH6O9w4E55zd+MOvH2vCpB2TRpHFILW4hJQQ+zSFBP5C2wWQcj1FtGfykpnV5+4soK7O7Pdlz6jbkffhISym7s0j3odwZ0KZFNpflCLlp6KMZoi2m+/HSHBAkGZ4oDaks/ejW0z29byjVSgkP04epn4vlypaKpYIvGJ90GisQET4A9QsV6fO9js2t4= X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(136003)(396003)(376002)(346002)(40470700004)(36840700001)(46966006)(107886003)(16526019)(186003)(2616005)(55016003)(40480700001)(1076003)(82310400005)(336012)(47076005)(426003)(36756003)(316002)(54906003)(6916009)(8676002)(4326008)(83380400001)(70206006)(70586007)(450100002)(5660300002)(8936002)(7696005)(6286002)(86362001)(40460700003)(30864003)(478600001)(26005)(82740400003)(356005)(81166007)(36860700001)(41300700001)(2906002)(6666004)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 14:02:56.8452 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d90fa30-1e61-48c9-1a8d-08da5f583a89 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0190 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Current PMD logs all DevX errors at error level. DevX interface can fail queue counters allocation on some hardware types. That is a known issue. PMD fallback to VERB API to allocate queue counters when it detects the fault. That DevX failure should not be logged as PMD error. The patch provides DevX with flexible API that selects log level. cc: stable@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Matan Azrad --- v2: fix warnings in old gcc versions --- drivers/common/mlx5/mlx5_devx_cmds.c | 98 +++++++++++++++------------- 1 file changed, 53 insertions(+), 45 deletions(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 8880a9f3b5..fb33023138 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -20,20 +20,29 @@ #define MLX5_DEVX_ERR_RC(x) ((x) > 0 ? -(x) : ((x) < 0 ? (x) : -1)) -static void -mlx5_devx_err_log(void *out, const char *reason, - const char *param, uint32_t value) -{ - rte_errno = errno; - if (!param) - DRV_LOG(ERR, "DevX %s failed errno=%d status=%#x syndrome=%#x", - reason, errno, MLX5_FW_STATUS(out), - MLX5_FW_SYNDROME(out)); - else - DRV_LOG(ERR, "DevX %s %s=%#X failed errno=%d status=%#x syndrome=%#x", - reason, param, value, errno, MLX5_FW_STATUS(out), - MLX5_FW_SYNDROME(out)); -} +#define DEVX_DRV_LOG(level, out, reason, param, value) \ +do { \ + /* \ + * Some (old) GCC compilers like 7.5.0 and aarch64 GCC 7.1-2017.08 \ + * do not expand correctly when the macro invoked when the `param` \ + * is `NULL`. \ + * Use `local_param` to avoid direct `NULL` expansion. \ + */ \ + const char *local_param = (const char *)param; \ + \ + rte_errno = errno; \ + if (!local_param) { \ + DRV_LOG(level, \ + "DevX %s failed errno=%d status=%#x syndrome=%#x", \ + (reason), errno, MLX5_FW_STATUS((out)), \ + MLX5_FW_SYNDROME((out))); \ + } else { \ + DRV_LOG(level, \ + "DevX %s %s=%#X failed errno=%d status=%#x syndrome=%#x",\ + (reason), local_param, (value), errno, \ + MLX5_FW_STATUS((out)), MLX5_FW_SYNDROME((out))); \ + } \ +} while (0) static void * mlx5_devx_get_hca_cap(void *ctx, uint32_t *in, uint32_t *out, @@ -49,7 +58,7 @@ mlx5_devx_get_hca_cap(void *ctx, uint32_t *in, uint32_t *out, MLX5_SET(query_hca_cap_in, in, op_mod, flags); rc = mlx5_glue->devx_general_cmd(ctx, in, size_in, out, size_out); if (rc || MLX5_FW_STATUS(out)) { - mlx5_devx_err_log(out, "HCA capabilities", "func", flags >> 1); + DEVX_DRV_LOG(ERR, out, "HCA capabilities", "func", flags >> 1); if (err) *err = MLX5_DEVX_ERR_RC(rc); return NULL; @@ -102,7 +111,7 @@ mlx5_devx_cmd_register_read(void *ctx, uint16_t reg_id, uint32_t arg, MLX5_ST_SZ_BYTES(access_register_out) + sizeof(uint32_t) * dw_cnt); if (rc || MLX5_FW_STATUS(out)) { - mlx5_devx_err_log(out, "read access", "NIC register", reg_id); + DEVX_DRV_LOG(ERR, out, "read access", "NIC register", reg_id); return MLX5_DEVX_ERR_RC(rc); } memcpy(data, &out[MLX5_ST_SZ_DW(access_register_out)], @@ -153,7 +162,7 @@ mlx5_devx_cmd_register_write(void *ctx, uint16_t reg_id, uint32_t arg, memcpy(ptr, data, dw_cnt * sizeof(uint32_t)); rc = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out, sizeof(out)); if (rc || MLX5_FW_STATUS(out)) { - mlx5_devx_err_log(out, "write access", "NIC register", reg_id); + DEVX_DRV_LOG(ERR, out, "write access", "NIC register", reg_id); return MLX5_DEVX_ERR_RC(rc); } rc = mlx5_glue->devx_general_cmd(ctx, in, @@ -161,7 +170,7 @@ mlx5_devx_cmd_register_write(void *ctx, uint16_t reg_id, uint32_t arg, dw_cnt * sizeof(uint32_t), out, sizeof(out)); if (rc || MLX5_FW_STATUS(out)) { - mlx5_devx_err_log(out, "write access", "NIC register", reg_id); + DEVX_DRV_LOG(ERR, out, "write access", "NIC register", reg_id); return MLX5_DEVX_ERR_RC(rc); } return 0; @@ -199,7 +208,7 @@ mlx5_devx_cmd_flow_counter_alloc(void *ctx, uint32_t bulk_n_128) dcs->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!dcs->obj) { - mlx5_devx_err_log(out, "allocate counters", NULL, 0); + DEVX_DRV_LOG(ERR, out, "allocate counters", NULL, 0); mlx5_free(dcs); return NULL; } @@ -377,9 +386,8 @@ mlx5_devx_cmd_mkey_create(void *ctx, mkey->obj = mlx5_glue->devx_obj_create(ctx, in, in_size_dw * 4, out, sizeof(out)); if (!mkey->obj) { - mlx5_devx_err_log(out, - klm_num ? "create indirect mkey" : "create direct key", - NULL, 0); + DEVX_DRV_LOG(ERR, out, klm_num ? "create indirect mkey" + : "create direct key", NULL, 0); mlx5_free(mkey); return NULL; } @@ -470,7 +478,7 @@ mlx5_devx_cmd_query_nic_vport_context(void *ctx, in, sizeof(in), out, sizeof(out)); if (rc || MLX5_FW_STATUS(out)) { - mlx5_devx_err_log(out, "query NIC vport context", NULL, 0); + DEVX_DRV_LOG(ERR, out, "query NIC vport context", NULL, 0); return MLX5_DEVX_ERR_RC(rc); } vctx = MLX5_ADDR_OF(query_nic_vport_context_out, out, @@ -717,7 +725,7 @@ mlx5_devx_cmd_create_flex_parser(void *ctx, parse_flex_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!parse_flex_obj->obj) { - mlx5_devx_err_log(out, "create FLEX PARSE GRAPH", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create FLEX PARSE GRAPH", NULL, 0); mlx5_free(parse_flex_obj); return NULL; } @@ -1292,7 +1300,7 @@ mlx5_devx_cmd_create_rq(void *ctx, rq->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!rq->obj) { - mlx5_devx_err_log(out, "create RQ", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create RQ", NULL, 0); mlx5_free(rq); return NULL; } @@ -1391,7 +1399,7 @@ mlx5_devx_cmd_create_rmp(void *ctx, rmp->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!rmp->obj) { - mlx5_devx_err_log(out, "create RMP", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create RMP", NULL, 0); mlx5_free(rmp); return NULL; } @@ -1459,7 +1467,7 @@ mlx5_devx_cmd_create_tir(void *ctx, tir->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!tir->obj) { - mlx5_devx_err_log(out, "create TIR", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create TIR", NULL, 0); mlx5_free(tir); return NULL; } @@ -1597,7 +1605,7 @@ mlx5_devx_cmd_create_rqt(void *ctx, rqt->obj = mlx5_glue->devx_obj_create(ctx, in, inlen, out, sizeof(out)); mlx5_free(in); if (!rqt->obj) { - mlx5_devx_err_log(out, "create RQT", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create RQT", NULL, 0); mlx5_free(rqt); return NULL; } @@ -1711,7 +1719,7 @@ mlx5_devx_cmd_create_sq(void *ctx, sq->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!sq->obj) { - mlx5_devx_err_log(out, "create SQ", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create SQ", NULL, 0); mlx5_free(sq); return NULL; } @@ -1794,7 +1802,7 @@ mlx5_devx_cmd_create_tis(void *ctx, tis->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!tis->obj) { - mlx5_devx_err_log(out, "create TIS", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create TIS", NULL, 0); mlx5_free(tis); return NULL; } @@ -1828,7 +1836,7 @@ mlx5_devx_cmd_create_td(void *ctx) td->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!td->obj) { - mlx5_devx_err_log(out, "create TIS", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create TIS", NULL, 0); mlx5_free(td); return NULL; } @@ -1948,7 +1956,7 @@ mlx5_devx_cmd_create_cq(void *ctx, struct mlx5_devx_cq_attr *attr) cq_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!cq_obj->obj) { - mlx5_devx_err_log(out, "create CQ", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create CQ", NULL, 0); mlx5_free(cq_obj); return NULL; } @@ -2024,7 +2032,7 @@ mlx5_devx_cmd_create_virtq(void *ctx, virtq_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!virtq_obj->obj) { - mlx5_devx_err_log(out, "create VIRTQ", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create VIRTQ", NULL, 0); mlx5_free(virtq_obj); return NULL; } @@ -2257,7 +2265,7 @@ mlx5_devx_cmd_create_qp(void *ctx, qp_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!qp_obj->obj) { - mlx5_devx_err_log(out, "create QP", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create QP", NULL, 0); mlx5_free(qp_obj); return NULL; } @@ -2378,8 +2386,8 @@ mlx5_devx_cmd_create_virtio_q_counters(void *ctx) couners_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!couners_obj->obj) { - mlx5_devx_err_log(out, "create virtio queue counters Obj", - NULL, 0); + DEVX_DRV_LOG(ERR, out, "create virtio queue counters Obj", NULL, + 0); mlx5_free(couners_obj); return NULL; } @@ -2461,7 +2469,7 @@ mlx5_devx_cmd_create_flow_hit_aso_obj(void *ctx, uint32_t pd) flow_hit_aso_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!flow_hit_aso_obj->obj) { - mlx5_devx_err_log(out, "create FLOW_HIT_ASO", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create FLOW_HIT_ASO", NULL, 0); mlx5_free(flow_hit_aso_obj); return NULL; } @@ -2548,7 +2556,7 @@ mlx5_devx_cmd_create_flow_meter_aso_obj(void *ctx, uint32_t pd, ctx, in, sizeof(in), out, sizeof(out)); if (!flow_meter_aso_obj->obj) { - mlx5_devx_err_log(out, "create FLOW_METTER_ASO", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create FLOW_METTER_ASO", NULL, 0); mlx5_free(flow_meter_aso_obj); return NULL; } @@ -2598,7 +2606,7 @@ mlx5_devx_cmd_create_conn_track_offload_obj(void *ctx, uint32_t pd, ct_aso_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!ct_aso_obj->obj) { - mlx5_devx_err_log(out, "create CONN_TRACK_OFFLOAD", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create CONN_TRACK_OFFLOAD", NULL, 0); mlx5_free(ct_aso_obj); return NULL; } @@ -2650,7 +2658,7 @@ mlx5_devx_cmd_create_geneve_tlv_option(void *ctx, geneve_tlv_opt_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!geneve_tlv_opt_obj->obj) { - mlx5_devx_err_log(out, "create GENEVE TLV", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create GENEVE TLV", NULL, 0); mlx5_free(geneve_tlv_opt_obj); return NULL; } @@ -2712,7 +2720,7 @@ mlx5_devx_cmd_queue_counter_alloc(void *ctx) dcs->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!dcs->obj) { - mlx5_devx_err_log(out, "create q counter set", NULL, 0); + DEVX_DRV_LOG(DEBUG, out, "create q counter set", NULL, 0); mlx5_free(dcs); return NULL; } @@ -2799,7 +2807,7 @@ mlx5_devx_cmd_create_dek_obj(void *ctx, struct mlx5_devx_dek_attr *attr) dek_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (dek_obj->obj == NULL) { - mlx5_devx_err_log(out, "create DEK", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create DEK", NULL, 0); mlx5_free(dek_obj); return NULL; } @@ -2846,7 +2854,7 @@ mlx5_devx_cmd_create_import_kek_obj(void *ctx, import_kek_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (import_kek_obj->obj == NULL) { - mlx5_devx_err_log(out, "create IMPORT_KEK", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create IMPORT_KEK", NULL, 0); mlx5_free(import_kek_obj); return NULL; } @@ -2894,7 +2902,7 @@ mlx5_devx_cmd_create_credential_obj(void *ctx, credential_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (credential_obj->obj == NULL) { - mlx5_devx_err_log(out, "create CREDENTIAL", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create CREDENTIAL", NULL, 0); mlx5_free(credential_obj); return NULL; } @@ -2945,7 +2953,7 @@ mlx5_devx_cmd_create_crypto_login_obj(void *ctx, crypto_login_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (crypto_login_obj->obj == NULL) { - mlx5_devx_err_log(out, "create CRYPTO_LOGIN", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create CRYPTO_LOGIN", NULL, 0); mlx5_free(crypto_login_obj); return NULL; }