diff mbox series

[1/2] eventdev/eth_tx: add spinlock for adapter start/stop

Message ID 20220726042211.1018326-1-s.v.naga.harish.k@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [1/2] eventdev/eth_tx: add spinlock for adapter start/stop |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Naga Harish K, S V July 26, 2022, 4:22 a.m. UTC 
  add spinlock protection for tx adapter stop and start APIs
add null check for tx adapter service pointer in adapter start/stop apis.

Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
Cc: stable@dpdk.org

Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
 lib/eventdev/rte_event_eth_tx_adapter.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Jayatheerthan, Jay Aug. 1, 2022, 6:53 a.m. UTC | #1 
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Tuesday, July 26, 2022 9:52 AM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinj@marvell.com
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter start/stop
> 
> add spinlock protection for tx adapter stop and start APIs
> add null check for tx adapter service pointer in adapter start/stop apis.
> 
> Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> ---
>  lib/eventdev/rte_event_eth_tx_adapter.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index a237e8edba..3251dad61f 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -44,7 +44,7 @@
>  #define RTE_EVENT_ETH_TX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) \
>  do { \
>  	if (!txa_valid_id(id)) { \
> -		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d", id); \
> +		RTE_EDEV_LOG_ERR("Invalid eth Tx adapter id = %d", id); \
>  		return retval; \
>  	} \
>  } while (0)
> @@ -468,10 +468,13 @@ txa_service_ctrl(uint8_t id, int start)
>  	struct txa_service_data *txa;
> 
>  	txa = txa_service_id_to_data(id);
> -	if (txa->service_id == TXA_INVALID_SERVICE_ID)
> +	if (txa == NULL || txa->service_id == TXA_INVALID_SERVICE_ID)
>  		return 0;
> 
> +	rte_spinlock_lock(&txa->tx_lock);
>  	ret = rte_service_runstate_set(txa->service_id, start);
> +	rte_spinlock_unlock(&txa->tx_lock);
> +
>  	if (ret == 0 && !start) {
>  		while (rte_service_may_be_active(txa->service_id))
>  			rte_pause();
> --
> 2.23.0

There are three different changes in this patch. But since they are quite small, it should be ok.

Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
Naga Harish K, S V Sept. 9, 2022, 5:38 a.m. UTC | #2 
Hi Jerin,
   This patch set is acked by maintainers.
Please review and do the needful.

-Harish

> -----Original Message-----
> From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Sent: Monday, August 1, 2022 12:23 PM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; jerinj@marvell.com
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter
> start/stop
> 
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Tuesday, July 26, 2022 9:52 AM
> > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>;
> > jerinj@marvell.com
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter
> > start/stop
> >
> > add spinlock protection for tx adapter stop and start APIs add null
> > check for tx adapter service pointer in adapter start/stop apis.
> >
> > Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > ---
> >  lib/eventdev/rte_event_eth_tx_adapter.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c
> > b/lib/eventdev/rte_event_eth_tx_adapter.c
> > index a237e8edba..3251dad61f 100644
> > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > @@ -44,7 +44,7 @@
> >  #define RTE_EVENT_ETH_TX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval)
> \
> > do { \
> >  	if (!txa_valid_id(id)) { \
> > -		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d", id); \
> > +		RTE_EDEV_LOG_ERR("Invalid eth Tx adapter id = %d", id); \
> >  		return retval; \
> >  	} \
> >  } while (0)
> > @@ -468,10 +468,13 @@ txa_service_ctrl(uint8_t id, int start)
> >  	struct txa_service_data *txa;
> >
> >  	txa = txa_service_id_to_data(id);
> > -	if (txa->service_id == TXA_INVALID_SERVICE_ID)
> > +	if (txa == NULL || txa->service_id == TXA_INVALID_SERVICE_ID)
> >  		return 0;
> >
> > +	rte_spinlock_lock(&txa->tx_lock);
> >  	ret = rte_service_runstate_set(txa->service_id, start);
> > +	rte_spinlock_unlock(&txa->tx_lock);
> > +
> >  	if (ret == 0 && !start) {
> >  		while (rte_service_may_be_active(txa->service_id))
> >  			rte_pause();
> > --
> > 2.23.0
> 
> There are three different changes in this patch. But since they are quite
> small, it should be ok.
> 
> Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
Jerin Jacob Sept. 13, 2022, 4:04 p.m. UTC | #3 
On Fri, Sep 9, 2022 at 11:09 AM Naga Harish K, S V
<s.v.naga.harish.k@intel.com> wrote:
>
> Hi Jerin,
>    This patch set is acked by maintainers.
> Please review and do the needful.


Series applied to dpdk-next-net-eventdev/for-main. Thanks



>
> -Harish
>
> > -----Original Message-----
> > From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Sent: Monday, August 1, 2022 12:23 PM
> > To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; jerinj@marvell.com
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: RE: [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter
> > start/stop
> >
> > > -----Original Message-----
> > > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > Sent: Tuesday, July 26, 2022 9:52 AM
> > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>;
> > > jerinj@marvell.com
> > > Cc: dev@dpdk.org; stable@dpdk.org
> > > Subject: [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter
> > > start/stop
> > >
> > > add spinlock protection for tx adapter stop and start APIs add null
> > > check for tx adapter service pointer in adapter start/stop apis.
> > >
> > > Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > > ---
> > >  lib/eventdev/rte_event_eth_tx_adapter.c | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > index a237e8edba..3251dad61f 100644
> > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > @@ -44,7 +44,7 @@
> > >  #define RTE_EVENT_ETH_TX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval)
> > \
> > > do { \
> > >     if (!txa_valid_id(id)) { \
> > > -           RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d", id); \
> > > +           RTE_EDEV_LOG_ERR("Invalid eth Tx adapter id = %d", id); \
> > >             return retval; \
> > >     } \
> > >  } while (0)
> > > @@ -468,10 +468,13 @@ txa_service_ctrl(uint8_t id, int start)
> > >     struct txa_service_data *txa;
> > >
> > >     txa = txa_service_id_to_data(id);
> > > -   if (txa->service_id == TXA_INVALID_SERVICE_ID)
> > > +   if (txa == NULL || txa->service_id == TXA_INVALID_SERVICE_ID)
> > >             return 0;
> > >
> > > +   rte_spinlock_lock(&txa->tx_lock);
> > >     ret = rte_service_runstate_set(txa->service_id, start);
> > > +   rte_spinlock_unlock(&txa->tx_lock);
> > > +
> > >     if (ret == 0 && !start) {
> > >             while (rte_service_may_be_active(txa->service_id))
> > >                     rte_pause();
> > > --
> > > 2.23.0
> >
> > There are three different changes in this patch. But since they are quite
> > small, it should be ok.
> >
> > Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
>
diff mbox series

Patch

diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
index a237e8edba..3251dad61f 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -44,7 +44,7 @@ 
 #define RTE_EVENT_ETH_TX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) \
 do { \
 	if (!txa_valid_id(id)) { \
-		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d", id); \
+		RTE_EDEV_LOG_ERR("Invalid eth Tx adapter id = %d", id); \
 		return retval; \
 	} \
 } while (0)
@@ -468,10 +468,13 @@  txa_service_ctrl(uint8_t id, int start)
 	struct txa_service_data *txa;
 
 	txa = txa_service_id_to_data(id);
-	if (txa->service_id == TXA_INVALID_SERVICE_ID)
+	if (txa == NULL || txa->service_id == TXA_INVALID_SERVICE_ID)
 		return 0;
 
+	rte_spinlock_lock(&txa->tx_lock);
 	ret = rte_service_runstate_set(txa->service_id, start);
+	rte_spinlock_unlock(&txa->tx_lock);
+
 	if (ret == 0 && !start) {
 		while (rte_service_may_be_active(txa->service_id))
 			rte_pause();