diff mbox series

[v1] eventdev/eth_rx: sub event type gets reset

Message ID 20220913070205.1108906-1-ganapati.kundapura@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series [v1] eventdev/eth_rx: sub event type gets reset |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Ganapati Kundapura Sept. 13, 2022, 7:02 a.m. UTC 
  In rte_event_eth_rx_adapter_queue_add(), sub_event_type of
rte_event structure is reset which is used by the application
to determine the processing function.

Removed resetting of rte_event::sub_event_type

Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>

Comments

Jayatheerthan, Jay Sept. 13, 2022, 5:02 p.m. UTC | #1 
> -----Original Message-----
> From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> Sent: Tuesday, September 13, 2022 12:32 PM
> To: dev@dpdk.org; jerinj@marvell.com
> Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset
> 
> In rte_event_eth_rx_adapter_queue_add(), sub_event_type of
> rte_event structure is reset which is used by the application

Just a minor comment - application may or may not use this field. "which can be used" is better suited. Rest looks good. Thanks for posting.

With this change,
Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>

> to determine the processing function.
> 
> Removed resetting of rte_event::sub_event_type
> 
> Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
> 
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 64a6add..e42e41c 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter *rx_adapter,
>  	qi_ev->event = ev->event;
>  	qi_ev->op = RTE_EVENT_OP_NEW;
>  	qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER;
> -	qi_ev->sub_event_type = 0;
> 
>  	if (conf->rx_queue_flags &
>  			RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {
> --
> 2.6.4
Ganapati Kundapura Sept. 14, 2022, 6:22 a.m. UTC | #2 
Hi Jay,

> -----Original Message-----
> From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Sent: 13 September 2022 22:32
> To: Kundapura, Ganapati <ganapati.kundapura@intel.com>; dev@dpdk.org;
> jerinj@marvell.com
> Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Subject: RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset
> 
> > -----Original Message-----
> > From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> > Sent: Tuesday, September 13, 2022 12:32 PM
> > To: dev@dpdk.org; jerinj@marvell.com
> > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Naga Harish K, S
> > V <s.v.naga.harish.k@intel.com>
> > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset
> >
> > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of
> rte_event
> > structure is reset which is used by the application
> 
> Just a minor comment - application may or may not use this field. "which can
> be used" is better suited. Rest looks good. Thanks for posting.
Updated commit message as suggested in V2
> 
> With this change,
> Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
> 
Added Ack with commit header change in V2
> > to determine the processing function.
> >
> > Removed resetting of rte_event::sub_event_type
> >
> > Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
> >
> > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> > b/lib/eventdev/rte_event_eth_rx_adapter.c
> > index 64a6add..e42e41c 100644
> > --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter
> *rx_adapter,
> >  	qi_ev->event = ev->event;
> >  	qi_ev->op = RTE_EVENT_OP_NEW;
> >  	qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER;
> > -	qi_ev->sub_event_type = 0;
> >
> >  	if (conf->rx_queue_flags &
> >
> 	RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {
> > --
> > 2.6.4
Jerin Jacob Sept. 14, 2022, 1:42 p.m. UTC | #3 
On Wed, Sep 14, 2022 at 11:52 AM Kundapura, Ganapati
<ganapati.kundapura@intel.com> wrote:
>
> Hi Jay,
>
> > -----Original Message-----
> > From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Sent: 13 September 2022 22:32
> > To: Kundapura, Ganapati <ganapati.kundapura@intel.com>; dev@dpdk.org;
> > jerinj@marvell.com
> > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Subject: RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset
> >
> > > -----Original Message-----
> > > From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> > > Sent: Tuesday, September 13, 2022 12:32 PM
> > > To: dev@dpdk.org; jerinj@marvell.com
> > > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Naga Harish K, S
> > > V <s.v.naga.harish.k@intel.com>
> > > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset
> > >
> > > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of
> > rte_event
> > > structure is reset which is used by the application
> >
> > Just a minor comment - application may or may not use this field. "which can
> > be used" is better suited. Rest looks good. Thanks for posting.
> Updated commit message as suggested in V2
> >
> > With this change,
> > Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
> >
> Added Ack with commit header change in V2

Updated the git commit as follows and applied v2 to
dpdk-next-net-eventdev/for-main. Thanks


    eventdev/eth_rx: remove resetting sub event type

    In rte_event_eth_rx_adapter_queue_add(), sub_event_type of
    rte_event structure is reset which can be used by the
    application to determine the processing function.

    Removed resetting of rte_event::sub_event_type

    Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
    Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>


> > > to determine the processing function.
> > >
> > > Removed resetting of rte_event::sub_event_type
> > >
> > > Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
> > >
> > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> > > b/lib/eventdev/rte_event_eth_rx_adapter.c
> > > index 64a6add..e42e41c 100644
> > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> > > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter
> > *rx_adapter,
> > >     qi_ev->event = ev->event;
> > >     qi_ev->op = RTE_EVENT_OP_NEW;
> > >     qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER;
> > > -   qi_ev->sub_event_type = 0;
> > >
> > >     if (conf->rx_queue_flags &
> > >
> >       RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {
> > > --
> > > 2.6.4
>
diff mbox series

Patch

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index 64a6add..e42e41c 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -2054,7 +2054,6 @@  rxa_add_queue(struct event_eth_rx_adapter *rx_adapter,
 	qi_ev->event = ev->event;
 	qi_ev->op = RTE_EVENT_OP_NEW;
 	qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER;
-	qi_ev->sub_event_type = 0;
 
 	if (conf->rx_queue_flags &
 			RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {