From patchwork Wed Sep 28 15:58:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 117068 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F147BA00C4; Wed, 28 Sep 2022 19:07:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 760F24280C; Wed, 28 Sep 2022 19:07:22 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id EC5954114E for ; Wed, 28 Sep 2022 19:07:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664384841; x=1695920841; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=eD5uVfMDl2E6fOgCM8RXRrOpS79geF0KPRyBPqyd5oY=; b=j0UViT14laDdJwEOyZTPgs/PAZHNQqEVXTNSEA9WntR+7HmsnoA5U/YQ MyqKux1711zhyu3EBa07VRHEg9QZ0ynTO2Uywh6a4L8p1UbhtZEo2JEzQ 3hcvAmiv/d7Kvrne5aTBLmCHBaKNZNhrP6N6PAeL5m/ZvIy1wRzgXqblt nhxUShdW3wUmwpI2wkDXm0c6S+xb/ODaqmU63vIiW8PaAZgcaRR1Qn7UE IryOfrC1LSm70JctBjkf8H7pBTeKUZG2HScYVHjllx3FTiNy5t5Lqcd2d 5ewJDSi/O9skw2NjPql29kOuHt6AWIUh1SvLIvPkV8Ls+7+pvDFCN9y+G w==; X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="281376333" X-IronPort-AV: E=Sophos;i="5.93,352,1654585200"; d="scan'208";a="281376333" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 10:07:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="690470430" X-IronPort-AV: E=Sophos;i="5.93,352,1654585200"; d="scan'208";a="690470430" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by fmsmga004.fm.intel.com with ESMTP; 28 Sep 2022 10:07:19 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: gakhil@marvell.com, kai.ji@intel.com, Arek Kusztal Subject: [PATCH 2/2] crypto/qat: fix not set rsa lengths Date: Wed, 28 Sep 2022 16:58:11 +0100 Message-Id: <20220928155811.25016-2-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20220928155811.25016-1-arkadiuszx.kusztal@intel.com> References: <20220928155811.25016-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fixed not set output length in asym pmd when doing RSA. Fixes: 002486db239e ("crypto/qat: refactor asymmetric session") Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_asym.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c index 4b0538eea8..78e18dfc1a 100644 --- a/drivers/crypto/qat/qat_asym.c +++ b/drivers/crypto/qat/qat_asym.c @@ -505,21 +505,19 @@ rsa_collect(struct rte_crypto_asym_op *asym_op, if (asym_op->rsa.op_type == RTE_CRYPTO_ASYM_OP_ENCRYPT) { - uint8_t *rsa_result = asym_op->rsa.cipher.data; - - rte_memcpy(rsa_result, + rte_memcpy(asym_op->rsa.cipher.data, cookie->output_array[0], alg_bytesize); + asym_op->rsa.cipher.length = alg_bytesize; HEXDUMP("RSA Encrypted data", cookie->output_array[0], alg_bytesize); } else { - uint8_t *rsa_result = asym_op->rsa.cipher.data; - switch (asym_op->rsa.padding.type) { case RTE_CRYPTO_RSA_PADDING_NONE: - rte_memcpy(rsa_result, + rte_memcpy(asym_op->rsa.cipher.data, cookie->output_array[0], alg_bytesize); + asym_op->rsa.cipher.length = alg_bytesize; HEXDUMP("RSA signature", cookie->output_array[0], alg_bytesize); @@ -531,13 +529,12 @@ rsa_collect(struct rte_crypto_asym_op *asym_op, } } else { if (asym_op->rsa.op_type == RTE_CRYPTO_ASYM_OP_DECRYPT) { - uint8_t *rsa_result = asym_op->rsa.message.data; - switch (asym_op->rsa.padding.type) { case RTE_CRYPTO_RSA_PADDING_NONE: - rte_memcpy(rsa_result, + rte_memcpy(asym_op->rsa.message.data, cookie->output_array[0], alg_bytesize); + asym_op->rsa.message.length = alg_bytesize; HEXDUMP("RSA Decrypted Message", cookie->output_array[0], alg_bytesize); @@ -547,11 +544,10 @@ rsa_collect(struct rte_crypto_asym_op *asym_op, return RTE_CRYPTO_OP_STATUS_ERROR; } } else { - uint8_t *rsa_result = asym_op->rsa.sign.data; - - rte_memcpy(rsa_result, - cookie->output_array[0], - alg_bytesize); + rte_memcpy(asym_op->rsa.sign.data, + cookie->output_array[0], + alg_bytesize); + asym_op->rsa.sign.length = alg_bytesize; HEXDUMP("RSA Signature", cookie->output_array[0], alg_bytesize); }