diff mbox series

net/virtio: add queue and port ID in some logs

Message ID 20220929122228.1170-1-olivier.matz@6wind.com (mailing list archive)
State Superseded, archived
Delegated to: Maxime Coquelin
Headers
Series net/virtio: add queue and port ID in some logs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Olivier Matz Sept. 29, 2022, 12:22 p.m. UTC 
  Add the queue id and/or the port id in some logs, so it is easier to
understand what happens.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 drivers/net/virtio/virtio_ethdev.c | 6 ++++--
 drivers/net/virtio/virtio_rxtx.c   | 3 ++-
 2 files changed, 6 insertions(+), 3 deletions(-)

Comments

Maxime Coquelin Oct. 6, 2022, 1:12 p.m. UTC | #1 
On 9/29/22 14:22, Olivier Matz wrote:
> Add the queue id and/or the port id in some logs, so it is easier to
> understand what happens.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c | 6 ++++--
>   drivers/net/virtio/virtio_rxtx.c   | 3 ++-
>   2 files changed, 6 insertions(+), 3 deletions(-)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Chenbo Xia Oct. 17, 2022, 6:58 a.m. UTC | #2 
Hi Olivier,

> -----Original Message-----
> From: Olivier Matz <olivier.matz@6wind.com>
> Sent: Thursday, September 29, 2022 8:22 PM
> To: dev@dpdk.org
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> <chenbo.xia@intel.com>
> Subject: [PATCH] net/virtio: add queue and port ID in some logs
> 
> Add the queue id and/or the port id in some logs, so it is easier to
> understand what happens.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 6 ++++--
>  drivers/net/virtio/virtio_rxtx.c   | 3 ++-
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c
> b/drivers/net/virtio/virtio_ethdev.c
> index 7e07270a8b..44811c299b 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -2807,7 +2807,8 @@ virtio_dev_start(struct rte_eth_dev *dev)
>  			return -EINVAL;
>  	}
> 
> -	PMD_INIT_LOG(DEBUG, "nb_queues=%d", nb_queues);
> +	PMD_INIT_LOG(DEBUG, "nb_queues=%d (port=%d)", nb_queues,
> +		     dev->data->port_id);

Better to use %u for all port_id since it's uint16_t

Thanks,
Chenbo

> 
>  	for (i = 0; i < dev->data->nb_rx_queues; i++) {
>  		vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
> @@ -2821,7 +2822,8 @@ virtio_dev_start(struct rte_eth_dev *dev)
>  		virtqueue_notify(vq);
>  	}
> 
> -	PMD_INIT_LOG(DEBUG, "Notified backend at initialization");
> +	PMD_INIT_LOG(DEBUG, "Notified backend at initialization (port=%d)",
> +		     dev->data->port_id);
> 
>  	for (i = 0; i < dev->data->nb_rx_queues; i++) {
>  		vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
> diff --git a/drivers/net/virtio/virtio_rxtx.c
> b/drivers/net/virtio/virtio_rxtx.c
> index 4795893ec7..f8a9ee5cdb 100644
> --- a/drivers/net/virtio/virtio_rxtx.c
> +++ b/drivers/net/virtio/virtio_rxtx.c
> @@ -793,7 +793,8 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev
> *dev, uint16_t queue_idx)
>  			vq_update_avail_idx(vq);
>  	}
> 
> -	PMD_INIT_LOG(DEBUG, "Allocated %d bufs", nbufs);
> +	PMD_INIT_LOG(DEBUG, "Allocated %d bufs (port=%d queue=%d)", nbufs,
> +		     dev->data->port_id, queue_idx);
> 
>  	VIRTQUEUE_DUMP(vq);
> 
> --
> 2.30.2
Olivier Matz Oct. 17, 2022, 7:38 a.m. UTC | #3 
Hi Chenbo,

On Mon, Oct 17, 2022 at 06:58:59AM +0000, Xia, Chenbo wrote:
> Hi Olivier,
> 
> > -----Original Message-----
> > From: Olivier Matz <olivier.matz@6wind.com>
> > Sent: Thursday, September 29, 2022 8:22 PM
> > To: dev@dpdk.org
> > Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> > <chenbo.xia@intel.com>
> > Subject: [PATCH] net/virtio: add queue and port ID in some logs
> > 
> > Add the queue id and/or the port id in some logs, so it is easier to
> > understand what happens.
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> >  drivers/net/virtio/virtio_ethdev.c | 6 ++++--
> >  drivers/net/virtio/virtio_rxtx.c   | 3 ++-
> >  2 files changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/net/virtio/virtio_ethdev.c
> > b/drivers/net/virtio/virtio_ethdev.c
> > index 7e07270a8b..44811c299b 100644
> > --- a/drivers/net/virtio/virtio_ethdev.c
> > +++ b/drivers/net/virtio/virtio_ethdev.c
> > @@ -2807,7 +2807,8 @@ virtio_dev_start(struct rte_eth_dev *dev)
> >  			return -EINVAL;
> >  	}
> > 
> > -	PMD_INIT_LOG(DEBUG, "nb_queues=%d", nb_queues);
> > +	PMD_INIT_LOG(DEBUG, "nb_queues=%d (port=%d)", nb_queues,
> > +		     dev->data->port_id);
> 
> Better to use %u for all port_id since it's uint16_t

Yes, will do.
I'll update "nb_queues=%d" too by the way.

> 
> Thanks,
> Chenbo
> 
> > 
> >  	for (i = 0; i < dev->data->nb_rx_queues; i++) {
> >  		vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
> > @@ -2821,7 +2822,8 @@ virtio_dev_start(struct rte_eth_dev *dev)
> >  		virtqueue_notify(vq);
> >  	}
> > 
> > -	PMD_INIT_LOG(DEBUG, "Notified backend at initialization");
> > +	PMD_INIT_LOG(DEBUG, "Notified backend at initialization (port=%d)",
> > +		     dev->data->port_id);
> > 
> >  	for (i = 0; i < dev->data->nb_rx_queues; i++) {
> >  		vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
> > diff --git a/drivers/net/virtio/virtio_rxtx.c
> > b/drivers/net/virtio/virtio_rxtx.c
> > index 4795893ec7..f8a9ee5cdb 100644
> > --- a/drivers/net/virtio/virtio_rxtx.c
> > +++ b/drivers/net/virtio/virtio_rxtx.c
> > @@ -793,7 +793,8 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev
> > *dev, uint16_t queue_idx)
> >  			vq_update_avail_idx(vq);
> >  	}
> > 
> > -	PMD_INIT_LOG(DEBUG, "Allocated %d bufs", nbufs);
> > +	PMD_INIT_LOG(DEBUG, "Allocated %d bufs (port=%d queue=%d)", nbufs,
> > +		     dev->data->port_id, queue_idx);
> > 
> >  	VIRTQUEUE_DUMP(vq);
> > 
> > --
> > 2.30.2
>
diff mbox series

Patch

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 7e07270a8b..44811c299b 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -2807,7 +2807,8 @@  virtio_dev_start(struct rte_eth_dev *dev)
 			return -EINVAL;
 	}
 
-	PMD_INIT_LOG(DEBUG, "nb_queues=%d", nb_queues);
+	PMD_INIT_LOG(DEBUG, "nb_queues=%d (port=%d)", nb_queues,
+		     dev->data->port_id);
 
 	for (i = 0; i < dev->data->nb_rx_queues; i++) {
 		vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
@@ -2821,7 +2822,8 @@  virtio_dev_start(struct rte_eth_dev *dev)
 		virtqueue_notify(vq);
 	}
 
-	PMD_INIT_LOG(DEBUG, "Notified backend at initialization");
+	PMD_INIT_LOG(DEBUG, "Notified backend at initialization (port=%d)",
+		     dev->data->port_id);
 
 	for (i = 0; i < dev->data->nb_rx_queues; i++) {
 		vq = virtnet_rxq_to_vq(dev->data->rx_queues[i]);
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 4795893ec7..f8a9ee5cdb 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -793,7 +793,8 @@  virtio_dev_rx_queue_setup_finish(struct rte_eth_dev *dev, uint16_t queue_idx)
 			vq_update_avail_idx(vq);
 	}
 
-	PMD_INIT_LOG(DEBUG, "Allocated %d bufs", nbufs);
+	PMD_INIT_LOG(DEBUG, "Allocated %d bufs (port=%d queue=%d)", nbufs,
+		     dev->data->port_id, queue_idx);
 
 	VIRTQUEUE_DUMP(vq);