net/mlx5: fix thread termination check on Windows
Checks
Commit Message
The mlx5_is_thread_alive function always returns false
(terminated) regardless to the actual thread state.
Fixed to return the correct thread state.
Bugzilla ID: 1089
Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
Cc: stable@dpdk.org
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Tal Shnaiderman <talshn@nvidia.com>
> Sent: Wednesday, October 12, 2022 9:50
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Matan
> Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Raslan
> Darawsheh <rasland@nvidia.com>; paul203948@gmail.com; Idan Hackmon
> <idanhac@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread termination check on Windows
>
> The mlx5_is_thread_alive function always returns false
> (terminated) regardless to the actual thread state.
>
> Fixed to return the correct thread state.
>
> Bugzilla ID: 1089
> Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Hi,
> -----Original Message-----
> From: Tal Shnaiderman <talshn@nvidia.com>
> Sent: Wednesday, October 12, 2022 9:50 AM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
> Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> paul203948@gmail.com; Idan Hackmon <idanhac@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread termination check on Windows
>
> The mlx5_is_thread_alive function always returns false
> (terminated) regardless to the actual thread state.
>
> Fixed to return the correct thread state.
>
> Bugzilla ID: 1089
> Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
@@ -262,7 +262,7 @@ mlx5_is_thread_alive(HANDLE thread_handle)
if (result == WAIT_OBJECT_0)
return false;
- return false;
+ return true;
}
static int