diff mbox series

ethdev: add include for vtune

Message ID 20221012120202.11123-1-markus.theil@tu-ilmenau.de (mailing list archive)
State Not Applicable, archived
Delegated to: Andrew Rybchenko
Headers
Series ethdev: add include for vtune |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Markus Theil Oct. 12, 2022, 12:02 p.m. UTC 
  From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>

Adding this include allowed us to use vtune
with DPDK.

Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
---
 lib/ethdev/ethdev_profile.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit Oct. 12, 2022, 12:26 p.m. UTC | #1 
On 10/12/2022 1:02 PM, Markus Theil wrote:
> From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
> 
> Adding this include allowed us to use vtune
> with DPDK.
> 
> Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
> ---
>   lib/ethdev/ethdev_profile.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profile.c
> index 7978f351ac..90339cb2ee 100644
> --- a/lib/ethdev/ethdev_profile.c
> +++ b/lib/ethdev/ethdev_profile.c
> @@ -3,6 +3,7 @@
>    */
>   
>   #include "ethdev_profile.h"
> +#include "ethdev_driver.h"
>   

"ethdev_profile.h" already includes "ethdev_driver.h". What was the 
problem without above change?

>   /**
>    * This conditional block enables Ethernet device profiling with
Markus Theil Oct. 12, 2022, 2:32 p.m. UTC | #2 
On 10/12/22 14:26, Ferruh Yigit wrote:
> On 10/12/2022 1:02 PM, Markus Theil wrote:
>> From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
>>
>> Adding this include allowed us to use vtune
>> with DPDK.
>>
>> Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
>> ---
>>   lib/ethdev/ethdev_profile.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profile.c
>> index 7978f351ac..90339cb2ee 100644
>> --- a/lib/ethdev/ethdev_profile.c
>> +++ b/lib/ethdev/ethdev_profile.c
>> @@ -3,6 +3,7 @@
>>    */
>>     #include "ethdev_profile.h"
>> +#include "ethdev_driver.h"
>
> "ethdev_profile.h" already includes "ethdev_driver.h". What was the 
> problem without above change?
>
Thanks for the hint. I've overlooked that this was already fixed in 
2022/05 with 8c9e97ddbedd735f70a2e6b1d5d4ffef02a9b0b9. I'm archiving the 
patch.
>>   /**
>>    * This conditional block enables Ethernet device profiling with
>
diff mbox series

Patch

diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profile.c
index 7978f351ac..90339cb2ee 100644
--- a/lib/ethdev/ethdev_profile.c
+++ b/lib/ethdev/ethdev_profile.c
@@ -3,6 +3,7 @@ 
  */
 
 #include "ethdev_profile.h"
+#include "ethdev_driver.h"
 
 /**
  * This conditional block enables Ethernet device profiling with