diff mbox series

net/iavf: revert fix VLAN insertion

Message ID 20221018102602.217673-1-yidingx.zhou@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series net/iavf: revert fix VLAN insertion |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed

Commit Message

Yiding Zhou Oct. 18, 2022, 10:26 a.m. UTC 
  The patch to be reverted forces to select normal Tx path when kernel driver
tells that L2TAG2 is required, it results in a lot of performance loss.

We should support Tx context descriptor on vector path to handle the L2TAG2
case.

This commit reverts
commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion")

Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
---
 drivers/net/iavf/iavf_rxtx_vec_common.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Kevin Traynor Oct. 18, 2022, 12:17 p.m. UTC | #1 
On 18/10/2022 11:26, Yiding Zhou wrote:
> The patch to be reverted forces to select normal Tx path when kernel driver
> tells that L2TAG2 is required, it results in a lot of performance loss.
> 
> We should support Tx context descriptor on vector path to handle the L2TAG2
> case.
> 

Hi. Was the original fix in 0d58caa7d6d1 not needed? or is it just being 
reverted because of performance issues and the original functional issue 
still remains? It is not very clear in the commit message. It would be 
good to write what the status of the original issue with this patch 
applied is in the commit message.

> This commit reverts
> commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion")
> 

Better to add DPDK style tags here, so they can be picked up by scripts, 
thanks. i.e.

Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion")

> Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
> ---
>   drivers/net/iavf/iavf_rxtx_vec_common.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h
> index 4ab22c6b2b..a59cb2ceee 100644
> --- a/drivers/net/iavf/iavf_rxtx_vec_common.h
> +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h
> @@ -253,9 +253,6 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq)
>   	if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS)
>   		return -1;
>   
> -	if (txq->vlan_flag == IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2)
> -		return -1;
> -
>   	if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD)
>   		return IAVF_VECTOR_OFFLOAD_PATH;
>
diff mbox series

Patch

diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h
index 4ab22c6b2b..a59cb2ceee 100644
--- a/drivers/net/iavf/iavf_rxtx_vec_common.h
+++ b/drivers/net/iavf/iavf_rxtx_vec_common.h
@@ -253,9 +253,6 @@  iavf_tx_vec_queue_default(struct iavf_tx_queue *txq)
 	if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS)
 		return -1;
 
-	if (txq->vlan_flag == IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2)
-		return -1;
-
 	if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD)
 		return IAVF_VECTOR_OFFLOAD_PATH;