From patchwork Thu Oct 20 11:14:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejasree Kondoj X-Patchwork-Id: 118785 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7AD4A0552; Thu, 20 Oct 2022 13:15:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B5B542D5A; Thu, 20 Oct 2022 13:15:12 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id BC5D442D5F for ; Thu, 20 Oct 2022 13:15:10 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29K6Q2gT008909 for ; Thu, 20 Oct 2022 04:15:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=6LTsY0cjeWSyWhq0vzYgpSd1uLpzfEiO56l0FDSU1Ug=; b=KT12SrqfhLl6T+pGCP7FF9UGdbbuXGA1EYilJaRz+oxzM+TgQgNVvY74lQktEu2kDhFs tMs6xHmCraRnabXxKrNgnT7Y/naWjov/4bvpEGTbkEAD7xNlgXt/GtyU2WAhjn5kywwJ jkOkcXjAS1sAFkiP3VJEnvMxi0r+T0qfoOBD1LDJU3dGp6kein9PwLcmh78D/yk0U0m0 I64QNs2h0mBa7UITsZJiXmJiEaS5d4bXP76YGv4bmOtoV4jqMBoOZm53Coau62wTjDHz 9RGrb0l1Rn4y2INUbPe7yMs0O1JH8Ev81+TsRnRq9cBbdK3RT5zS3tT91knGGav30A1v 0Q== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kb1258wjp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 20 Oct 2022 04:15:10 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 20 Oct 2022 04:15:08 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 20 Oct 2022 04:15:08 -0700 Received: from hyd1554.marvell.com (unknown [10.29.57.11]) by maili.marvell.com (Postfix) with ESMTP id 8829D3F7091; Thu, 20 Oct 2022 04:15:06 -0700 (PDT) From: Tejasree Kondoj To: Akhil Goyal CC: Anoob Joseph , Vidya Sagar Velumuri , Subject: [PATCH 13/13] crypto/cnxk: remove dead code Date: Thu, 20 Oct 2022 16:44:53 +0530 Message-ID: <20221020111453.1982947-7-ktejasree@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221020111453.1982947-1-ktejasree@marvell.com> References: <20221020111453.1982947-1-ktejasree@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: 8aKxazLl16zObxhTTY6DkKgE99SBWTo6 X-Proofpoint-ORIG-GUID: 8aKxazLl16zObxhTTY6DkKgE99SBWTo6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-20_03,2022-10-20_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Anoob Joseph Coverity issue: 381022 Fixes: d94414d1627f ("crypto/cnxk: separate out PDCP cipher datapath") Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_se.h | 38 ++++++++++++++--------------------- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index 4675512bbc..47516592a3 100644 --- a/drivers/crypto/cnxk/cnxk_se.h +++ b/drivers/crypto/cnxk/cnxk_se.h @@ -2675,6 +2675,8 @@ fill_pdcp_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess, fc_params.dst_iov = fc_params.src_iov = (void *)src; prepare_iov_from_pkt_inplace(m_src, &fc_params, &flags); } else { + uint32_t pkt_len; + /* Out of place processing */ fc_params.src_iov = (void *)src; fc_params.dst_iov = (void *)dst; @@ -2686,33 +2688,23 @@ fill_pdcp_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess, goto err_exit; } - if (unlikely(m_dst != NULL)) { - uint32_t pkt_len; - - /* Try to make room as much as src has */ - pkt_len = rte_pktmbuf_pkt_len(m_dst); - - if (unlikely(pkt_len < rte_pktmbuf_pkt_len(m_src))) { - pkt_len = rte_pktmbuf_pkt_len(m_src) - pkt_len; - if (!rte_pktmbuf_append(m_dst, pkt_len)) { - plt_dp_err("Not enough space in " - "m_dst %p, need %u" - " more", - m_dst, pkt_len); - ret = -EINVAL; - goto err_exit; - } - } + /* Try to make room as much as src has */ + pkt_len = rte_pktmbuf_pkt_len(m_dst); - if (prepare_iov_from_pkt(m_dst, fc_params.dst_iov, 0)) { - plt_dp_err("Prepare dst iov failed for " - "m_dst %p", - m_dst); + if (unlikely(pkt_len < rte_pktmbuf_pkt_len(m_src))) { + pkt_len = rte_pktmbuf_pkt_len(m_src) - pkt_len; + if (unlikely(rte_pktmbuf_append(m_dst, pkt_len) == NULL)) { + plt_dp_err("Not enough space in m_dst %p, need %u more", m_dst, + pkt_len); ret = -EINVAL; goto err_exit; } - } else { - fc_params.dst_iov = (void *)src; + } + + if (unlikely(prepare_iov_from_pkt(m_dst, fc_params.dst_iov, 0))) { + plt_dp_err("Prepare dst iov failed for m_dst %p", m_dst); + ret = -EINVAL; + goto err_exit; } }