[1/2] test/hash: fix coverity warning

Message ID 20221103181240.1135012-1-vladimir.medvedkin@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [1/2] test/hash: fix coverity warning |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Vladimir Medvedkin Nov. 3, 2022, 6:12 p.m. UTC
  Remove unnecessary variable assignment

Coverity issue: 336800
Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket")
Cc: dharmik.thakkar@arm.com
Cc: stable@dpdk.org

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 app/test/test_hash_readwrite_lf_perf.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Ruifeng Wang Nov. 9, 2022, 8:55 a.m. UTC | #1
> -----Original Message-----
> From: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> Sent: Friday, November 4, 2022 2:13 AM
> To: dev@dpdk.org
> Cc: Dharmik Thakkar <Dharmik.Thakkar@arm.com>; stable@dpdk.org; Yipeng Wang
> <yipeng1.wang@intel.com>; Sameh Gobriel <sameh.gobriel@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>
> Subject: [PATCH 1/2] test/hash: fix coverity warning
> 
> Remove unnecessary variable assignment
> 
> Coverity issue: 336800
> Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket")
> Cc: dharmik.thakkar@arm.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
>  app/test/test_hash_readwrite_lf_perf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/app/test/test_hash_readwrite_lf_perf.c
> b/app/test/test_hash_readwrite_lf_perf.c
> index 32f9ec9250..cf86046a2f 100644
> --- a/app/test/test_hash_readwrite_lf_perf.c
> +++ b/app/test/test_hash_readwrite_lf_perf.c
> @@ -1102,7 +1102,6 @@ test_hash_multi_add_lookup(struct rwc_perf *rwc_perf_results, int
> rwc_lf,
>  					rte_eal_remote_launch(test_rwc_reader,
>  						(void *)(uintptr_t)read_type,
>  						enabled_core_ids[i]);
> -				write_type = WRITE_KEY_SHIFT;
>  				pos_core = 0;
> 
>  				/* Launch writers */
> --
> 2.25.1
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
  

Patch

diff --git a/app/test/test_hash_readwrite_lf_perf.c b/app/test/test_hash_readwrite_lf_perf.c
index 32f9ec9250..cf86046a2f 100644
--- a/app/test/test_hash_readwrite_lf_perf.c
+++ b/app/test/test_hash_readwrite_lf_perf.c
@@ -1102,7 +1102,6 @@  test_hash_multi_add_lookup(struct rwc_perf *rwc_perf_results, int rwc_lf,
 					rte_eal_remote_launch(test_rwc_reader,
 						(void *)(uintptr_t)read_type,
 						enabled_core_ids[i]);
-				write_type = WRITE_KEY_SHIFT;
 				pos_core = 0;
 
 				/* Launch writers */