From patchwork Tue Nov 8 18:56:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Ovsiienko X-Patchwork-Id: 119561 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17016A00C2; Tue, 8 Nov 2022 19:57:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0DC2400D7; Tue, 8 Nov 2022 19:57:57 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2084.outbound.protection.outlook.com [40.107.244.84]) by mails.dpdk.org (Postfix) with ESMTP id 55C59400D4 for ; Tue, 8 Nov 2022 19:57:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XEcDOtMt/5Hhs1aIk+oF384z3ruow7DnRtvR41QkGg/X3LtjFjVSB93fOqu5HJ0/OMOcMILl4dzQHDjoThdo98BLsA9EI4/pXWHiLFZikJJsXFk45yR3Pb6EWWI0g8lKU13tinZn4fR7Hc/X4tKz1b0D4urJN4egmLwxJL8QsGl/G1RgmczN/wD7QqRmIXnYRcPtXC9AVmCwVLrYTUqFd7NnDa2Ydmn1O1YytPURkNeBmy600j4R9mwtI0y3yWciDUVnS6no674F9npCZ7DkqYxUdw1zCtGoeaK3iPbNdEk29L2bDG5UrOwaRv1FWzeQu5zQatAI1JaaeNpj/YsMxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=evqXabz/u8YetY2AEhJAyInR6kv+0g27pg0ZXMkskfo=; b=Y4gbTQtsGWAxQkpYi71riMb8sDcU/Z5XJqJcrmHYXkjQKKTu96U2Y9lfZRnd8usZpQUKULTemTf5XjNLYKq1ZnxdSaifLtFMrvAvYWBLQDCHnBMBzmEg41m/OSF4QBJmTKzs4P2Vah6ABTrCMpq8NBJCzohMyLo15q6PFHpxc1sJtqY6cma8EoKwaV+DpHSMEgiXtWesVJT2z5vzVoiOyfMeugb3f+urM1hW6YBWAG/b7W3HkO/VoQkDfpZicBoH/jiQSCSAkXJcvPWmfQWeKuLvwme4EWeUrpGkEmrifjug5ukc2lBo0qnz1yZ/MN3ET7g3Ax9TmTk95cqxj3OELQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=evqXabz/u8YetY2AEhJAyInR6kv+0g27pg0ZXMkskfo=; b=iyvbZ+rZk88edFeCWkjKU8fP8ePBy0Xeqgl7+hZwy74fPigHTBRaYPT5K6OWF5F+zusj9TC5rG4wlm4OsVs/8Nv99I80Jdj9jjsqGZN9hEgyJYbaK8B3lJhf/Y+D4zXn4/twN7VRDEiU8ejj1FZ5Z2ufjs3wHvDL0Z18ZmWYyzeY/vzgXAELO/XqHov1uEASoZ+c3MH77qPvuTTYxXhP0dZ82KPV09PiHhVS8HFxS7hzaGTygiRPe4M8LjJaW5c86JVLxcgZwn29Sgt60fjoBR2TeGL47jZuP9WcHcNLg95Q8URmkmumW+V5CV1SKr1hSvOcTEwDTwZRy6K/EzXgGw== Received: from BN9P222CA0011.NAMP222.PROD.OUTLOOK.COM (2603:10b6:408:10c::16) by BL0PR12MB4883.namprd12.prod.outlook.com (2603:10b6:208:1c6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 18:57:52 +0000 Received: from BL02EPF0000EE3E.namprd05.prod.outlook.com (2603:10b6:408:10c:cafe::85) by BN9P222CA0011.outlook.office365.com (2603:10b6:408:10c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Tue, 8 Nov 2022 18:57:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF0000EE3E.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Tue, 8 Nov 2022 18:57:52 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Tue, 8 Nov 2022 10:57:07 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 8 Nov 2022 10:57:05 -0800 From: Viacheslav Ovsiienko To: CC: , , Subject: [PATCH] net/mlx5/hws: fix timestamp format on Tx queue creation Date: Tue, 8 Nov 2022 20:56:50 +0200 Message-ID: <20221108185650.15489-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3E:EE_|BL0PR12MB4883:EE_ X-MS-Office365-Filtering-Correlation-Id: b5bfb9cb-bdda-453d-f8e4-08dac1bb2392 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6EHIxmITTUIxSXyMxieXC2LdWsKUFwaafsa6C22kssRAe2jYiC4Lja5G0HsjzAo8pM6U/b4yOTKmdkZD/C44qdflBuZU9dveD2phuKRLefQrc4wa3zTcyn/8myXn6xZo9ZZDuHsi2ZGnwDjA5N8SE7kkB61dwV1VtondKkmZDxHrWjD4WOdyINpYtjtcuvjmQIgHMSYbMuoApRkCJgsgMB+N+WOYODH+vCCq1LWzTdLDBo+AFyEx7/5DHi+0ktiKEwIRlM19goKAs6d8/pD2MygqdKzl0qN7NJSz3KR8HjbqPFpRE7O3qQ0dFNasOQKjwbWZDJ46N852A1Ajd58NiC/5J3jHB3wfjgPFVRKdatyjD42CM00BkwQ7omQlbBMMxnXQHdsWjtKnWFHmWGrdOsaRJQ1mFDF+2M/A0bZovUEqdGVWt3IB5ACbHsA1zBDybFtG3pvPqebvjdKeiQ9y+I0n/3XxY6CceV4IatfG7MWJzAPNFirTP+oflMswGU3iiYBA1niXvOJI0f/MCijowbchfQ1aYwWVxW2n7rUb9i0B5GTRP4EgKhgXfn2tMONm2OPRhIk949SkD6XonslJZ6Qywq2XS1WxA2veLZbJkWXJBm8mOJfz0essZqsc4NMPC7+jMK7wBbaDJYT8Lr5PFvWq/Lj5nBo3NuAcCI1W4czoaDm+mXw5KxpoekaKRwloXrY+vXGwW6sd1CteqefGlLm1GGzEpqsL/RIA7/gV9t9j2/I8n5WUY6508BCM5Fjw3/nqMsJIDH0+/6cGKHG1vg== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(82310400005)(316002)(47076005)(107886003)(6666004)(426003)(54906003)(478600001)(6916009)(4326008)(70206006)(8676002)(70586007)(7696005)(26005)(8936002)(36756003)(356005)(41300700001)(6286002)(7636003)(2906002)(2616005)(5660300002)(336012)(82740400003)(36860700001)(86362001)(16526019)(186003)(40460700003)(1076003)(40480700001)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 18:57:52.4351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5bfb9cb-bdda-453d-f8e4-08dac1bb2392 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3E.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4883 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The NIC since 6DX supports multiple timestamp formats in CQEs configured via firmware. If real time timestamp format has been configured the correct attributes should be specified on queue creation via DevX. These attributes setting was missed on steering queue creation and hardware steering initialization failed. Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_cmd.c | 7 +++++++ drivers/net/mlx5/hws/mlx5dr_cmd.h | 3 +++ drivers/net/mlx5/hws/mlx5dr_send.c | 3 +++ 3 files changed, 13 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index da8cc3d265..ae6637475c 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -674,6 +674,7 @@ mlx5dr_cmd_sq_create(struct ibv_context *ctx, MLX5_SET(sqc, sqc, cqn, attr->cqn); MLX5_SET(sqc, sqc, flush_in_error_en, 1); MLX5_SET(sqc, sqc, non_wire, 1); + MLX5_SET(sqc, sqc, ts_format, attr->ts_format); MLX5_SET(wq, wqc, wq_type, MLX5_WQ_TYPE_CYCLIC); MLX5_SET(wq, wqc, pd, attr->pdn); MLX5_SET(wq, wqc, uar_page, attr->page_id); @@ -682,6 +683,7 @@ mlx5dr_cmd_sq_create(struct ibv_context *ctx, MLX5_SET(wq, wqc, dbr_umem_id, attr->dbr_id); MLX5_SET(wq, wqc, wq_umem_id, attr->wq_id); + devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out)); if (!devx_obj->obj) { simple_free(devx_obj); @@ -763,6 +765,11 @@ int mlx5dr_cmd_query_caps(struct ibv_context *ctx, MLX5_GET64(query_hca_cap_out, out, capability.cmd_hca_cap.match_definer_format_supported); + caps->rq_ts_format = MLX5_GET(query_hca_cap_out, out, + capability.cmd_hca_cap.rq_ts_format); + caps->sq_ts_format = MLX5_GET(query_hca_cap_out, out, + capability.cmd_hca_cap.sq_ts_format); + MLX5_SET(query_hca_cap_in, in, op_mod, MLX5_GET_HCA_CAP_OP_MOD_GENERAL_DEVICE_2 | MLX5_HCA_CAP_OPMOD_GET_CUR); diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h index 2548b2b238..d29ed55adc 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.h +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h @@ -121,6 +121,7 @@ struct mlx5dr_cmd_sq_create_attr { uint32_t dbr_id; uint32_t wq_id; uint32_t log_wq_sz; + uint32_t ts_format; }; struct mlx5dr_cmd_query_ft_caps { @@ -161,6 +162,8 @@ struct mlx5dr_cmd_query_caps { uint8_t log_header_modify_argument_max_alloc; uint64_t definer_format_sup; uint32_t trivial_match_definer; + uint8_t rq_ts_format; + uint8_t sq_ts_format; char fw_ver[64]; }; diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index 1e9953a38f..06d4a7e5c5 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -492,6 +492,9 @@ static int mlx5dr_send_ring_create_sq_obj(struct mlx5dr_context *ctx, attr.dbr_id = sq->db_umem->umem_id; attr.wq_id = sq->buf_umem->umem_id; attr.log_wq_sz = log_wq_sz; + attr.ts_format = (ctx->caps->sq_ts_format == MLX5_HCA_CAP_TIMESTAMP_FORMAT_FR) ? + MLX5_QPC_TIMESTAMP_FORMAT_FREE_RUNNING : + MLX5_QPC_TIMESTAMP_FORMAT_DEFAULT; sq->obj = mlx5dr_cmd_sq_create(ctx->ibv_ctx, &attr); if (!sq->obj)