[v2] net: not build PMD AVX library when no IOVA as PA
Checks
Commit Message
PMD not announce pmd_supports_disable_iova_as_pa will not be build
when RTE_IOVA_AS_PA is not defined, but some AVX library for vector
path is not skipped by the build system which cause compile error.
The patch modify i40e, iavf, ice's meson file to skip AVX library
build when RTE_IOVA_AS_PA is not defined.
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
v2:
- fix build error due to wrong type of meson variable.
drivers/net/i40e/meson.build | 5 +++--
drivers/net/iavf/meson.build | 5 +++--
drivers/net/ice/meson.build | 5 +++--
3 files changed, 9 insertions(+), 6 deletions(-)
Comments
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Monday, December 12, 2022 10:56 PM
> To: mb@smartsharesystems.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Wu, Wenjun1 <wenjun1.wu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net: not build PMD AVX library when no IOVA as PA
>
> PMD not announce pmd_supports_disable_iova_as_pa will not be build
> when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path
> is not skipped by the build system which cause compile error.
>
> The patch modify i40e, iavf, ice's meson file to skip AVX library build when
> RTE_IOVA_AS_PA is not defined.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Move this for next-net review.
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
29/01/2023 13:35, Zhang, Qi Z:
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> >
> > PMD not announce pmd_supports_disable_iova_as_pa will not be build
> > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path
> > is not skipped by the build system which cause compile error.
> >
> > The patch modify i40e, iavf, ice's meson file to skip AVX library build when
> > RTE_IOVA_AS_PA is not defined.
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Move this for next-net review.
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
You ack your own patch?
> Applied to dpdk-next-net-intel.
Sorry I don't pull this one, as I think there is a better fix:
we should not handle this option in each driver.
Instead the file drivers/meson.build must be fixed.
19/02/2023 11:04, Thomas Monjalon:
> 29/01/2023 13:35, Zhang, Qi Z:
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > >
> > > PMD not announce pmd_supports_disable_iova_as_pa will not be build
> > > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path
> > > is not skipped by the build system which cause compile error.
> > >
> > > The patch modify i40e, iavf, ice's meson file to skip AVX library build when
> > > RTE_IOVA_AS_PA is not defined.
> > >
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> > Move this for next-net review.
> >
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> You ack your own patch?
>
> > Applied to dpdk-next-net-intel.
>
> Sorry I don't pull this one, as I think there is a better fix:
> we should not handle this option in each driver.
> Instead the file drivers/meson.build must be fixed.
No sorry, it cannot be handled in drivers/meson.build.
So I suggest disabling the whole driver:
+if not get_option('enable_iova_as_pa')
+ subdir_done()
+endif
Note: no need to disable ice, as it is enabled in another commit.
19/02/2023 12:08, Thomas Monjalon:
> 19/02/2023 11:04, Thomas Monjalon:
> > 29/01/2023 13:35, Zhang, Qi Z:
> > > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > > >
> > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build
> > > > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path
> > > > is not skipped by the build system which cause compile error.
> > > >
> > > > The patch modify i40e, iavf, ice's meson file to skip AVX library build when
> > > > RTE_IOVA_AS_PA is not defined.
> > > >
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > >
> > > Move this for next-net review.
> > >
> > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> > You ack your own patch?
> >
> > > Applied to dpdk-next-net-intel.
> >
> > Sorry I don't pull this one, as I think there is a better fix:
> > we should not handle this option in each driver.
> > Instead the file drivers/meson.build must be fixed.
>
> No sorry, it cannot be handled in drivers/meson.build.
>
> So I suggest disabling the whole driver:
>
> +if not get_option('enable_iova_as_pa')
> + subdir_done()
> +endif
>
> Note: no need to disable ice, as it is enabled in another commit.
I've sent a patch to better disable more drivers:
https://patches.dpdk.org/project/dpdk/patch/20230219115529.3260580-1-thomas@monjalon.net/
I think more patches would be required to enable more drivers
supporting IOVA as VA. For instance, mempool drivers should be enabled.
19/02/2023 13:01, Thomas Monjalon:
> 19/02/2023 12:08, Thomas Monjalon:
> > 19/02/2023 11:04, Thomas Monjalon:
> > > 29/01/2023 13:35, Zhang, Qi Z:
> > > > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > > > >
> > > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build
> > > > > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path
> > > > > is not skipped by the build system which cause compile error.
> > > > >
> > > > > The patch modify i40e, iavf, ice's meson file to skip AVX library build when
> > > > > RTE_IOVA_AS_PA is not defined.
> > > > >
> > > > > Cc: stable@dpdk.org
> > > > >
> > > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > > >
> > > > Move this for next-net review.
> > > >
> > > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > >
> > > You ack your own patch?
> > >
> > > > Applied to dpdk-next-net-intel.
> > >
> > > Sorry I don't pull this one, as I think there is a better fix:
> > > we should not handle this option in each driver.
> > > Instead the file drivers/meson.build must be fixed.
> >
> > No sorry, it cannot be handled in drivers/meson.build.
> >
> > So I suggest disabling the whole driver:
> >
> > +if not get_option('enable_iova_as_pa')
> > + subdir_done()
> > +endif
> >
> > Note: no need to disable ice, as it is enabled in another commit.
>
> I've sent a patch to better disable more drivers:
> https://patches.dpdk.org/project/dpdk/patch/20230219115529.3260580-1-thomas@monjalon.net/
>
> I think more patches would be required to enable more drivers
> supporting IOVA as VA. For instance, mempool drivers should be enabled.
I was (stupidly) expecting a review of my patch.
@@ -37,6 +37,7 @@ testpmd_sources = files('i40e_testpmd.c')
deps += ['hash']
includes += include_directories('base')
+iova_as_pa = dpdk_conf.get('RTE_IOVA_AS_PA')
if arch_subdir == 'x86'
sources += files('i40e_rxtx_vec_sse.c')
@@ -51,7 +52,7 @@ if arch_subdir == 'x86'
if cc.get_define('__AVX2__', args: machine_args) != ''
cflags += ['-DCC_AVX2_SUPPORT']
sources += files('i40e_rxtx_vec_avx2.c')
- elif cc.has_argument('-mavx2')
+ elif iova_as_pa == 1 and cc.has_argument('-mavx2')
cflags += ['-DCC_AVX2_SUPPORT']
i40e_avx2_lib = static_library('i40e_avx2_lib',
'i40e_rxtx_vec_avx2.c',
@@ -71,7 +72,7 @@ if arch_subdir == 'x86'
cc.has_argument('-mavx512f') and
cc.has_argument('-mavx512bw'))
- if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true
+ if iova_as_pa == 1 and (i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true)
cflags += ['-DCC_AVX512_SUPPORT']
avx512_args = [cflags, '-mavx512f', '-mavx512bw']
if cc.has_argument('-march=skylake-avx512')
@@ -6,6 +6,7 @@ cflags += ['-Wno-strict-aliasing']
includes += include_directories('../../common/iavf')
deps += ['common_iavf', 'security', 'cryptodev']
+iova_as_pa = dpdk_conf.get('RTE_IOVA_AS_PA')
sources = files(
'iavf_ethdev.c',
@@ -32,7 +33,7 @@ if arch_subdir == 'x86'
if cc.get_define('__AVX2__', args: machine_args) != ''
cflags += ['-DCC_AVX2_SUPPORT']
sources += files('iavf_rxtx_vec_avx2.c')
- elif cc.has_argument('-mavx2')
+ elif iova_as_pa == 1 and cc.has_argument('-mavx2')
cflags += ['-DCC_AVX2_SUPPORT']
iavf_avx2_lib = static_library('iavf_avx2_lib',
'iavf_rxtx_vec_avx2.c',
@@ -52,7 +53,7 @@ if arch_subdir == 'x86'
cc.has_argument('-mavx512f') and
cc.has_argument('-mavx512bw'))
- if iavf_avx512_cpu_support == true or iavf_avx512_cc_support == true
+ if iova_as_pa == 1 and (iavf_avx512_cpu_support == true or iavf_avx512_cc_support == true)
cflags += ['-DCC_AVX512_SUPPORT']
avx512_args = [cflags, '-mavx512f', '-mavx512bw']
if cc.has_argument('-march=skylake-avx512')
@@ -20,6 +20,7 @@ testpmd_sources = files('ice_testpmd.c')
deps += ['hash', 'net', 'common_iavf']
includes += include_directories('base', '../../common/iavf')
+iova_as_pa = dpdk_conf.get('RTE_IOVA_AS_PA')
if arch_subdir == 'x86'
sources += files('ice_rxtx_vec_sse.c')
@@ -34,7 +35,7 @@ if arch_subdir == 'x86'
if cc.get_define('__AVX2__', args: machine_args) != ''
cflags += ['-DCC_AVX2_SUPPORT']
sources += files('ice_rxtx_vec_avx2.c')
- elif cc.has_argument('-mavx2')
+ elif iova_as_pa == 1 and cc.has_argument('-mavx2')
cflags += ['-DCC_AVX2_SUPPORT']
ice_avx2_lib = static_library('ice_avx2_lib',
'ice_rxtx_vec_avx2.c',
@@ -55,7 +56,7 @@ if arch_subdir == 'x86'
cc.has_argument('-mavx512bw')
)
- if ice_avx512_cpu_support == true or ice_avx512_cc_support == true
+ if iova_as_pa == 1 and (ice_avx512_cpu_support == true or ice_avx512_cc_support == true)
cflags += ['-DCC_AVX512_SUPPORT']
avx512_args = [cflags, '-mavx512f', '-mavx512bw']
if cc.has_argument('-march=skylake-avx512')