From patchwork Mon Dec 19 05:33:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naga Harish K, S V" X-Patchwork-Id: 121000 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AAC4A00C5; Mon, 19 Dec 2022 06:33:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBDB640698; Mon, 19 Dec 2022 06:33:21 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id D745D40695 for ; Mon, 19 Dec 2022 06:33:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671428001; x=1702964001; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=h6T0+Z0exzvoAd0cQPByFOSJ0Z+c5wr5V3APVuUkKBY=; b=L5RCma4eoLbKABt/CrB6xkUP5+z49jlN1s1ChITNH8TqbwdWEr+OFCw0 aD1w0tLl0Vi0PUdNsjJodmlGFsb0H1aTaQ7XBcEkOv2mDb0HQVl3AA5gM lRBMreQp/Obn2JqWHC7eHPHBmGWZdaUiDuCeQKSwnv982C6ZGLvKztOmj YuiYjwRQki+iaXkD1xT50Dua6+GCXL/kZ3hHBnCgv2Tj/bRnxxMYpyRAa VsRXDN8MT0fUbm0CsNvXD1w/Clox0x6zG6l4bj8oo0fXAR/ury9LRIP7Z l1nCDLLpCaltb9BNbtV46gymA/6DZnLWiS+wiwjPHp4sKw5ffQNhV+vgU w==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="321163905" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="321163905" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 21:33:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="895923834" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="895923834" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by fmsmga006.fm.intel.com with ESMTP; 18 Dec 2022 21:33:18 -0800 From: Naga Harish K S V To: jerinj@marvell.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com Cc: dev@dpdk.org, jay.jayatheerthan@intel.com Subject: [PATCH v3 1/4] eventdev/eth_rx: change eventdev reconfig logic Date: Sun, 18 Dec 2022 23:33:12 -0600 Message-Id: <20221219053315.2538180-1-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20221214070440.921488-1-s.v.naga.harish.k@intel.com> References: <20221214070440.921488-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_with_params() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter if the adapter event port config is of type ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. With this change the application no longer need to configure the eventdev with ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter required for eth_rx adapter when the adapter is created using above mentioned apis. Signed-off-by: Naga Harish K S V Acked-by: Abhinandan Gujjar --- v2: * Fix build error v3: * update doxygen --- --- .../prog_guide/event_ethernet_rx_adapter.rst | 18 ++++++++++++++++++ lib/eventdev/rte_event_eth_rx_adapter.c | 3 +++ lib/eventdev/rte_event_eth_rx_adapter.h | 13 +++++++++++++ 3 files changed, 34 insertions(+) diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst index 116c0a27c6..8fc9be0a9d 100644 --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst @@ -71,6 +71,24 @@ set to true. The function is passed the event device to be associated with the adapter and port configuration for the adapter to setup an event port if the adapter needs to use a service function. +Event device configuration for service based adapter +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +When rte_event_eth_rx_adapter_create() or +rte_event_eth_rx_adapter_create_with_params() is used for creating +adapter instance, eventdev is reconfigured with additional +``rte_event_dev_config::nb_event_ports`` parameter. +This eventdev reconfig logic also increment the +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameter if the adapter event port config is of type +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + +So the application is no longer need to configure the +event device with ``rte_event_dev_config::nb_event_ports`` and +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameters required for eth_rx adapter when the adapter is created +using above mentioned apis. + Adding Rx Queues to the Adapter Instance ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index cf7bbd4d69..34aa87379e 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -1532,6 +1532,9 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id, rte_event_dev_stop(dev_id); port_id = dev_conf.nb_event_ports; dev_conf.nb_event_ports += 1; + if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK) + dev_conf.nb_single_link_event_port_queues += 1; + ret = rte_event_dev_configure(dev_id, &dev_conf); if (ret) { RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h index d0e7d0092c..b7e75ff646 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.h +++ b/lib/eventdev/rte_event_eth_rx_adapter.h @@ -382,6 +382,19 @@ int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id, * control in configuration of the service, it should use the * rte_event_eth_rx_adapter_create_ext() version. * + * When this API is used for creating adapter instance, eventdev is + * reconfigured with additional ``rte_event_dev_config::nb_event_ports`` + * parameter during service initialization. This eventdev reconfig logic also + * increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameter if the adapter event port config is of type + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + * + * So the application is no longer need to account for + * ``rte_event_dev_config::nb_event_ports`` and + * ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameters required for eth Rx adapter in eventdev configure when + * the adapter is created with this api. + * * @param id * The identifier of the ethernet Rx event adapter. *