From patchwork Mon Dec 19 06:28:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naga Harish K, S V" X-Patchwork-Id: 121005 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 635C5A00C5; Mon, 19 Dec 2022 07:29:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47F5540698; Mon, 19 Dec 2022 07:29:00 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id C615640695 for ; Mon, 19 Dec 2022 07:28:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671431337; x=1702967337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=834hm23bur4CbRcBna2jcnsDMm2jVUDUPA++zAs8mrA=; b=IqbWoCBsBKMHLjNOelHUEWNq0U+Le5RO/B7tcPiaOBW6corkXsEO6lr6 Ltp230BLLufLlB1HjpAZMp+Ar/DQ8bteL2zZOZ4p7va3uCb7bDOPY9L5D oaqmts3uek/UJnLpO/yG1Q9f4Ffmwk0WrJGIDsmCWBS7ae2lrDkrSAV4v RDPOi0qnoBkYP7xVJY11ftuSW+yBLkeJKfgnZSYeTG9vNPoFKdtN1LqIY tRo53ldDMufZe8a4hWH3t6HwTaxAwbzpErUEBYFBYCYzSkOJSNJpjaPBI iAbbvEU13KfdSWInYcKgfRoOn5u9MzrO9ryx0K+rAyQcdlNCQUpdKyOGN w==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="299611644" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="299611644" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 22:28:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="792763877" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="792763877" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by fmsmga001.fm.intel.com with ESMTP; 18 Dec 2022 22:28:55 -0800 From: Naga Harish K S V To: jerinj@marvell.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com Cc: dev@dpdk.org, jay.jayatheerthan@intel.com Subject: [PATCH v4 1/4] eventdev/eth_rx: change eventdev reconfig logic Date: Mon, 19 Dec 2022 00:28:49 -0600 Message-Id: <20221219062852.2557488-1-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20221219053315.2538180-1-s.v.naga.harish.k@intel.com> References: <20221219053315.2538180-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_with_params() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter if the adapter event port config is of type ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. With this change the application no longer need to configure the eventdev with ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter required for eth_rx adapter when the adapter is created using above mentioned apis. Signed-off-by: Naga Harish K S V Acked-by: Abhinandan Gujjar --- v2: * Fix build error v3: * update doxygen --- --- .../prog_guide/event_ethernet_rx_adapter.rst | 18 ++++++++++++++++++ lib/eventdev/rte_event_eth_rx_adapter.c | 3 +++ lib/eventdev/rte_event_eth_rx_adapter.h | 13 +++++++++++++ 3 files changed, 34 insertions(+) diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst index 116c0a27c6..8fc9be0a9d 100644 --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst @@ -71,6 +71,24 @@ set to true. The function is passed the event device to be associated with the adapter and port configuration for the adapter to setup an event port if the adapter needs to use a service function. +Event device configuration for service based adapter +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +When rte_event_eth_rx_adapter_create() or +rte_event_eth_rx_adapter_create_with_params() is used for creating +adapter instance, eventdev is reconfigured with additional +``rte_event_dev_config::nb_event_ports`` parameter. +This eventdev reconfig logic also increment the +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameter if the adapter event port config is of type +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + +So the application is no longer need to configure the +event device with ``rte_event_dev_config::nb_event_ports`` and +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameters required for eth_rx adapter when the adapter is created +using above mentioned apis. + Adding Rx Queues to the Adapter Instance ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index cf7bbd4d69..34aa87379e 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -1532,6 +1532,9 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id, rte_event_dev_stop(dev_id); port_id = dev_conf.nb_event_ports; dev_conf.nb_event_ports += 1; + if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK) + dev_conf.nb_single_link_event_port_queues += 1; + ret = rte_event_dev_configure(dev_id, &dev_conf); if (ret) { RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h index d0e7d0092c..b7e75ff646 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.h +++ b/lib/eventdev/rte_event_eth_rx_adapter.h @@ -382,6 +382,19 @@ int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id, * control in configuration of the service, it should use the * rte_event_eth_rx_adapter_create_ext() version. * + * When this API is used for creating adapter instance, eventdev is + * reconfigured with additional ``rte_event_dev_config::nb_event_ports`` + * parameter during service initialization. This eventdev reconfig logic also + * increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameter if the adapter event port config is of type + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + * + * So the application is no longer need to account for + * ``rte_event_dev_config::nb_event_ports`` and + * ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameters required for eth Rx adapter in eventdev configure when + * the adapter is created with this api. + * * @param id * The identifier of the ethernet Rx event adapter. *