From patchwork Sat Jan 7 16:18:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naga Harish K, S V" X-Patchwork-Id: 121698 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E273DA00C2; Sat, 7 Jan 2023 17:19:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D29DA42D16; Sat, 7 Jan 2023 17:19:17 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id B0AC642D24 for ; Sat, 7 Jan 2023 17:19:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673108355; x=1704644355; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CSFLmQT1YhvayyZZttKMz/OAU7hoW3p5rzgNcRzWl/Y=; b=btGsQgFieB8UILFS68cfihAzzqqoGOg0Ifp9XDJ5qyQ3ZI1GaUrYJaJb cKgDPa3JO5/fnRQMe83nDACIwf0+uJ4QkSj5z39YmsePBucVgJxcwIuip NsG2yxEMoTfcAvk0hBP7GFdJ5uKHDRIbtwK9gcERZND2hUpLt0McU1npN x2mf8sJgToCckwRK9nraTToqn+ZZkWOQeWxXb1+Cj7vozxbGgoxOK9ufj qn1q7Cc2wUi2Nq1/Jlt5uWF8AwcPm6m+paakxiDXVzz2h5RQ5N2syjVw8 mLrLL8XBRZuglveWjLGjR8kCNfPjbfU9ww6mxoSo3GNtgNOkY0iZwLxCn g==; X-IronPort-AV: E=McAfee;i="6500,9779,10583"; a="384952369" X-IronPort-AV: E=Sophos;i="5.96,308,1665471600"; d="scan'208";a="384952369" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2023 08:19:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10583"; a="686770175" X-IronPort-AV: E=Sophos;i="5.96,308,1665471600"; d="scan'208";a="686770175" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by orsmga008.jf.intel.com with ESMTP; 07 Jan 2023 08:19:14 -0800 From: Naga Harish K S V To: jerinj@marvell.com, abhinandan.gujjar@intel.com Cc: dev@dpdk.org, jay.jayatheerthan@intel.com Subject: [PATCH 3/3] eventdev/crypto: add params set/get APIs Date: Sat, 7 Jan 2023 10:18:52 -0600 Message-Id: <20230107161852.3708690-3-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20230107161852.3708690-1-s.v.naga.harish.k@intel.com> References: <20230107161852.3708690-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The adapter configuration parameters defined in the ``struct rte_event_crypto_adapter_params`` can be configured and retrieved using ``rte_event_crypto_adapter_set_params`` and ``rte_event_eth_rx_adapter_get_params`` respectively. Signed-off-by: Naga Harish K S V --- app/test/test_event_crypto_adapter.c | 63 +++++++++++++++++++ .../prog_guide/event_crypto_adapter.rst | 19 ++++++ lib/eventdev/rte_event_crypto_adapter.c | 46 ++++++++++++++ lib/eventdev/rte_event_crypto_adapter.h | 53 ++++++++++++++++ lib/eventdev/version.map | 2 + 5 files changed, 183 insertions(+) diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c index a38e389abd..c443192c58 100644 --- a/app/test/test_event_crypto_adapter.c +++ b/app/test/test_event_crypto_adapter.c @@ -272,6 +272,65 @@ test_crypto_adapter_stats(void) return TEST_SUCCESS; } +static int +test_crypto_adapter_params(void) +{ + int err; + struct rte_event_crypto_adapter_params in_params; + struct rte_event_crypto_adapter_params out_params; + + /* Case 1: Get the default value of mbufs processed by adapter */ + err = rte_event_crypto_adapter_get_params(TEST_ADAPTER_ID, &out_params); + TEST_ASSERT(err == 0, "Expected 0 got %d", err); + + /* Case 2: Set max_nb = 32 (=BATCH_SEIZE) */ + in_params.max_nb = 32; + + err = rte_event_crypto_adapter_set_params(TEST_ADAPTER_ID, &in_params); + TEST_ASSERT(err == 0, "Expected 0 got %d", err); + + err = rte_event_crypto_adapter_get_params(TEST_ADAPTER_ID, &out_params); + TEST_ASSERT(err == 0, "Expected 0 got %d", err); + TEST_ASSERT(in_params.max_nb == out_params.max_nb, "Expected %u got %u", + in_params.max_nb, out_params.max_nb); + + /* Case 3: Set max_nb = 192 */ + in_params.max_nb = 192; + + err = rte_event_crypto_adapter_set_params(TEST_ADAPTER_ID, &in_params); + TEST_ASSERT(err == 0, "Expected 0 got %d", err); + + err = rte_event_crypto_adapter_get_params(TEST_ADAPTER_ID, &out_params); + TEST_ASSERT(err == 0, "Expected 0 got %d", err); + TEST_ASSERT(in_params.max_nb == out_params.max_nb, "Expected %u got %u", + in_params.max_nb, out_params.max_nb); + + /* Case 4: Set max_nb = 256 */ + in_params.max_nb = 256; + + err = rte_event_crypto_adapter_set_params(TEST_ADAPTER_ID, &in_params); + TEST_ASSERT(err == 0, "Expected 0 got %d", err); + + err = rte_event_crypto_adapter_get_params(TEST_ADAPTER_ID, &out_params); + TEST_ASSERT(err == 0, "Expected 0 got %d", err); + TEST_ASSERT(in_params.max_nb == out_params.max_nb, "Expected %u got %u", + in_params.max_nb, out_params.max_nb); + + /* Case 5: Set max_nb = 30(lock); + adapter->max_nb = params->max_nb; + rte_spinlock_unlock(&adapter->lock); + + return 0; +} + +int +rte_event_crypto_adapter_get_params(uint8_t id, + struct rte_event_crypto_adapter_params *params) +{ + struct event_crypto_adapter *adapter; + + EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL); + + if (params == NULL) { + RTE_EDEV_LOG_ERR("params pointer is NULL\n"); + return -EINVAL; + } + + adapter = eca_id_to_adapter(id); + if (adapter == NULL) + return -EINVAL; + + params->max_nb = adapter->max_nb; + + return 0; +} + int rte_event_crypto_adapter_service_id_get(uint8_t id, uint32_t *service_id) { diff --git a/lib/eventdev/rte_event_crypto_adapter.h b/lib/eventdev/rte_event_crypto_adapter.h index 83d154a6ce..ed744526e9 100644 --- a/lib/eventdev/rte_event_crypto_adapter.h +++ b/lib/eventdev/rte_event_crypto_adapter.h @@ -138,6 +138,8 @@ * - rte_event_crypto_adapter_stop() * - rte_event_crypto_adapter_stats_get() * - rte_event_crypto_adapter_stats_reset() + * - rte_event_crypto_adapter_get_params() + * - rte_event_crypto_adapter_set_params() * The application creates an instance using rte_event_crypto_adapter_create() * or rte_event_crypto_adapter_create_ext(). @@ -253,6 +255,17 @@ struct rte_event_crypto_adapter_conf { */ }; +/** + * Adapter configuration parameters + */ +struct rte_event_crypto_adapter_params { + uint32_t max_nb; + /**< The adapter can return early if it has processed at least + * max_nb crypto ops. This isn't treated as a requirement; batching + * may cause the adapter to process more than max_nb crypto ops. + */ +}; + #define RTE_EVENT_CRYPTO_ADAPTER_EVENT_VECTOR 0x1 /**< This flag indicates that crypto operations processed on the crypto * adapter need to be vectorized @@ -594,6 +607,46 @@ rte_event_crypto_adapter_service_id_get(uint8_t id, uint32_t *service_id); int rte_event_crypto_adapter_event_port_get(uint8_t id, uint8_t *event_port_id); +/** + * Set the adapter configuration parameters + * + * This api need to be called after adding at least one qp to adapter + * + * @param id + * Adapter identifier + * + * @param params + * A pointer to structure of type struct rte_event_crypto_adapter_params + * with configuration parameter values. + * + * @return + * - 0: Success + * - <0: Error code on failure + */ +__rte_experimental +int +rte_event_crypto_adapter_set_params(uint8_t id, + struct rte_event_crypto_adapter_params *params); + +/** + * Get the adapter configuration parameters + * + * @param id + * Adapter identifier + * + * @param[out] params + * A pointer to structure of type struct rte_event_crypto_adapter_params + * containing valid adapter parameters when return value is 0 + * + * @return + * - 0: Success + * - <0: Error code on failure + */ +__rte_experimental +int +rte_event_crypto_adapter_get_params(uint8_t id, + struct rte_event_crypto_adapter_params *params); + /** * Retrieve vector limits for a given event dev and crypto dev pair. * @see rte_event_crypto_adapter_vector_limits diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map index 55e8cb514c..d17e67356c 100644 --- a/lib/eventdev/version.map +++ b/lib/eventdev/version.map @@ -120,6 +120,8 @@ EXPERIMENTAL { rte_event_eth_tx_adapter_queue_stop; # added in 23.03 + rte_event_crypto_adapter_get_params; + rte_event_crypto_adapter_set_params; rte_event_eth_rx_adapter_get_params; rte_event_eth_rx_adapter_set_params; rte_event_eth_tx_adapter_get_params;