From patchwork Mon Jan 9 07:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 121715 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD2A34237B; Mon, 9 Jan 2023 08:59:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB51642D21; Mon, 9 Jan 2023 08:59:07 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2074.outbound.protection.outlook.com [40.107.243.74]) by mails.dpdk.org (Postfix) with ESMTP id 71B3340E50; Mon, 9 Jan 2023 08:59:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P6H2oj0+mJGTeH/bMgM8R2r/twJHgaW3so9kw2FxqihFhhUZlbzMbUil14lnIDERKHDoWEf1Fd6BNavztaB+A1vb0ZpzQLTl5ymC7Skf8kK7+Kq+eWzw2vxNFHsU7p4ZrEUA89k9ZINSDKvicTqMVkWHMhpHW6q6gGVivTU52gohGauouklh+IwyujSSE8cwOKUJtv8jmIPJyUH33VScbQb8Ah+5KUV7+wajjlHFPOi6rU3oOc41+hNfrtKAWoMWjm8s2E/aCg2F4s766TU6kogn5t/7sZeKbSqVSx653SIdNL9/ANvt4+j39mNDd6DDQ7XWPTgF8M5k0fMttym93Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=afEcme/wKX1NGAveqzzIzLA1ahv7AsU6UNdyX1wgzV0=; b=kTb0g59TbSQ9PLI+w/y6cDW7MJwHtfh1XDb9Db2a+RcXtsZxyBO4jOGq6ZUzk+2WdCZvf2TNa/w9jaCltk+FbEl3cr7d6VoK3XfdcB+vj32ypc1rzwFwvVte7X3p8HG/6tkfs+lVkjbxE0Dl03NJR1NezLpJeV82aMnNjWTeDM+A7xhxTlRw+GhFujUFhCYoRE0gLVueCyN8QMXMhDQwdMrIqB82AZPxsMTASa3js3k/sM2ozJQFrw13DtM1YErPHdAW293ttIGo/aQepp2RI/mUBjMCZs7stGLHS2sd6A57uwynaohke7eT/qbkvfn0BxgMlAwzpRig9NbwepCYBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afEcme/wKX1NGAveqzzIzLA1ahv7AsU6UNdyX1wgzV0=; b=l25hkGg/rK9qeatgXK0wSYiveCnS8eJWjlTybhtRo/dwBL6i5lziUTPrWAJKZdNWDrmT0wMNJ83QWOoHgeaLIsngB0RusAAxloP3rO+SYnsbGWXOr5d0mCgoJE3t8pRDNED2J+IUJL9ML1jr0hMz6Tb3yvp4V2cs8fJmrStwMPzRGyVPQz5gPX4naSazpMhZFB3L7H9+5QJSwXraqgDBWvSGSFhSR0B3YoJD8j1oZUEeGm8+LoBH386o5v6AygE0WR3m6oOJohgyNUVeIpFQIolSh5k5zsDftW+R5w7FIW0OIW9DuqhX1ztOk3ySa7oNnMbRcY4s6yNaep15Heam/A== Received: from BN8PR07CA0005.namprd07.prod.outlook.com (2603:10b6:408:ac::18) by PH7PR12MB6883.namprd12.prod.outlook.com (2603:10b6:510:1b9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 07:59:03 +0000 Received: from BN8NAM11FT073.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ac:cafe::1d) by BN8PR07CA0005.outlook.office365.com (2603:10b6:408:ac::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 07:59:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT073.mail.protection.outlook.com (10.13.177.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 07:59:02 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 8 Jan 2023 23:58:52 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 8 Jan 2023 23:58:51 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36 via Frontend Transport; Sun, 8 Jan 2023 23:58:49 -0800 From: Michael Baum To: CC: Matan Azrad , Akhil Goyal , "Thomas Monjalon" , , Subject: [PATCH 2/7] compress/mlx5: fix QP setup for partial transformations Date: Mon, 9 Jan 2023 09:58:33 +0200 Message-ID: <20230109075838.2508039-3-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230109075838.2508039-1-michaelba@nvidia.com> References: <20230109075838.2508039-1-michaelba@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT073:EE_|PH7PR12MB6883:EE_ X-MS-Office365-Filtering-Correlation-Id: c414ec78-7fb2-4615-12b9-08daf2175fc3 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0dsHktHeFFx+Avxk5eb8vA9yD1hl2F5VXNMY7ZTBshQEpRf77NbMwpdsc/AG3zHbGX7tmNsQDxBneTTR4CDgTbxltdpMDfF2x6ONg9FSzqV80/gEvzRfqOHvDcpNDjQr+qIYAm6LrhzUj7dfIzAitE2tMKTfYvXW5Ptw8zaBjV7eUR12g3cE0P5dZVj0QR+HEZwqQuoERZg5WSchtrg3fA4nOs6qIc/z4m6JCF+9s24FtpXZ6VdaC+vJcDMdOwn2AeFgbuybtEBL6HIFW9TdkRha5JiQIyk6Ind8F9IkLchLQhDCGDm5jLgH8ClXr84YGJNrPfFAlYmNJHRfE+6xLFxJTvJhsBWGf41rxyIDQS2UYYKmWBxiQi5u8Kb243A6/by9V4mdWfx1W/kT5eIf2Qujy5IO/2LGBG/DmMM/n0drtQ91XoNqtTJFHFOvuFirQw6QAJLVSTu0Tva3CeQW/8RV6FET8AhrSaukj5i/wEYkzXOzw6ITXK/BZqQm2Oen3gplGX1xZKCV2TvJ8mUhlFm3roQnJg9NSrqkOhA+OOQsiC5qrVI3BmM8l5HJrRtkP4qDJWXGED1D9wdIduKpWPGlKrAG0BypTHUbJd314zN3ujqcnVxZxHZDEIUYBevfj7FE8h92ilSY4B2Q6Dch6rVhYUPV2eMwhha/E4Su8yA+g4GwsmY+TU22GW4byKGj8B+jQvqlARaVG/F2t1IAeA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(36756003)(86362001)(41300700001)(54906003)(40460700003)(70586007)(70206006)(8676002)(6916009)(4326008)(82740400003)(356005)(7636003)(36860700001)(83380400001)(7696005)(6666004)(478600001)(26005)(186003)(5660300002)(2906002)(8936002)(426003)(316002)(40480700001)(55016003)(6286002)(2616005)(82310400005)(1076003)(47076005)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 07:59:02.9104 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c414ec78-7fb2-4615-12b9-08daf2175fc3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT073.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6883 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The mlx5_compress_qp_setup() function creates QP for compress, decompress and DMA. Thus, the MMO flag is turned on only when all operations are supported. However, since partial transformations have been allowed, it should be turn on for part of them. This patch removes the compress MMO support requirement. Fixes: 2efd26544554 ("compress/mlx5: support partial transformation") Cc: rzidane@nvidia.com Cc: stable@dpdk.org Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index c0a861e5e4..d38f247216 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -243,8 +243,8 @@ mlx5_compress_qp_setup(struct rte_compressdev *dev, uint16_t qp_id, mlx5_ts_format_conv(priv->cdev->config.hca_attr.qp_ts_format); qp_attr.num_of_receive_wqes = 0; qp_attr.num_of_send_wqbbs = RTE_BIT32(log_ops_n); - qp_attr.mmo = priv->mmo_decomp_qp && priv->mmo_comp_qp - && priv->mmo_dma_qp; + qp_attr.mmo = priv->mmo_decomp_qp || priv->mmo_comp_qp || + priv->mmo_dma_qp; ret = mlx5_devx_qp_create(priv->cdev->ctx, &qp->qp, qp_attr.num_of_send_wqbbs * MLX5_WQE_SIZE, &qp_attr, socket_id);