From patchwork Mon Jan 16 09:39:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 122084 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 071A1423EE; Mon, 16 Jan 2023 10:40:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 914CA40A7D; Mon, 16 Jan 2023 10:40:53 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id F1E0840042 for ; Mon, 16 Jan 2023 10:40:51 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30G8fPCI010507 for ; Mon, 16 Jan 2023 01:40:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=CsJx6lJ8RWNuto07m4I7uoRPzT1IoZl/zEPpSbBWJ+4=; b=H+MC8sCrXjflHQ/EfmbxFlGMSYplz0mAm6m59OdnTgKrAWc5RHSeI9qMLgCjuFIah7wP I91/g0gpOJxSzdxV7IrF+3Rl/O5xROl7LGaMoGL9elu9NXaFLkBbl0hZlnVTxSi0sF0g dWz2+b/0o5oCEuzSXxL8oyblMiOiPUpxfIPz3biQ8+jQXLjEqZKy61AxzPHxWTh2s0V4 zXqWEDG38/0lz3Ufpv2jPFz3rZ/a6lZ73HQsUF+wsGheqZ1O+qL5//xqGzVNyAYVXbUa vdJzQrE7eT7M2hnN/TmVJfWx8mzFVhTcS4agxvjJWdBT6BuqaaVArV6BJjgN8trSjM+j 5Q== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3n3vst5qug-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 16 Jan 2023 01:40:50 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 16 Jan 2023 01:40:48 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend Transport; Mon, 16 Jan 2023 01:40:48 -0800 Received: from hyd1588t430.caveonetworks.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id 8ECA43F7052; Mon, 16 Jan 2023 01:40:46 -0800 (PST) From: Nithin Dabilpuram To: , Nithin Dabilpuram , "Kiran Kumar K" , Sunil Kumar Kori , Satha Rao CC: , Subject: [PATCH 1/9] common/cnxk: get mbox lock before NDC sync Date: Mon, 16 Jan 2023 15:09:46 +0530 Message-ID: <20230116093954.172938-1-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: 2OPSd4e9Qb-b1-JDxnK4yD62DFPz8Nvq X-Proofpoint-GUID: 2OPSd4e9Qb-b1-JDxnK4yD62DFPz8Nvq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-16_08,2023-01-13_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Take mbox lock before NDC sync to be thread safe. Also release the lock only after access to response is complete. Fixes: 7a978bc4be6b ("common/cnxk: support mailbox locking") Cc: rkudurumalla@marvell.com Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_tm.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c index 4e5f320712..4ced7a052f 100644 --- a/drivers/common/cnxk/roc_nix_tm.c +++ b/drivers/common/cnxk/roc_nix_tm.c @@ -690,13 +690,16 @@ roc_nix_tm_sq_free_pending_sqe(struct nix *nix, int q) mbox = dev->mbox; /* Sync NDC-NIX-TX for LF */ - ndc_req = mbox_alloc_msg_ndc_sync_op(mbox); - if (ndc_req == NULL) + ndc_req = mbox_alloc_msg_ndc_sync_op(mbox_get(mbox)); + if (ndc_req == NULL) { + mbox_put(mbox); return -EFAULT; + } ndc_req->nix_lf_tx_sync = 1; if (mbox_process(mbox)) rc |= NIX_ERR_NDC_SYNC; + mbox_put(mbox); if (rc) plt_err("NDC_SYNC failed rc %d", rc); @@ -1480,8 +1483,9 @@ nix_tm_alloc_txschq(struct nix *nix, enum roc_nix_tm_tree tree) mbox_put(mbox); goto alloc_err; } - mbox_put(mbox); + nix_tm_copy_rsp_to_nix(nix, rsp); + mbox_put(mbox); } while (pend); nix->tm_link_cfg_lvl = rsp->link_cfg_lvl;