diff mbox series

[v7,2/4] event/dlb2: remove superfluous rte_memcpy

Message ID 20230116130724.50277-2-mb@smartsharesystems.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [v7,1/4] net/bnx2x: fix warnings about rte_memcpy lengths |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Morten Brørup Jan. 16, 2023, 1:07 p.m. UTC 
  Copying with the same src and dst address has no effect; removed to
avoid compiler warning with decorated rte_memcpy.

Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
Cc: timothy.mcdaniel@intel.com

Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
---
v7:
* No changes.
v6:
* Add Fixes to patch description. (Stephen)
v5:
* First patch in series.
---
 drivers/event/dlb2/dlb2.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Morten Brørup Feb. 9, 2023, 4:51 p.m. UTC | #1 
PING dlb2 maintainers. Care to review this, so it can be included in 23.03?

> From: Morten Brørup [mailto:mb@smartsharesystems.com]
> Sent: Monday, 16 January 2023 14.07
> 
> Copying with the same src and dst address has no effect; removed to
> avoid compiler warning with decorated rte_memcpy.
> 
> Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
> Cc: timothy.mcdaniel@intel.com
> 
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v7:
> * No changes.
> v6:
> * Add Fixes to patch description. (Stephen)
> v5:
> * First patch in series.
> ---
>  drivers/event/dlb2/dlb2.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 60c5cd4804..03d32c779f 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -215,7 +215,6 @@ static int
>  dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)
>  {
>  	struct dlb2_hw_dev *handle = &dlb2->qm_instance;
> -	struct dlb2_hw_resource_info *dlb2_info = &handle->info;
>  	int num_ldb_ports;
>  	int ret;
> 
> @@ -277,8 +276,6 @@ dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)
>  	handle->info.hw_rsrc_max.reorder_window_size =
>  		dlb2->hw_rsrc_query_results.num_hist_list_entries;
> 
> -	rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max,
> sizeof(*dlb2_info));
> -
>  	return 0;
>  }
> 
> --
> 2.17.1
Sevincer, Abdullah Feb. 9, 2023, 6:50 p.m. UTC | #2 
Acked: by abdullah.sevincer@intel.com

-----Original Message-----
From: Morten Brørup <mb@smartsharesystems.com> 
Sent: Thursday, February 9, 2023 8:51 AM
To: dev@dpdk.org; roretzla@linux.microsoft.com; rmody@marvell.com; McDaniel, Timothy <timothy.mcdaniel@intel.com>; matan@nvidia.com; viacheslavo@nvidia.com
Cc: ruifeng.wang@arm.com; zhoumin@loongson.cn; drc@linux.vnet.ibm.com; kda@semihalf.com; Richardson, Bruce <bruce.richardson@intel.com>; konstantin.v.ananyev@yandex.ru
Subject: RE: [PATCH v7 2/4] event/dlb2: remove superfluous rte_memcpy

PING dlb2 maintainers. Care to review this, so it can be included in 23.03?

> From: Morten Brørup [mailto:mb@smartsharesystems.com]
> Sent: Monday, 16 January 2023 14.07
> 
> Copying with the same src and dst address has no effect; removed to 
> avoid compiler warning with decorated rte_memcpy.
> 
> Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
> Cc: timothy.mcdaniel@intel.com
> 
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v7:
> * No changes.
> v6:
> * Add Fixes to patch description. (Stephen)
> v5:
> * First patch in series.
> ---
>  drivers/event/dlb2/dlb2.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c 
> index 60c5cd4804..03d32c779f 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -215,7 +215,6 @@ static int
>  dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)  {
>  	struct dlb2_hw_dev *handle = &dlb2->qm_instance;
> -	struct dlb2_hw_resource_info *dlb2_info = &handle->info;
>  	int num_ldb_ports;
>  	int ret;
> 
> @@ -277,8 +276,6 @@ dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)
>  	handle->info.hw_rsrc_max.reorder_window_size =
>  		dlb2->hw_rsrc_query_results.num_hist_list_entries;
> 
> -	rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max,
> sizeof(*dlb2_info));
> -
>  	return 0;
>  }
> 
> --
> 2.17.1
Morten Brørup Feb. 10, 2023, 7:43 a.m. UTC | #3 
> From: Sevincer, Abdullah [mailto:abdullah.sevincer@intel.com]
> Sent: Thursday, 9 February 2023 19.50
> 
> Acked: by abdullah.sevincer@intel.com

Thanks.

Patchwork didn't catch it due to formatting, but the point is obvious:

Acked-by: Abdullah Sevincer <abdullah.sevincer@intel.com>

> 
> -----Original Message-----
> From: Morten Brørup <mb@smartsharesystems.com>
> Sent: Thursday, February 9, 2023 8:51 AM
> To: dev@dpdk.org; roretzla@linux.microsoft.com; rmody@marvell.com;
> McDaniel, Timothy <timothy.mcdaniel@intel.com>; matan@nvidia.com;
> viacheslavo@nvidia.com
> Cc: ruifeng.wang@arm.com; zhoumin@loongson.cn; drc@linux.vnet.ibm.com;
> kda@semihalf.com; Richardson, Bruce <bruce.richardson@intel.com>;
> konstantin.v.ananyev@yandex.ru
> Subject: RE: [PATCH v7 2/4] event/dlb2: remove superfluous rte_memcpy
> 
> PING dlb2 maintainers. Care to review this, so it can be included in
> 23.03?
> 
> > From: Morten Brørup [mailto:mb@smartsharesystems.com]
> > Sent: Monday, 16 January 2023 14.07
> >
> > Copying with the same src and dst address has no effect; removed to
> > avoid compiler warning with decorated rte_memcpy.
> >
> > Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
> > Cc: timothy.mcdaniel@intel.com
> >
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > v7:
> > * No changes.
> > v6:
> > * Add Fixes to patch description. (Stephen)
> > v5:
> > * First patch in series.
> > ---
> >  drivers/event/dlb2/dlb2.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> > index 60c5cd4804..03d32c779f 100644
> > --- a/drivers/event/dlb2/dlb2.c
> > +++ b/drivers/event/dlb2/dlb2.c
> > @@ -215,7 +215,6 @@ static int
> >  dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)  {
> >  	struct dlb2_hw_dev *handle = &dlb2->qm_instance;
> > -	struct dlb2_hw_resource_info *dlb2_info = &handle->info;
> >  	int num_ldb_ports;
> >  	int ret;
> >
> > @@ -277,8 +276,6 @@ dlb2_hw_query_resources(struct dlb2_eventdev
> *dlb2)
> >  	handle->info.hw_rsrc_max.reorder_window_size =
> >  		dlb2->hw_rsrc_query_results.num_hist_list_entries;
> >
> > -	rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max,
> > sizeof(*dlb2_info));
> > -
> >  	return 0;
> >  }
> >
> > --
> > 2.17.1
Jerin Jacob Feb. 23, 2024, 1:19 p.m. UTC | #4 
On Fri, Feb 10, 2023 at 1:13 PM Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > From: Sevincer, Abdullah [mailto:abdullah.sevincer@intel.com]
> > Sent: Thursday, 9 February 2023 19.50
> >
> > Acked: by abdullah.sevincer@intel.com
>
> Thanks.
>
> Patchwork didn't catch it due to formatting, but the point is obvious:
>
> Acked-by: Abdullah Sevincer <abdullah.sevincer@intel.com>

Applied to dpdk-next-eventdev/for-main. Thanks
diff mbox series

Patch

diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 60c5cd4804..03d32c779f 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -215,7 +215,6 @@  static int
 dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)
 {
 	struct dlb2_hw_dev *handle = &dlb2->qm_instance;
-	struct dlb2_hw_resource_info *dlb2_info = &handle->info;
 	int num_ldb_ports;
 	int ret;
 
@@ -277,8 +276,6 @@  dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)
 	handle->info.hw_rsrc_max.reorder_window_size =
 		dlb2->hw_rsrc_query_results.num_hist_list_entries;
 
-	rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max, sizeof(*dlb2_info));
-
 	return 0;
 }