[v2] eventdev/crypto: fix missing crypto vec limits

Message ID 20230118102148.233481-1-vfialko@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [v2] eventdev/crypto: fix missing crypto vec limits |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Volodymyr Fialko Jan. 18, 2023, 10:21 a.m. UTC
  Add missing function `rte_event_crypto_adapter_vector_limits_get` to
version.map.
Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")

Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
v2:
- mark function as experimental

 lib/eventdev/rte_event_crypto_adapter.h | 4 ++++
 lib/eventdev/version.map                | 1 +
 2 files changed, 5 insertions(+)
  

Comments

Gujjar, Abhinandan S Jan. 23, 2023, 9:35 a.m. UTC | #1
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>

> -----Original Message-----
> From: Volodymyr Fialko <vfialko@marvell.com>
> Sent: Wednesday, January 18, 2023 11:22 AM
> To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> Jerin Jacob <jerinj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> Volodymyr Fialko <vfialko@marvell.com>
> Cc: anoobj@marvell.com
> Subject: [PATCH v2] eventdev/crypto: fix missing crypto vec limits
> 
> Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> version.map.
> Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> 
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> ---
> v2:
> - mark function as experimental
> 
>  lib/eventdev/rte_event_crypto_adapter.h | 4 ++++
>  lib/eventdev/version.map                | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/lib/eventdev/rte_event_crypto_adapter.h
> b/lib/eventdev/rte_event_crypto_adapter.h
> index 83d154a6ce..2a69290097 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.h
> +++ b/lib/eventdev/rte_event_crypto_adapter.h
> @@ -595,6 +595,9 @@ int
>  rte_event_crypto_adapter_event_port_get(uint8_t id, uint8_t
> *event_port_id);
> 
>  /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
>   * Retrieve vector limits for a given event dev and crypto dev pair.
>   * @see rte_event_crypto_adapter_vector_limits
>   *
> @@ -610,6 +613,7 @@ rte_event_crypto_adapter_event_port_get(uint8_t id,
> uint8_t *event_port_id);
>   *  - 0: Success.
>   *  - <0: Error code on failure.
>   */
> +__rte_experimental
>  int rte_event_crypto_adapter_vector_limits_get(
>  	uint8_t dev_id, uint16_t cdev_id,
>  	struct rte_event_crypto_adapter_vector_limits *limits); diff --git
> a/lib/eventdev/version.map b/lib/eventdev/version.map index
> dd63ec6f68..c155af6d50 100644
> --- a/lib/eventdev/version.map
> +++ b/lib/eventdev/version.map
> @@ -110,6 +110,7 @@ EXPERIMENTAL {
>  	rte_event_eth_rx_adapter_event_port_get;
> 
>  	# added in 22.07
> +	rte_event_crypto_adapter_vector_limits_get;
>  	rte_event_port_quiesce;
>  	rte_event_queue_attr_set;
> 
> --
> 2.34.1
  
Jerin Jacob Jan. 23, 2023, 1:26 p.m. UTC | #2
On Mon, Jan 23, 2023 at 3:05 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>


Updated the git commit as follows and applied to
dpdk-next-net-eventdev/for-main. Thanks

eventdev/crypto: fix missing symbol in map file

>
> > -----Original Message-----
> > From: Volodymyr Fialko <vfialko@marvell.com>
> > Sent: Wednesday, January 18, 2023 11:22 AM
> > To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> > Jerin Jacob <jerinj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> > Volodymyr Fialko <vfialko@marvell.com>
> > Cc: anoobj@marvell.com
> > Subject: [PATCH v2] eventdev/crypto: fix missing crypto vec limits
> >
> > Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> > version.map.
> > Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> >
> > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > ---
> > v2:
> > - mark function as experimental
> >
> >  lib/eventdev/rte_event_crypto_adapter.h | 4 ++++
> >  lib/eventdev/version.map                | 1 +
> >  2 files changed, 5 insertions(+)
> >
> > diff --git a/lib/eventdev/rte_event_crypto_adapter.h
> > b/lib/eventdev/rte_event_crypto_adapter.h
> > index 83d154a6ce..2a69290097 100644
> > --- a/lib/eventdev/rte_event_crypto_adapter.h
> > +++ b/lib/eventdev/rte_event_crypto_adapter.h
> > @@ -595,6 +595,9 @@ int
> >  rte_event_crypto_adapter_event_port_get(uint8_t id, uint8_t
> > *event_port_id);
> >
> >  /**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice
> > + *
> >   * Retrieve vector limits for a given event dev and crypto dev pair.
> >   * @see rte_event_crypto_adapter_vector_limits
> >   *
> > @@ -610,6 +613,7 @@ rte_event_crypto_adapter_event_port_get(uint8_t id,
> > uint8_t *event_port_id);
> >   *  - 0: Success.
> >   *  - <0: Error code on failure.
> >   */
> > +__rte_experimental
> >  int rte_event_crypto_adapter_vector_limits_get(
> >       uint8_t dev_id, uint16_t cdev_id,
> >       struct rte_event_crypto_adapter_vector_limits *limits); diff --git
> > a/lib/eventdev/version.map b/lib/eventdev/version.map index
> > dd63ec6f68..c155af6d50 100644
> > --- a/lib/eventdev/version.map
> > +++ b/lib/eventdev/version.map
> > @@ -110,6 +110,7 @@ EXPERIMENTAL {
> >       rte_event_eth_rx_adapter_event_port_get;
> >
> >       # added in 22.07
> > +     rte_event_crypto_adapter_vector_limits_get;
> >       rte_event_port_quiesce;
> >       rte_event_queue_attr_set;
> >
> > --
> > 2.34.1
>
  

Patch

diff --git a/lib/eventdev/rte_event_crypto_adapter.h b/lib/eventdev/rte_event_crypto_adapter.h
index 83d154a6ce..2a69290097 100644
--- a/lib/eventdev/rte_event_crypto_adapter.h
+++ b/lib/eventdev/rte_event_crypto_adapter.h
@@ -595,6 +595,9 @@  int
 rte_event_crypto_adapter_event_port_get(uint8_t id, uint8_t *event_port_id);
 
 /**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
  * Retrieve vector limits for a given event dev and crypto dev pair.
  * @see rte_event_crypto_adapter_vector_limits
  *
@@ -610,6 +613,7 @@  rte_event_crypto_adapter_event_port_get(uint8_t id, uint8_t *event_port_id);
  *  - 0: Success.
  *  - <0: Error code on failure.
  */
+__rte_experimental
 int rte_event_crypto_adapter_vector_limits_get(
 	uint8_t dev_id, uint16_t cdev_id,
 	struct rte_event_crypto_adapter_vector_limits *limits);
diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index dd63ec6f68..c155af6d50 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -110,6 +110,7 @@  EXPERIMENTAL {
 	rte_event_eth_rx_adapter_event_port_get;
 
 	# added in 22.07
+	rte_event_crypto_adapter_vector_limits_get;
 	rte_event_port_quiesce;
 	rte_event_queue_attr_set;