[v3,00/10] codeql fixes for various subsystems
Message ID | 20230120044140.95975-1-okaya@kernel.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C85394242A; Fri, 20 Jan 2023 05:41:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B198140223; Fri, 20 Jan 2023 05:41:52 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mails.dpdk.org (Postfix) with ESMTP id 6F1C8400D5 for <dev@dpdk.org>; Fri, 20 Jan 2023 05:41:51 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 09428B81AFA for <dev@dpdk.org>; Fri, 20 Jan 2023 04:41:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64977C433D2; Fri, 20 Jan 2023 04:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674189709; bh=HzqhamxaJDcVx3UZ5zMHMWFTINwpZ8TeGUowVq7RClU=; h=From:To:Cc:Subject:Date:From; b=n1QjmNM04CjMXB80bXCoNnodubyQrLXhI7XCNFhjt/XSa1nJn4qaG7AjxRlxtgaAo wnUDZzl1nyOISXx9ewweJKLrLoqSLTH3YDskRa7iEonCYXj6LwEGdZTZNThtJ7RghG UrIU13s1gawDk20AlGtb1OhJPG2opLNP83BDLGmBfFFCHuSMbQTtcq9CIt2W8xcMt/ aFOGNmWseeb+Apss+5CWA0lBFbui6w6C16kD4G+8LGDLR3vavb3Zha+tLTzGlKnY/b QA2a89+/KAgQZ1Jh9jcV9wHZBiIcspZX45txylLQEqvEHIHwlorZdAr/U9m/radnR8 zOW0RCvnCxrhQ== From: okaya@kernel.org To: Cc: dev@dpdk.org, Sinan Kaya <okaya@kernel.org> Subject: [PATCH v3 00/10] codeql fixes for various subsystems Date: Thu, 19 Jan 2023 23:41:30 -0500 Message-Id: <20230120044140.95975-1-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Message
Sinan Kaya
Jan. 20, 2023, 4:41 a.m. UTC
From: Sinan Kaya <okaya@kernel.org>
Following up the codeql reported problems first submitted
by Stephen Hemminger here:
https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/
Posting a series of fixes about potential null pointer accesses.
Changes from v3:
- Dropped net/tap: check if name is null
- Moved the comment to the appropriate position in ethdev: check return result of rte_eth_dev_info_get
Changes from v2:
- Remove braces around single line statements
- use NULL comparisons
Sinan Kaya (10):
ethdev: check return result of rte_eth_dev_info_get
memzone: check result of rte_fbarray_get
memzone: check result of malloc_elem_from_data
malloc: malloc_elem_join_adjacent_free can return null
malloc: check result of rte_mem_virt2memseg_list
malloc: check result of rte_fbarray_get
malloc: check result of rte_mem_virt2memseg
malloc: check result of malloc_elem_free
malloc: check result of elem_start_pt
bus/vdev: check result of rte_vdev_device_name
lib/eal/common/eal_common_memalloc.c | 5 ++++-
lib/eal/common/eal_common_memzone.c | 10 +++++++++-
lib/eal/common/malloc_elem.c | 14 +++++++++++---
lib/eal/common/malloc_heap.c | 9 ++++++++-
lib/ethdev/ethdev_vdev.h | 2 ++
lib/ethdev/rte_class_eth.c | 4 +++-
6 files changed, 37 insertions(+), 7 deletions(-)