[v10,2/3] app/testpmd: add skip cman support for testpmd

Message ID 20230215174251.1698253-2-rkudurumalla@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [v10,1/3] ethdev: skip congestion management configuration |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Rakesh Kudurumalla Feb. 15, 2023, 5:42 p.m. UTC
  added support for testpmd application to accept
skip_cman action while configuring policy action

Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
 app/test-pmd/cmdline_flow.c | 9 +++++++++
 1 file changed, 9 insertions(+)
  

Comments

Ferruh Yigit Feb. 16, 2023, 12:19 p.m. UTC | #1
On 2/15/2023 5:42 PM, Rakesh Kudurumalla wrote:
> added support for testpmd application to accept
> skip_cman action while configuring policy action
> 
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>

A comment seems missed, please check v6 & v8 [1], can you please send a
new version with it?

[1]
https://inbox.dpdk.org/dev/67c958be-09e7-5c70-9a59-d471daeab4e8@amd.com/
  

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 63a0b36622..e4b17aa22d 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -488,6 +488,7 @@  enum index {
 	ACTION_END,
 	ACTION_VOID,
 	ACTION_PASSTHRU,
+	ACTION_SKIP_CMAN,
 	ACTION_JUMP,
 	ACTION_JUMP_GROUP,
 	ACTION_MARK,
@@ -1896,6 +1897,7 @@  static const enum index next_action[] = {
 	ACTION_END,
 	ACTION_VOID,
 	ACTION_PASSTHRU,
+	ACTION_SKIP_CMAN,
 	ACTION_JUMP,
 	ACTION_MARK,
 	ACTION_FLAG,
@@ -5385,6 +5387,13 @@  static const struct token token_list[] = {
 		.next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
 		.call = parse_vc,
 	},
+	[ACTION_SKIP_CMAN] = {
+		.name = "skip_cman",
+		.help = "bypass cman on received packets",
+		.priv = PRIV_ACTION(SKIP_CMAN, 0),
+		.next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
+		.call = parse_vc,
+	},
 	[ACTION_JUMP] = {
 		.name = "jump",
 		.help = "redirect traffic to a given group",