net/iavf: remove contrains for AEAD IV and AAD size

Message ID 20230217115246.72626-1-radu.nicolau@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/iavf: remove contrains for AEAD IV and AAD size |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Functional fail Functional Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing fail Testing issues
ci/iol-x86_64-unit-testing fail Testing issues
ci/github-robot: build success github build: passed
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS

Commit Message

Radu Nicolau Feb. 17, 2023, 11:52 a.m. UTC
  Because of incosistencies between IPsec library and sample app
implementations for inline crypto remove IV and AAD size constrains
from the advertised crypto capabilities

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 drivers/net/iavf/iavf_ipsec_crypto.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
  

Comments

Qi Zhang Feb. 21, 2023, 12:33 a.m. UTC | #1
> -----Original Message-----
> From: Radu Nicolau <radu.nicolau@intel.com>
> Sent: Friday, February 17, 2023 7:53 PM
> To: dev@dpdk.org
> Cc: Nicolau, Radu <radu.nicolau@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Subject: [PATCH] net/iavf: remove contrains for AEAD IV and AAD size
> 
> Because of incosistencies between IPsec library and sample app
> implementations for inline crypto remove IV and AAD size constrains from
> the advertised crypto capabilities
> 
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
  

Patch

diff --git a/drivers/net/iavf/iavf_ipsec_crypto.c b/drivers/net/iavf/iavf_ipsec_crypto.c
index 08a80137e5..082948b61f 100644
--- a/drivers/net/iavf/iavf_ipsec_crypto.c
+++ b/drivers/net/iavf/iavf_ipsec_crypto.c
@@ -1305,13 +1305,14 @@  update_aead_capabilities(struct rte_cryptodev_capabilities *scap,
 	capability->aead.key_size.max = acap->max_key_size;
 	capability->aead.key_size.increment = acap->inc_key_size;
 
-	capability->aead.aad_size.min = acap->min_aad_size;
-	capability->aead.aad_size.max = acap->max_aad_size;
-	capability->aead.aad_size.increment = acap->inc_aad_size;
-
-	capability->aead.iv_size.min = acap->min_iv_size;
-	capability->aead.iv_size.max = acap->max_iv_size;
-	capability->aead.iv_size.increment = acap->inc_iv_size;
+	/* remove constrains for aead and iv length */
+	capability->aead.aad_size.min = 0;
+	capability->aead.aad_size.max = 65535;
+	capability->aead.aad_size.increment = 1;
+
+	capability->aead.iv_size.min = 0;
+	capability->aead.iv_size.max = 65535;
+	capability->aead.iv_size.increment = 1;
 
 	capability->aead.digest_size.min = acap->min_digest_size;
 	capability->aead.digest_size.max = acap->max_digest_size;