From patchwork Tue Feb 21 07:07:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 124273 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9C6D41CFA; Tue, 21 Feb 2023 08:08:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4D3B43186; Tue, 21 Feb 2023 08:08:18 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2050.outbound.protection.outlook.com [40.107.243.50]) by mails.dpdk.org (Postfix) with ESMTP id C8AFB40E5A; Tue, 21 Feb 2023 08:08:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n84wNLuFwkeM7tvpfwgfFpUSLIUhxLqZs/SaGZb0Ber1aWDLT3xl8AFHY1oUqLgeCdW9YRIrpZM6TWcgTJI2dJCvhlmZqPKsQcJozpy5HZn8bOUjFQ4a+pWRlNLyzqC0FtOwIEd3e1MNR+d8YudemGmwNYCKTtWXgYhSyIfPwXEWPt1P2E97BlWbobrqCnQEyCwuMEb9H4c/sYx7ZCM8fc0VgtcKl2Z8FzSXAq4n7aWCQzi6XAgm82NWlC2hiSJEWRt4jL89kA5O/bxQhxdykVrh3tjFc6PORnCv1qiVKr8dUqdb0WnRdxKsQ3ukw+p0qtQOwN8E9nuZLTNaDzV2Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GJQfIIjH0Z9aj9pgESEV0hJI9ON0CnrFbxfULwkVs84=; b=gwOKuMAXDhOUSoS/S0EvV00ZNTIOdOc0u9MiciVmh940sQRiB9xRLLMmypj2FIZYnsDUKj/BlUWg288Ds/BXTwVaiQiVPXBrA25bVErzTadAL2KtTqa2GC6G/hHhEZDb6vyoE42cyevJ6jyJ6+tnC6zv9e96a+TJYT+cvyi1qMKQOOd59jbAhaslT2hbDCJcrZGHXNUu4Uh5Ybs/N5KjrEYU8zdKPjzY14f106QERjc9nC5P6A7G/sof9snEMURdxgKu6q9j0jRtB4N9argIIpcYK8ltLHSsvNtN0UOSRrc9mSGxNwPBWNt7nOyab9ntVwlCHX15AN8kPAj4Tt7ZXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJQfIIjH0Z9aj9pgESEV0hJI9ON0CnrFbxfULwkVs84=; b=diOC5YM0IrBd7sG2ByS2FZVzerO0zG/Ky02hct0wXtkDcJeFkGdaPR6Gm1ukf/NloabfqmVAnoxSvmuacrEtbA006FGTtSKMB/OqjYDsG29dafE6z0N6M/FY2HePAoHkw1LD5gG6YtiqmebFWJEl1ezqS97LpQXeA9XFH2afiCUAamxWPtfmY1iNTioACFhqqPZO9b5QEEdLO36Lop8RfvUjjWg+PisyWj7+/5h4bHM2oI9tPOZ7jPHO8zoOB7FvLMxOgS4oucLqAP0S0GFULPFXQUBfbsZMc9k8UqD9xZgAz9ZEbuuWVUlwhepHSAzYqj4eOAkkaOWfbC8z9AZDfQ== Received: from MW4PR03CA0199.namprd03.prod.outlook.com (2603:10b6:303:b8::24) by DS0PR12MB8319.namprd12.prod.outlook.com (2603:10b6:8:f7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 07:08:12 +0000 Received: from CO1NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b8:cafe::61) by MW4PR03CA0199.outlook.office365.com (2603:10b6:303:b8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21 via Frontend Transport; Tue, 21 Feb 2023 07:08:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT054.mail.protection.outlook.com (10.13.174.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.17 via Frontend Transport; Tue, 21 Feb 2023 07:08:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 20 Feb 2023 23:08:04 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 20 Feb 2023 23:08:03 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36 via Frontend Transport; Mon, 20 Feb 2023 23:08:01 -0800 From: Michael Baum To: CC: Matan Azrad , Akhil Goyal , "Thomas Monjalon" , , Subject: [PATCH v3 1/8] compress/mlx5: fix decompress xform validation Date: Tue, 21 Feb 2023 09:07:49 +0200 Message-ID: <20230221070756.3070819-2-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230221070756.3070819-1-michaelba@nvidia.com> References: <20230202162537.1067595-1-michaelba@nvidia.com> <20230221070756.3070819-1-michaelba@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT054:EE_|DS0PR12MB8319:EE_ X-MS-Office365-Filtering-Correlation-Id: 687010f5-185b-4a03-9f34-08db13da64dd X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c1fAWICbA13towAEgCuKzQISEN1tjowxGHXIRl0z3tRYiO+mAqVpXy/+gR9KeqUm7kD+8bEZtVgzaNut4Z2rIJyhcxhDf5UqsL6pIctCb8gQ3i63vrlTKJAiFZ/CwtGW6WMioNFXvWXU20/Og8PKzt5Cw9x2+FwVAFlqZ3ar9gB6sm2DKu6+bT3hGpecNfV7Z6sIy9EIkvXY5wDeNkaXlJS57EURbS4PnArWJGWzSO9TVttkHcgypcLDROg2eoAkHMyNPtNX2WzbtuBX3rnP0Izc9HoVpsIWK09ylsAaY13pqyRoHNWtr2VH/1HUp3islKEscYlRwkCvMjOP2SrtREJ2Br1HY8f54DtUJ/uJky0UxcY5sYqlt+eCWlvX5KtD+Z1cZa8qSbzeDFBArRD+Ab9G/Z45xA/Og8aFV+JH4joef7+AxpEYRutfDzTLF7eQyjmAzR4tNLaH9ogW14QsyYkO6n9gnLrcds+QStJqkoP8dKoWurbqRWL8y1ZHZvsNREDgPALIKlgxzy7PtX8gJf4rJU9QrEaW2jASIfaNarR++IMeFDXS3k4Kl75mHXK3CxtzR53aLFQVnmKADF8gbMNjkqi5zahxH9HUTwnPoE5z5QARbnbGNBPxUtaUYkUBhtmunNnIEX9lmY4OYEmGPgjy1U8ncPhA8wc19hpNuLQqZPuiBCMIUiE+WDIOCZhHl8fi0h8J8R7pAu9OgtqvBw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(186003)(26005)(6286002)(40460700003)(8936002)(4326008)(6916009)(1076003)(336012)(5660300002)(2616005)(426003)(47076005)(83380400001)(6666004)(82310400005)(36860700001)(36756003)(478600001)(40480700001)(55016003)(7636003)(82740400003)(7696005)(8676002)(41300700001)(70206006)(70586007)(2906002)(86362001)(54906003)(316002)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 07:08:11.8163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 687010f5-185b-4a03-9f34-08db13da64dd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8319 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In xform creation, it first validate the xform according the capabilities. One of validations verifies that given "hash_algo" is "RTE_COMP_HASH_ALGO_NONE" for both compress and decompress xform objects. However, the validation for decompress checks it again for compress xform object. This patch changes it to verify decompress xform object. Fixes: 2efd26544554 ("compress/mlx5: support partial transformation") Cc: rzidane@nvidia.com Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/compress/mlx5/mlx5_compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index 430f769d41..06d1ff5b95 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -313,7 +313,7 @@ mlx5_compress_xform_create(struct rte_compressdev *dev, DRV_LOG(ERR, "Not enough capabilities to support decompress operation, maybe old FW/OFED version?"); return -ENOTSUP; } - if (xform->compress.hash_algo != RTE_COMP_HASH_ALGO_NONE) { + if (xform->decompress.hash_algo != RTE_COMP_HASH_ALGO_NONE) { DRV_LOG(ERR, "SHA is not supported."); return -ENOTSUP; }