From patchwork Tue Feb 21 18:55:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 124307 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93F2541D31; Tue, 21 Feb 2023 19:56:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A88542D1A; Tue, 21 Feb 2023 19:56:02 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id B935B40691 for ; Tue, 21 Feb 2023 19:55:58 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id y2so1833622pjg.3 for ; Tue, 21 Feb 2023 10:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GAlRbq3o7ovDqkKTT41WAN/GYRy/jddESUXIeIkPiqg=; b=yDd6gmDk7ibuaZqPynYtvXktRacWTO8NqpfKh4/yQZ/aIfbac745Ktq8oZsFFe8GpG k1h4DZkX3YN1ZaDTVDmuVfW/Wfirea5aYGbDBhkKdR5G6KP8IhY3dCS5ZDpfQAzF+fFT jaogLc1zh/Qny0wcI+RX1aQ+hm8kTjAOqitcmyaovYC6sgtpLjBGY2Xz1VVwAXXbHqTv fBZjW91c+qMgj60TRS5RpQ14ffCN9v0NX+eyUWgh05nGBFLP1HmezSa2E8pFFRPH94Vw XB9A0bSyslmT72FsL4GL5xv9xFRiavQUf4W+tZm5hhXBkpMaPSU94hwuc8KVB9qU1cL1 EWDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GAlRbq3o7ovDqkKTT41WAN/GYRy/jddESUXIeIkPiqg=; b=gSWwuDimayTvJbjHZ2mVvWWpmP4/seUA/rc5VVOSPycbAwxk+gr5cI2Dl26zFfKgyN 5XK5z9Am899tynMaUEwnvYnIXP+GXbtEsZBhivcRMyxeyN2kY8LR/NxD1YROI5Xb0FnP MyGN5JjmtQr3so9pne5JVTIdbTyrDQKaSeBw8FKlBF8ycpi8ybkrp1CqZTZtYUhNhFkn /Vs6GxYU4ZA38OYbb6aX50XmuIZ3QmPq4vGIe5MoHGBdE8oWp3rJyY6P0c7Kp0FPqpvx C9jqPsrQ/PQFKDRW4/T+BrloVd4fjdBn+39CxKRhRaL7axyWTmoJ3xC5MJkFptmtO+pw VlIg== X-Gm-Message-State: AO0yUKUaokwYKue/VNYjjiKjcSdkM8x+jjKDU60xWOCcF1wZaT0QZab3 WQGiRl4XkGGOl9N7jSkLH4cOyVB2aFOSFIoMLLs= X-Google-Smtp-Source: AK7set8TQ10Kn80G7bfpkuL475YEtEzhmmDRflhQI6GDAyCRL38Xt/jZMlEgCciFPF04dIiCnVDOkg== X-Received: by 2002:a17:902:c410:b0:199:2e01:13fb with SMTP id k16-20020a170902c41000b001992e0113fbmr5638419plk.20.1677005757976; Tue, 21 Feb 2023 10:55:57 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id iz15-20020a170902ef8f00b00189c4b8ca21sm6357895plb.18.2023.02.21.10.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 10:55:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , sergio.gonzalez.monroy@intel.com Subject: [PATCH v7 2/5] reorder: use a dynamic logtype Date: Tue, 21 Feb 2023 10:55:50 -0800 Message-Id: <20230221185553.513432-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230221185553.513432-1-stephen@networkplumber.org> References: <0230208044825.1682620-1-stephen@networkplumber.org> <20230221185553.513432-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Libraries should not be reusing RTE_LOGTYPE_USER1 instead of doing proper logtype registration. Fixes: b70b56032bff ("reorder: new library") Cc: sergio.gonzalez.monroy@intel.com Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index 6e029c9e02fd..7a3a97972cb7 100644 --- a/lib/reorder/rte_reorder.c +++ b/lib/reorder/rte_reorder.c @@ -15,6 +15,9 @@ #include "rte_reorder.h" +RTE_LOG_REGISTER_DEFAULT(reorder_logtype, INFO); +#define RTE_LOGTYPE_REORDER reorder_logtype + TAILQ_HEAD(rte_reorder_list, rte_tailq_entry); static struct rte_tailq_elem rte_reorder_tailq = { @@ -26,9 +29,6 @@ EAL_REGISTER_TAILQ(rte_reorder_tailq) #define RTE_REORDER_PREFIX "RO_" #define RTE_REORDER_NAMESIZE 32 -/* Macros for printing using RTE_LOG */ -#define RTE_LOGTYPE_REORDER RTE_LOGTYPE_USER1 - #define RTE_REORDER_SEQN_DYNFIELD_NAME "rte_reorder_seqn_dynfield" int rte_reorder_seqn_dynfield_offset = -1;