diff mbox series

common/idpf: fix Rx queue configuration

Message ID 20230223031646.11222-1-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series common/idpf: fix Rx queue configuration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Xing, Beilei Feb. 23, 2023, 3:16 a.m. UTC 
  From: Beilei Xing <beilei.xing@intel.com>

IDPF PMD enables 2 buffer queues by default. According to the data
sheet, if there is a second buffer queue, the second buffer queue
is valid only if bugq2_ena is set.

Fixes: c2494d783d31 ("net/idpf: support queue start")
Fixes: 8b95ced47a13 ("common/idpf: add Rx/Tx queue structs")
Cc: stable@dpdk.org

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 drivers/common/idpf/idpf_common_virtchnl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jingjing Wu Feb. 23, 2023, 4:23 a.m. UTC | #1 
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Thursday, February 23, 2023 11:17 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org
> Subject: [PATCH] common/idpf: fix Rx queue configuration
> 
> From: Beilei Xing <beilei.xing@intel.com>
> 
> IDPF PMD enables 2 buffer queues by default. According to the data
> sheet, if there is a second buffer queue, the second buffer queue
> is valid only if bugq2_ena is set.
> 
> Fixes: c2494d783d31 ("net/idpf: support queue start")
> Fixes: 8b95ced47a13 ("common/idpf: add Rx/Tx queue structs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Qi Zhang Feb. 24, 2023, 2:36 a.m. UTC | #2 
> -----Original Message-----
> From: Wu, Jingjing <jingjing.wu@intel.com>
> Sent: Thursday, February 23, 2023 12:24 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] common/idpf: fix Rx queue configuration
> 
> 
> 
> > -----Original Message-----
> > From: Xing, Beilei <beilei.xing@intel.com>
> > Sent: Thursday, February 23, 2023 11:17 AM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH] common/idpf: fix Rx queue configuration
> >
> > From: Beilei Xing <beilei.xing@intel.com>
> >
> > IDPF PMD enables 2 buffer queues by default. According to the data
> > sheet, if there is a second buffer queue, the second buffer queue is
> > valid only if bugq2_ena is set.
> >
> > Fixes: c2494d783d31 ("net/idpf: support queue start")
> > Fixes: 8b95ced47a13 ("common/idpf: add Rx/Tx queue structs")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/common/idpf/idpf_common_virtchnl.c b/drivers/common/idpf/idpf_common_virtchnl.c
index 99d9efbb7c..9ee7259539 100644
--- a/drivers/common/idpf/idpf_common_virtchnl.c
+++ b/drivers/common/idpf/idpf_common_virtchnl.c
@@ -987,6 +987,7 @@  idpf_vc_rxq_config(struct idpf_vport *vport, struct idpf_rx_queue *rxq)
 
 		rxq_info->ring_len = rxq->nb_rx_desc;
 		rxq_info->rx_bufq1_id = rxq->bufq1->queue_id;
+		rxq_info->bufq2_ena = 1;
 		rxq_info->rx_bufq2_id = rxq->bufq2->queue_id;
 		rxq_info->rx_buffer_low_watermark = 64;