From patchwork Tue Feb 28 18:02:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 124592 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 685A941D9F; Tue, 28 Feb 2023 19:02:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E0C5410DC; Tue, 28 Feb 2023 19:02:46 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2059.outbound.protection.outlook.com [40.107.92.59]) by mails.dpdk.org (Postfix) with ESMTP id 253874021F; Tue, 28 Feb 2023 19:02:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVEuCLMDuqlZUD58+lDK4H++wPu42KY94zq2kUyJOdL/meN7QL/L7wL+XkoAEvho/y73Q8vHbkWaaGl+hooSYZxxXyuXBLW/ETR5CzbfFytJYT1IsxDa5xsQs6TI4fer4tz3zK9eK4SSkokodwIfhjesZ/rJ2ahfWTwm/cllnTHPOYOPR4nwg2dRLrC4q/7Z+6I1whT71O+09FwnDjbMkQeXjuKYbIpNNQzCzLutysEg2n8hvfzCFh0+wBAcMgEaofUeITjDaPGRC4bNJfk7KFweOzm5+2p+zcAnRWcKXtrTwZQlBgOMIl7yDG+y/8JJPyYPaS7iV+nMYi5uqKJi3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bhqWBbxN0Dpb3Hhi8a7P4e2j/CLs2+gB5HPu7iAR8Ag=; b=XJinw/9a4Ej/ITBU7LTzZSbSBXL0OgZzJ4ugAsibVcURmpeJZ/yu3yvuXmMWGwyns3Al6+boUjIEd8KxMe923+/GyXxjnZQEF/42HA5niKtLi091gBXCJ5uwrHq1DUiYisyEfMSECXy4xbyZRfQ4pIWCM8gazZZGXAA3YNqnguQDwFK0qrh37IiGthu4Kw3siXYPjFTQql0HaW/FK/MjyN3kOR9iABeVdXr4SeMHZsGdrIKKBBbOHcdn9wAV5UJKnYXDundHaP41eaVO8hrrHREKFQ3n2qajFCJYpD7oaziC2qNhrNdiijqU4ktIG5hT1vmzi6X6xn5Dcr9byswiQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=monjalon.net smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bhqWBbxN0Dpb3Hhi8a7P4e2j/CLs2+gB5HPu7iAR8Ag=; b=sux3Bnq8QUYOpBP174Uyn7fz/EjR5aaguwbrE3PhpQXRYKNHeh1vhTJ0L3lU++YCuweC6FcqM8b07durDSl9pOU+KkYIjkffW3BedBU1mcA9O9oYHnAGDS5zUa+NZzZfqs2lzIHXAFB0t2h/KFRaBiseS7Dk9P3BgabUInVsDY4= Received: from MW4PR03CA0179.namprd03.prod.outlook.com (2603:10b6:303:8d::34) by SJ2PR12MB7822.namprd12.prod.outlook.com (2603:10b6:a03:4ca::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Tue, 28 Feb 2023 18:02:43 +0000 Received: from CO1NAM11FT036.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8d:cafe::d) by MW4PR03CA0179.outlook.office365.com (2603:10b6:303:8d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30 via Frontend Transport; Tue, 28 Feb 2023 18:02:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT036.mail.protection.outlook.com (10.13.174.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.17 via Frontend Transport; Tue, 28 Feb 2023 18:02:42 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 28 Feb 2023 12:02:41 -0600 From: Ferruh Yigit To: Thomas Monjalon , Andrew Rybchenko , Gowrishankar Muthukrishnan CC: , , Bruce Richardson , Qi Zhang Subject: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field Date: Tue, 28 Feb 2023 18:02:30 +0000 Message-ID: <20230228180230.3066738-1-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT036:EE_|SJ2PR12MB7822:EE_ X-MS-Office365-Filtering-Correlation-Id: d660e94b-31e0-42a6-fb86-08db19b5fd20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 52ARzDwYc1SOHsIag6mX5z7VQ5WajvHlFf3seRrM62/jU3FRZbdSAoyFJ+cLG7lLofV9AZqmUBb8jXJxJE6b9svQHnJxkFnX5VW+SnXqqFMJGaU53ft9uqHQ/y7eMKNZHmJzaoxgDrK12juJLS34NRVdkD4oQ1pimc4mrJaaQQA4795Fj8Ub7wPL5/d00i9q0RSC9/byANLlGuY7GbM8WCxAB+To1QJOlDNJnGOU+2U/HKOFlxJOeTszU8Xb8BNkF8g1Jdb+1H3TqsXg1pyfEDCfru/bsTdg74pJOd5yD2lobAFpqUb06BpZwG1TAe55YuDIxy5Oj/XWr+hqqqniZJtYluNyDkVCsnf52jBqhJP8xtZuhJn+KFYpiUtD7imWyPJnY6z939sT1+DbkvyBnUuHEJnkXfJ8MMBMYr3JiQPZOFy8l0m9sIgUpth9UTRa+SUi9EuTU6UezfOSzQVjfWf51vD6tRmhUmvUo7tioxrKfpFXZYiZv6kWzurUI1Yj4yZLb8Qf/y2MJxkE6WgDulaJNtFB+JeG2RF58E/CBwMbMTsNbCQXQYVEE3HdA4MMSMR7e73XHscCs+JnT5eplJTzWpvY/PRpZB+nPHhbSnNBxBCGpdRtsjl3I0jw5NVtAm4ia85nDwknic5qh5QmpBumJr4ek9RofnnbnwOANT7nOwH1WXZJ491haiVZy+8JQw4YvqQAMp9sBo9qdhisGcGlD1WNAO51XcrGvKuftk4= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199018)(46966006)(40470700004)(36840700001)(82740400003)(81166007)(5660300002)(2616005)(86362001)(54906003)(47076005)(110136005)(336012)(426003)(82310400005)(356005)(478600001)(36860700001)(8936002)(70206006)(83380400001)(4326008)(36756003)(41300700001)(2906002)(70586007)(8676002)(186003)(7696005)(44832011)(6666004)(40460700003)(16526019)(316002)(40480700001)(26005)(1076003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 18:02:42.8066 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d660e94b-31e0-42a6-fb86-08db19b5fd20 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT036.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7822 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to user via ethdev APIs but it is used internally to set "stats->rx_nombuf' which is exposed via ehtdev stat APIs. But telemetry exposes this field to user via "/ethdev/info", instead user can get 'rx_nombuf' value from stats via "/ethdev/stats". Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- Cc: gmuthukrishn@marvell.com Cc: Bruce Richardson Cc: Qi Zhang --- lib/ethdev/rte_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 0266cc82acb6..06f2c1ca001f 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -6636,8 +6636,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, rte_tel_data_add_dict_int(d, "mtu", eth_dev->data->mtu); rte_tel_data_add_dict_uint(d, "rx_mbuf_size_min", eth_dev->data->min_rx_buf_size); - rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail", - eth_dev->data->rx_mbuf_alloc_failed); rte_ether_format_addr(mac_addr, sizeof(mac_addr), eth_dev->data->mac_addrs); rte_tel_data_add_dict_string(d, "mac_addr", mac_addr);