mbox

[0/5] fix race-condition of proactive error handling mode

Message ID 20230301030610.49468-1-fengchengwen@huawei.com (mailing list archive)
Headers

Message

fengchengwen March 1, 2023, 3:06 a.m. UTC 
  This patch fixes race-condition of proactive error handling mode, the
discussion thread [1].

[1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/

Chengwen Feng (5):
  ethdev: fix race-condition of proactive error handling mode
  net/hns3: replace fp ops config function
  net/bnxt: fix race-condition when report error recovery
  net/bnxt: use fp ops setup function
  app/testpmd: add error recovery usage demo

 app/test-pmd/testpmd.c                  | 80 +++++++++++++++++++++++++
 app/test-pmd/testpmd.h                  |  4 +-
 doc/guides/prog_guide/poll_mode_drv.rst | 20 +++----
 drivers/net/bnxt/bnxt_cpr.c             | 18 +++---
 drivers/net/bnxt/bnxt_ethdev.c          |  9 +--
 drivers/net/hns3/hns3_rxtx.c            | 21 +------
 lib/ethdev/ethdev_driver.c              |  8 +++
 lib/ethdev/ethdev_driver.h              | 10 ++++
 lib/ethdev/rte_ethdev.h                 | 32 ++++++----
 lib/ethdev/version.map                  |  1 +
 10 files changed, 143 insertions(+), 60 deletions(-)

Comments

Ferruh Yigit Sept. 21, 2023, 11:12 a.m. UTC | #1 
On 3/1/2023 3:06 AM, Chengwen Feng wrote:
> This patch fixes race-condition of proactive error handling mode, the
> discussion thread [1].
> 
> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/
> 
> Chengwen Feng (5):
>   ethdev: fix race-condition of proactive error handling mode
>   net/hns3: replace fp ops config function
>   net/bnxt: fix race-condition when report error recovery
>   net/bnxt: use fp ops setup function
>   app/testpmd: add error recovery usage demo
> 

Hi Chengwen,

This patch is old and as discussion get longer it became hard to
follow/manage.

If the issue is valid, can you please refresh the patchset?
Sorry for the inconvenience.
fengchengwen Oct. 7, 2023, 2:32 a.m. UTC | #2 
Hi Ferruh,

Thanks for the reminder.

I will send a new version as soon as possible.

Thanks.

On 2023/9/21 19:12, Ferruh Yigit wrote:
> On 3/1/2023 3:06 AM, Chengwen Feng wrote:
>> This patch fixes race-condition of proactive error handling mode, the
>> discussion thread [1].
>>
>> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/
>>
>> Chengwen Feng (5):
>>   ethdev: fix race-condition of proactive error handling mode
>>   net/hns3: replace fp ops config function
>>   net/bnxt: fix race-condition when report error recovery
>>   net/bnxt: use fp ops setup function
>>   app/testpmd: add error recovery usage demo
>>
> 
> Hi Chengwen,
> 
> This patch is old and as discussion get longer it became hard to
> follow/manage.
> 
> If the issue is valid, can you please refresh the patchset?
> Sorry for the inconvenience.
> 
> .
>
fengchengwen Nov. 6, 2023, 1:35 a.m. UTC | #3 
Friendly ping.

On 2023/10/20 18:07, Chengwen Feng wrote:
> This patch fixes race-condition of proactive error handling mode, the
> discussion thread [1].
> 
> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/
> 
> Chengwen Feng (7):
>   ethdev: fix race-condition of proactive error handling mode
>   net/hns3: replace fp ops config function
>   net/bnxt: fix race-condition when report error recovery
>   net/bnxt: use fp ops setup function
>   app/testpmd: add error recovery usage demo
>   app/testpmd: extract event handling to event.c
>   doc: testpmd support event handling section
> 
> ---
> v2: 
> - extract event handling to event.c and document it, which address
>   Ferruh's comment.
> - add ack-by from Konstantin Ananyev and Dongdong Liu.
> 
>  app/test-pmd/event.c                         | 390 +++++++++++++++++++
>  app/test-pmd/meson.build                     |   1 +
>  app/test-pmd/parameters.c                    |  36 +-
>  app/test-pmd/testpmd.c                       | 247 +-----------
>  app/test-pmd/testpmd.h                       |  10 +-
>  doc/guides/prog_guide/poll_mode_drv.rst      |  20 +-
>  doc/guides/testpmd_app_ug/event_handling.rst |  80 ++++
>  doc/guides/testpmd_app_ug/index.rst          |   1 +
>  drivers/net/bnxt/bnxt_cpr.c                  |  18 +-
>  drivers/net/bnxt/bnxt_ethdev.c               |   9 +-
>  drivers/net/hns3/hns3_rxtx.c                 |  21 +-
>  lib/ethdev/ethdev_driver.c                   |   8 +
>  lib/ethdev/ethdev_driver.h                   |  10 +
>  lib/ethdev/rte_ethdev.h                      |  32 +-
>  lib/ethdev/version.map                       |   1 +
>  15 files changed, 551 insertions(+), 333 deletions(-)
>  create mode 100644 app/test-pmd/event.c
>  create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst
>
fengchengwen Dec. 5, 2023, 2:30 a.m. UTC | #4 
Hi Ferruh,

I notice this patchset was delegated to you, so could you take a view?

Thanks.

On 2023/11/6 21:11, Chengwen Feng wrote:
> This patch fixes race-condition of proactive error handling mode, the
> discussion thread [1].
> 
> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/
> 
> Chengwen Feng (7):
>   ethdev: fix race-condition of proactive error handling mode
>   net/hns3: replace fp ops config function
>   net/bnxt: fix race-condition when report error recovery
>   net/bnxt: use fp ops setup function
>   app/testpmd: add error recovery usage demo
>   app/testpmd: extract event handling to event.c
>   doc: testpmd support event handling section
> 
> ---
> v3:
> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit.
> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li.
> v2:
> - extract event handling to event.c and document it, which address
>   Ferruh's comment.
> - add ack-by from Konstantin Ananyev and Dongdong Liu.
> 
>  app/test-pmd/event.c                         | 390 +++++++++++++++++++
>  app/test-pmd/meson.build                     |   1 +
>  app/test-pmd/parameters.c                    |  36 +-
>  app/test-pmd/testpmd.c                       | 247 +-----------
>  app/test-pmd/testpmd.h                       |  10 +-
>  doc/guides/prog_guide/poll_mode_drv.rst      |  20 +-
>  doc/guides/testpmd_app_ug/event_handling.rst |  81 ++++
>  doc/guides/testpmd_app_ug/index.rst          |   1 +
>  drivers/net/bnxt/bnxt_cpr.c                  |  18 +-
>  drivers/net/bnxt/bnxt_ethdev.c               |   9 +-
>  drivers/net/hns3/hns3_rxtx.c                 |  21 +-
>  lib/ethdev/ethdev_driver.c                   |   8 +
>  lib/ethdev/ethdev_driver.h                   |  10 +
>  lib/ethdev/rte_ethdev.h                      |  32 +-
>  lib/ethdev/version.map                       |   1 +
>  15 files changed, 552 insertions(+), 333 deletions(-)
>  create mode 100644 app/test-pmd/event.c
>  create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst
>
fengchengwen Jan. 15, 2024, 1:44 a.m. UTC | #5 
Kindly ping.

On 2023/12/5 10:30, fengchengwen wrote:
> Hi Ferruh,
> 
> I notice this patchset was delegated to you, so could you take a view?
> 
> Thanks.
> 
> On 2023/11/6 21:11, Chengwen Feng wrote:
>> This patch fixes race-condition of proactive error handling mode, the
>> discussion thread [1].
>>
>> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/
>>
>> Chengwen Feng (7):
>>   ethdev: fix race-condition of proactive error handling mode
>>   net/hns3: replace fp ops config function
>>   net/bnxt: fix race-condition when report error recovery
>>   net/bnxt: use fp ops setup function
>>   app/testpmd: add error recovery usage demo
>>   app/testpmd: extract event handling to event.c
>>   doc: testpmd support event handling section
>>
>> ---
>> v3:
>> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit.
>> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li.
>> v2:
>> - extract event handling to event.c and document it, which address
>>   Ferruh's comment.
>> - add ack-by from Konstantin Ananyev and Dongdong Liu.
>>
>>  app/test-pmd/event.c                         | 390 +++++++++++++++++++
>>  app/test-pmd/meson.build                     |   1 +
>>  app/test-pmd/parameters.c                    |  36 +-
>>  app/test-pmd/testpmd.c                       | 247 +-----------
>>  app/test-pmd/testpmd.h                       |  10 +-
>>  doc/guides/prog_guide/poll_mode_drv.rst      |  20 +-
>>  doc/guides/testpmd_app_ug/event_handling.rst |  81 ++++
>>  doc/guides/testpmd_app_ug/index.rst          |   1 +
>>  drivers/net/bnxt/bnxt_cpr.c                  |  18 +-
>>  drivers/net/bnxt/bnxt_ethdev.c               |   9 +-
>>  drivers/net/hns3/hns3_rxtx.c                 |  21 +-
>>  lib/ethdev/ethdev_driver.c                   |   8 +
>>  lib/ethdev/ethdev_driver.h                   |  10 +
>>  lib/ethdev/rte_ethdev.h                      |  32 +-
>>  lib/ethdev/version.map                       |   1 +
>>  15 files changed, 552 insertions(+), 333 deletions(-)
>>  create mode 100644 app/test-pmd/event.c
>>  create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst
>>
> .
>
fengchengwen Jan. 29, 2024, 1:16 a.m. UTC | #6 
Hi Ferruh,

Kindly ping for review.

Thanks

On 2024/1/15 9:44, fengchengwen wrote:
> Kindly ping.
> 
> On 2023/12/5 10:30, fengchengwen wrote:
>> Hi Ferruh,
>>
>> I notice this patchset was delegated to you, so could you take a view?
>>
>> Thanks.
>>
>> On 2023/11/6 21:11, Chengwen Feng wrote:
>>> This patch fixes race-condition of proactive error handling mode, the
>>> discussion thread [1].
>>>
>>> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/
>>>
>>> Chengwen Feng (7):
>>>   ethdev: fix race-condition of proactive error handling mode
>>>   net/hns3: replace fp ops config function
>>>   net/bnxt: fix race-condition when report error recovery
>>>   net/bnxt: use fp ops setup function
>>>   app/testpmd: add error recovery usage demo
>>>   app/testpmd: extract event handling to event.c
>>>   doc: testpmd support event handling section
>>>
>>> ---
>>> v3:
>>> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit.
>>> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li.
>>> v2:
>>> - extract event handling to event.c and document it, which address
>>>   Ferruh's comment.
>>> - add ack-by from Konstantin Ananyev and Dongdong Liu.
>>>
>>>  app/test-pmd/event.c                         | 390 +++++++++++++++++++
>>>  app/test-pmd/meson.build                     |   1 +
>>>  app/test-pmd/parameters.c                    |  36 +-
>>>  app/test-pmd/testpmd.c                       | 247 +-----------
>>>  app/test-pmd/testpmd.h                       |  10 +-
>>>  doc/guides/prog_guide/poll_mode_drv.rst      |  20 +-
>>>  doc/guides/testpmd_app_ug/event_handling.rst |  81 ++++
>>>  doc/guides/testpmd_app_ug/index.rst          |   1 +
>>>  drivers/net/bnxt/bnxt_cpr.c                  |  18 +-
>>>  drivers/net/bnxt/bnxt_ethdev.c               |   9 +-
>>>  drivers/net/hns3/hns3_rxtx.c                 |  21 +-
>>>  lib/ethdev/ethdev_driver.c                   |   8 +
>>>  lib/ethdev/ethdev_driver.h                   |  10 +
>>>  lib/ethdev/rte_ethdev.h                      |  32 +-
>>>  lib/ethdev/version.map                       |   1 +
>>>  15 files changed, 552 insertions(+), 333 deletions(-)
>>>  create mode 100644 app/test-pmd/event.c
>>>  create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst
>>>
>> .
>>
> .
>
fengchengwen Feb. 18, 2024, 3:41 a.m. UTC | #7 
Hi Ferruh,

This patchset will modify lib/ethdev/, Could you help review it before RC1?

Thanks

On 2024/1/29 9:16, fengchengwen wrote:
> Hi Ferruh,
> 
> Kindly ping for review.
> 
> Thanks
> 
> On 2024/1/15 9:44, fengchengwen wrote:
>> Kindly ping.
>>
>> On 2023/12/5 10:30, fengchengwen wrote:
>>> Hi Ferruh,
>>>
>>> I notice this patchset was delegated to you, so could you take a view?
>>>
>>> Thanks.
>>>
>>> On 2023/11/6 21:11, Chengwen Feng wrote:
>>>> This patch fixes race-condition of proactive error handling mode, the
>>>> discussion thread [1].
>>>>
>>>> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/
>>>>
>>>> Chengwen Feng (7):
>>>>   ethdev: fix race-condition of proactive error handling mode
>>>>   net/hns3: replace fp ops config function
>>>>   net/bnxt: fix race-condition when report error recovery
>>>>   net/bnxt: use fp ops setup function
>>>>   app/testpmd: add error recovery usage demo
>>>>   app/testpmd: extract event handling to event.c
>>>>   doc: testpmd support event handling section
>>>>
>>>> ---
>>>> v3:
>>>> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit.
>>>> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li.
>>>> v2:
>>>> - extract event handling to event.c and document it, which address
>>>>   Ferruh's comment.
>>>> - add ack-by from Konstantin Ananyev and Dongdong Liu.
>>>>
>>>>  app/test-pmd/event.c                         | 390 +++++++++++++++++++
>>>>  app/test-pmd/meson.build                     |   1 +
>>>>  app/test-pmd/parameters.c                    |  36 +-
>>>>  app/test-pmd/testpmd.c                       | 247 +-----------
>>>>  app/test-pmd/testpmd.h                       |  10 +-
>>>>  doc/guides/prog_guide/poll_mode_drv.rst      |  20 +-
>>>>  doc/guides/testpmd_app_ug/event_handling.rst |  81 ++++
>>>>  doc/guides/testpmd_app_ug/index.rst          |   1 +
>>>>  drivers/net/bnxt/bnxt_cpr.c                  |  18 +-
>>>>  drivers/net/bnxt/bnxt_ethdev.c               |   9 +-
>>>>  drivers/net/hns3/hns3_rxtx.c                 |  21 +-
>>>>  lib/ethdev/ethdev_driver.c                   |   8 +
>>>>  lib/ethdev/ethdev_driver.h                   |  10 +
>>>>  lib/ethdev/rte_ethdev.h                      |  32 +-
>>>>  lib/ethdev/version.map                       |   1 +
>>>>  15 files changed, 552 insertions(+), 333 deletions(-)
>>>>  create mode 100644 app/test-pmd/event.c
>>>>  create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst
>>>>
>>> .
>>>
>> .
>>
> .
>