[13/15] common/cnxk: add RSS error messages on mbox failure

Message ID 20230303081013.589868-13-ndabilpuram@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [01/15] net/cnxk: resolve sefgault caused during transmit completion |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Nithin Dabilpuram March 3, 2023, 8:10 a.m. UTC
  From: Hiral <hshah@marvell.com>

Clarifying otx2_process_msgs() RSS error messages

Signed-off-by: Hiral <hshah@marvell.com>
---
 .mailmap                        | 1 +
 drivers/common/cnxk/roc_dev.c   | 4 ++--
 drivers/common/cnxk/roc_utils.c | 6 ++++++
 3 files changed, 9 insertions(+), 2 deletions(-)
  

Patch

diff --git a/.mailmap b/.mailmap
index 5015494210..ef4c4c36a2 100644
--- a/.mailmap
+++ b/.mailmap
@@ -487,6 +487,7 @@  Herbert Guan <herbert.guan@arm.com>
 Hernan Vargas <hernan.vargas@intel.com>
 Herry Chen <herry.chen@broadcom.com>
 Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
+Hiral <hshah@marvell.com>
 Hiroki Shirokura <slank.dev@gmail.com>
 Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
 Hiroyuki Mikita <h.mikita89@gmail.com>
diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c
index 826887a97b..2388237186 100644
--- a/drivers/common/cnxk/roc_dev.c
+++ b/drivers/common/cnxk/roc_dev.c
@@ -441,8 +441,8 @@  process_msgs(struct dev *dev, struct mbox *mbox)
 
 		default:
 			if (msg->rc)
-				plt_err("Message (%s) response has err=%d",
-					mbox_id2name(msg->id), msg->rc);
+				plt_err("Message (%s) response has err=%d (%s)",
+					mbox_id2name(msg->id), msg->rc, roc_error_msg_get(msg->rc));
 			break;
 		}
 		offset = mbox->rx_start + msg->next_msgoff;
diff --git a/drivers/common/cnxk/roc_utils.c b/drivers/common/cnxk/roc_utils.c
index 495e62a315..fe291fce96 100644
--- a/drivers/common/cnxk/roc_utils.c
+++ b/drivers/common/cnxk/roc_utils.c
@@ -229,6 +229,12 @@  roc_error_msg_get(int errorcode)
 	case UTIL_ERR_INVALID_MODEL:
 		err_msg = "Invalid RoC model";
 		break;
+	case NIX_AF_ERR_RSS_NOSPC_FIELD:
+		err_msg = "No space or unsupported fields";
+		break;
+	case NIX_AF_ERR_RSS_NOSPC_ALGO:
+		err_msg = "No space to add new flow hash algo";
+		break;
 	default:
 		/**
 		 * Handle general error (as defined in linux errno.h)