diff mbox series

[v2] mldev: disable build on Windows

Message ID 20230310092329.1748666-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] mldev: disable build on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional fail Functional issues
ci/iol-testing warning apply patch failure

Commit Message

David Marchand March 10, 2023, 9:23 a.m. UTC 
  Caught by UNH lab, Windows compilation is broken because of symbol
exports:
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_bfloat16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_float16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_float32_to_bfloat16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_float32_to_float16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_float32_to_int16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_float32_to_int8
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_float32_to_uint16
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_float32_to_uint8
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_int16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_int8_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_uint16_to_float32
rte_mldev_exports.def : error LNK2001: unresolved external symbol
	rte_ml_io_uint8_to_float32

Disable Windows build until this is fixed.

Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/mldev/meson.build | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Monjalon March 10, 2023, 9:32 a.m. UTC | #1 
10/03/2023 10:23, David Marchand:
> Caught by UNH lab, Windows compilation is broken because of symbol
> exports:
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_bfloat16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_float16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_float32_to_bfloat16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_float32_to_float16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_float32_to_int16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_float32_to_int8
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_float32_to_uint16
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_float32_to_uint8
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_int16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_int8_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_uint16_to_float32
> rte_mldev_exports.def : error LNK2001: unresolved external symbol
> 	rte_ml_io_uint8_to_float32
> 
> Disable Windows build until this is fixed.
> 
> Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build
index 23d108617d..51ba809465 100644
--- a/lib/mldev/meson.build
+++ b/lib/mldev/meson.build
@@ -1,6 +1,12 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright (c) 2022 Marvell.
 
+if is_windows
+    build = false
+    reason = 'not supported on Windows'
+    subdir_done()
+endif
+
 sources = files(
         'rte_mldev_pmd.c',
         'rte_mldev.c',