[v2] bus/auxiliary: support cleanup callback

Message ID 20230317152447.4570-1-xuemingl@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] bus/auxiliary: support cleanup callback |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Xueming Li March 17, 2023, 3:24 p.m. UTC
  The bus cleanup callback is used to sunset all devices on bus
gracefully. This patch supports the callback by unplug all
devices on auxiliary bus.

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
 drivers/bus/auxiliary/auxiliary_common.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
  

Comments

Thomas Monjalon June 6, 2023, 2:33 p.m. UTC | #1
17/03/2023 16:24, Xueming Li:
> The bus cleanup callback is used to sunset all devices on bus
> gracefully. This patch supports the callback by unplug all
> devices on auxiliary bus.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>

Applied, thanks.
  

Patch

diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c
index ff1369353a..a66cc85d86 100644
--- a/drivers/bus/auxiliary/auxiliary_common.c
+++ b/drivers/bus/auxiliary/auxiliary_common.c
@@ -236,6 +236,7 @@  auxiliary_probe(void)
 	return (probed && probed == failed) ? -1 : 0;
 }
 
+
 static int
 auxiliary_parse(const char *name, void *addr)
 {
@@ -337,6 +338,25 @@  auxiliary_unplug(struct rte_device *dev)
 	return ret;
 }
 
+static int
+auxiliary_cleanup(void)
+{
+	struct rte_auxiliary_device *dev, *tmp_dev;
+	int error = 0;
+
+	RTE_TAILQ_FOREACH_SAFE(dev, &auxiliary_bus.device_list, next, tmp_dev) {
+		int ret;
+
+		ret = auxiliary_unplug(&dev->device);
+		if (ret < 0) {
+			rte_errno = errno;
+			error = -1;
+		}
+	}
+
+	return error;
+}
+
 static int
 auxiliary_dma_map(struct rte_device *dev, void *addr, uint64_t iova, size_t len)
 {
@@ -406,6 +426,7 @@  struct rte_auxiliary_bus auxiliary_bus = {
 	.bus = {
 		.scan = auxiliary_scan,
 		.probe = auxiliary_probe,
+		.cleanup = auxiliary_cleanup,
 		.find_device = auxiliary_find_device,
 		.plug = auxiliary_plug,
 		.unplug = auxiliary_unplug,