diff mbox series

net: fix return type of IPv6 L4 packet checksum

Message ID 20230406092129.820449-1-eagostini@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series net: fix return type of IPv6 L4 packet checksum |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Elena Agostini April 6, 2023, 9:21 a.m. UTC 
  From: Elena Agostini <eagostini@nvidia.com>

Function returns 0 or -1 but the return type is uint16_t.

Signed-off-by: Elena Agostini <eagostini@nvidia.com>
---
 lib/net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bing Zhao April 6, 2023, 9:35 a.m. UTC | #1 
Hi Elena,

Maybe it is better to add a fixline here.

BR. Bing

> -----Original Message-----
> From: eagostini@nvidia.com <eagostini@nvidia.com>
> Sent: Thursday, April 6, 2023 5:21 PM
> To: dev@dpdk.org
> Cc: statble@dpdk.org; Elena Agostini <eagostini@nvidia.com>
> Subject: [PATCH] net: fix return type of IPv6 L4 packet checksum
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Elena Agostini <eagostini@nvidia.com>
> 
> Function returns 0 or -1 but the return type is uint16_t.
> 
> Signed-off-by: Elena Agostini <eagostini@nvidia.com>
> ---
>  lib/net/rte_ip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h index a310e9d498..e7106256aa
> 100644
> --- a/lib/net/rte_ip.h
> +++ b/lib/net/rte_ip.h
> @@ -514,7 +514,7 @@ rte_ipv4_udptcp_cksum_verify(const struct
> rte_ipv4_hdr *ipv4_hdr,
>   *   Return 0 if the checksum is correct, else -1.
>   */
>  __rte_experimental
> -static inline uint16_t
> +static inline int
>  rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
>                                   const struct rte_ipv4_hdr *ipv4_hdr,
>                                   uint16_t l4_off)
> --
> 2.34.1
diff mbox series

Patch

diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h
index a310e9d498..e7106256aa 100644
--- a/lib/net/rte_ip.h
+++ b/lib/net/rte_ip.h
@@ -514,7 +514,7 @@  rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr *ipv4_hdr,
  *   Return 0 if the checksum is correct, else -1.
  */
 __rte_experimental
-static inline uint16_t
+static inline int
 rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
 				  const struct rte_ipv4_hdr *ipv4_hdr,
 				  uint16_t l4_off)