diff mbox series

[v2,5/6] bus: enable cdx bus

Message ID 20230413132704.17586-6-nipun.gupta@amd.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series add support for CDX bus |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Gupta, Nipun April 13, 2023, 1:27 p.m. UTC 
  enable the compilation of cdx bus

Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
---
 drivers/bus/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit April 14, 2023, 4:45 p.m. UTC | #1 
On 4/13/2023 2:27 PM, Nipun Gupta wrote:
> enable the compilation of cdx bus
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> ---
>  drivers/bus/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build
> index 6d2520c543..a78b4283bf 100644
> --- a/drivers/bus/meson.build
> +++ b/drivers/bus/meson.build
> @@ -3,6 +3,7 @@
>  
>  drivers = [
>          'auxiliary',
> +        'cdx',
>          'dpaa',
>          'fslmc',
>          'ifpga',

Why not squash this to the first patch?

I think better to enable bus with the first patch and gradually expand
the feature, this way each patch is checked that it builds fine.

There are cases some interim patches can't be built successfully, which
may required enabling after a few patches, but I think this is not the case.
Gupta, Nipun April 16, 2023, 9:21 a.m. UTC | #2 
> -----Original Message-----
> From: Yigit, Ferruh <Ferruh.Yigit@amd.com>
> Sent: Friday, April 14, 2023 10:16 PM
> To: Gupta, Nipun <Nipun.Gupta@amd.com>; dev@dpdk.org;
> thomas@monjalon.net; david.marchand@redhat.com
> Cc: Anand, Harpreet <harpreet.anand@amd.com>; Agarwal, Nikhil
> <nikhil.agarwal@amd.com>
> Subject: Re: [PATCH v2 5/6] bus: enable cdx bus
> 
> On 4/13/2023 2:27 PM, Nipun Gupta wrote:
> > enable the compilation of cdx bus
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> > ---
> >  drivers/bus/meson.build | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build
> > index 6d2520c543..a78b4283bf 100644
> > --- a/drivers/bus/meson.build
> > +++ b/drivers/bus/meson.build
> > @@ -3,6 +3,7 @@
> >
> >  drivers = [
> >          'auxiliary',
> > +        'cdx',
> >          'dpaa',
> >          'fslmc',
> >          'ifpga',
> 
> Why not squash this to the first patch?
> 
> I think better to enable bus with the first patch and gradually expand
> the feature, this way each patch is checked that it builds fine.
> 
> There are cases some interim patches can't be built successfully, which
> may required enabling after a few patches, but I think this is not the case.

Sure, I will merge into the first patch. Compilation should be working there too.

Thanks,
Nipun
diff mbox series

Patch

diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build
index 6d2520c543..a78b4283bf 100644
--- a/drivers/bus/meson.build
+++ b/drivers/bus/meson.build
@@ -3,6 +3,7 @@ 
 
 drivers = [
         'auxiliary',
+        'cdx',
         'dpaa',
         'fslmc',
         'ifpga',