From patchwork Wed Apr 19 20:11:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Schacher X-Patchwork-Id: 126280 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 468914298D; Wed, 19 Apr 2023 22:13:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 121DC42D84; Wed, 19 Apr 2023 22:12:11 +0200 (CEST) Received: from mail-pg1-f227.google.com (mail-pg1-f227.google.com [209.85.215.227]) by mails.dpdk.org (Postfix) with ESMTP id 3BB7242D50 for ; Wed, 19 Apr 2023 22:12:06 +0200 (CEST) Received: by mail-pg1-f227.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so158704a12.1 for ; Wed, 19 Apr 2023 13:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1681935125; x=1684527125; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gB6o712IWT+oZKQ31PnfqUgAqwy5hS1wi4i/p9N7nlc=; b=QZwJNw9UzMaYikh1JBcXuuCLEVKGsJJJ0grZu4i6THWqwXnvZdv+aYCqJfxvyycTJr z5iONepC60q/+JhVSZDzpaVXNy22aFrbYT7X+AyTbt+p5OiDv3MBvePxzSaNcReXwNme ijsOh87nI5G5fCvW+glQlnrZa7CfQqh4TVJ5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681935125; x=1684527125; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gB6o712IWT+oZKQ31PnfqUgAqwy5hS1wi4i/p9N7nlc=; b=ZLOueoPTFh+znUcG1NWe0lYPGcH5qz6i5V8qWNjmPl7P5w4LD4ZxATl/FsvlvoPld3 qouUL7rV93RjRMsL84SRJvxXmgXapG2ma41vAJbeRdVfVOE/zF4+ckcVy1t8DasnUG3l YRN8tDcu3BhaUGq8gT3tHBDDZNzn3mFN1FttVjh1cNQudrI4wD5ChQsVxYXKrIK1eHVJ fs9SG9SfEiJ7WkD5gNjWw6dPg0l/9i04WFEdrXDb3MvpN+ExXLySL5faXlWnzHLeyID6 t9Qa13R4qE6wU0yfZot46hMJaedtm7jWPbs6K2OJtzdrirATNk3W08894snGPSl4COZw kdWw== X-Gm-Message-State: AAQBX9eE280Cun9tvMUq+G0QUPXUiK/D1gkRPEopl0/MytxPH1HReWnJ 6bJBDWMsb3JKH80SyOMlB0iF8zrf9iYj85K1tX3TwaElfLHZjHGpWB73C1riUZZdlTAhJhXvhH6 TY2hyRcqvMA2dMfToEZmtynThe+vixeMMgJMVqkttzkQNohnsnvU+jfeh/nJaqjl9QKxcW/zz2e AnO7FxBHczBKWg0so= X-Google-Smtp-Source: AKy350Yji0cU01ImEwowycg+lZJ0masl2T64xnmDVHPnlA0bkb899lkI0JgHF7nOYyAoacGuRM/Jqp69fIkC X-Received: by 2002:a17:90b:3b82:b0:249:8963:c72 with SMTP id pc2-20020a17090b3b8200b0024989630c72mr2759474pjb.17.1681935125061; Wed, 19 Apr 2023 13:12:05 -0700 (PDT) Received: from r650-k2.dhcp.broadcom.net ([192.19.144.250]) by smtp-relay.gmail.com with ESMTPS id oc14-20020a17090b1c0e00b0024702c1a63bsm487614pjb.16.2023.04.19.13.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 13:12:05 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Randy Schacher To: dev@dpdk.org Cc: Shuanglin Wang , Kishore Padmanabha , Michael Baucom Subject: [PATCH 11/11] net/bnxt: Avoid submitting hwrm rss request when rss mode disabled Date: Wed, 19 Apr 2023 20:11:22 +0000 Message-Id: <20230419201122.338133-12-stuart.schacher@broadcom.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230419201122.338133-1-stuart.schacher@broadcom.com> References: <20230419201122.338133-1-stuart.schacher@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shuanglin Wang On WH+, if rss mode isn't enabled, then there is no rss context. Submitting HWRM_VNIC_RSS_CFG request to firmware would hit a failure. The fix is to check the rss context. If no rss context, then don't submit the hwrm request. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Shuanglin Wang --- drivers/net/bnxt/bnxt_hwrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 24a892bacf..d63bf227a6 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2405,6 +2405,9 @@ bnxt_hwrm_vnic_rss_cfg_non_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic) struct hwrm_vnic_rss_cfg_output *resp = bp->hwrm_cmd_resp_addr; int rc = 0; + if (vnic->num_lb_ctxts == 0) + return rc; + HWRM_PREP(&req, HWRM_VNIC_RSS_CFG, BNXT_USE_CHIMP_MB); req.hash_type = rte_cpu_to_le_32(vnic->hash_type);