From patchwork Fri Apr 21 18:11:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Schacher X-Patchwork-Id: 126414 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7B39429A8; Fri, 21 Apr 2023 20:13:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDAE642D73; Fri, 21 Apr 2023 20:12:37 +0200 (CEST) Received: from mail-oa1-f97.google.com (mail-oa1-f97.google.com [209.85.160.97]) by mails.dpdk.org (Postfix) with ESMTP id ABAAE42D55 for ; Fri, 21 Apr 2023 20:12:34 +0200 (CEST) Received: by mail-oa1-f97.google.com with SMTP id 586e51a60fabf-187b70ab997so12505014fac.0 for ; Fri, 21 Apr 2023 11:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1682100754; x=1684692754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F7uRDMgZCM1UXSJA27J1Us1gBz9sPN/ynvU5S0wpPPw=; b=WM+30NEUyZbBpeaFmu8Dy+svDuPkIO9zNcIqHrCOWPWMKEXKagxkv7vdFPqzxshaNF nrg81SgYmpmiMyPDAtdejMDNsDQSXcp6/xbeQEjZ1f7H8iDj+XvJAeUW3Y7rFFnORqoY MIb0Dbmy7mFeRZqOvspsmyrN5RkKGDIuzbGxs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682100754; x=1684692754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F7uRDMgZCM1UXSJA27J1Us1gBz9sPN/ynvU5S0wpPPw=; b=egG1/GtFsbdGm2FhPi2eXYMlXcS6LKrvs8cg2zsfaEj5Fbg2SG1csYKTWTK5gGY/JD 7toU+EafS9di7LDt1EIfWPLiJN2LjZfFKMuMDSGx1Q/EU4iQhcYbUu+En41PwA7Z2Aj1 MBn9bpS0OgLSx+PVSLrTHcCtHrQfOeCgnwBW0SsrOp4Njpv0kvUOBOQEPdz23EZpWayg pQb6w60Jut1CseTA8Tx35q8ZXQby4O9inXmn5RNQmh4awpP9OHqeoWqV/V7QdFWSKwre D4OEJ+zGt4BZFCP7tNt2KX/gkg4jGvaTNylji0boaUvPyp64Nm0XGrpOIv9eb7SezCZ6 4plA== X-Gm-Message-State: AAQBX9fPW2QkL77GQUExyYLDr/x1cXx/m0r+NN9CpV2FCwLIThGnwKUR 8nXixwrf3qnTvfVLnl96eAtmDGup5/xMbLQuO0auHUqkH9SdYgqjv/gYLD40sg1Hyn86R4cxoaX aE59V7XYWYj8hkrLWUHUtn2lE5m8kB+29WDA+/zWC9sCfWavyABmJCDjm43MtI78xwoaIGGY6Tu ufzrPRQk2O2xVc X-Google-Smtp-Source: AKy350YMXrAU3/c62YBREHCyVVvevfYb/OtnrPRGlbtjCuPhiomyR9jrB8SDq/Y6rhCRQgpwgw+RJOYG0Ndj X-Received: by 2002:a05:6870:b606:b0:184:2b9d:2b12 with SMTP id cm6-20020a056870b60600b001842b9d2b12mr4079942oab.13.1682100753826; Fri, 21 Apr 2023 11:12:33 -0700 (PDT) Received: from r650-k2.dhcp.broadcom.net ([192.19.144.250]) by smtp-relay.gmail.com with ESMTPS id o21-20020a056870e81500b0017eb57c3417sm397528oan.19.2023.04.21.11.12.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 11:12:33 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Randy Schacher To: dev@dpdk.org Cc: Shuanglin Wang , Kishore Padmanabha , Michael Baucom Subject: [PATCH v2 11/11] net/bnxt: Avoid submitting hwrm rss request when rss mode disabled Date: Fri, 21 Apr 2023 18:11:55 +0000 Message-Id: <20230421181155.2160482-12-stuart.schacher@broadcom.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230421181155.2160482-1-stuart.schacher@broadcom.com> References: <20230421181155.2160482-1-stuart.schacher@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shuanglin Wang On WH+, if rss mode isn't enabled, then there is no rss context. Submitting HWRM_VNIC_RSS_CFG request to firmware would hit a failure. The fix is to check the rss context. If no rss context, then don't submit the hwrm request. Signed-off-by: Shuanglin Wang Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Shuanglin Wang --- drivers/net/bnxt/bnxt_hwrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index b944547656..06f196760f 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2405,6 +2405,9 @@ bnxt_hwrm_vnic_rss_cfg_non_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic) struct hwrm_vnic_rss_cfg_output *resp = bp->hwrm_cmd_resp_addr; int rc = 0; + if (vnic->num_lb_ctxts == 0) + return rc; + HWRM_PREP(&req, HWRM_VNIC_RSS_CFG, BNXT_USE_CHIMP_MB); req.hash_type = rte_cpu_to_le_32(vnic->hash_type);