examples/ipsec-secgw: Update fixed MAC address used by tap driver

Message ID 20230426203724.1008261-1-drc@linux.vnet.ibm.com (mailing list archive)
State Changes Requested, archived
Delegated to: akhil goyal
Headers
Series examples/ipsec-secgw: Update fixed MAC address used by tap driver |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

David Christensen April 26, 2023, 8:37 p.m. UTC
  Modify LOCAL_MAC value to match new locally administered MAC
address used by TAP driver.

Bugzilla ID: 1198

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
 examples/ipsec-secgw/test/common_defs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Akhil Goyal May 16, 2023, 10:28 a.m. UTC | #1
> Modify LOCAL_MAC value to match new locally administered MAC
> address used by TAP driver.
> 

Shouldn't this be other way round?
PMD should be able to use the MAC given by application.

> Bugzilla ID: 1198
> 
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
>  examples/ipsec-secgw/test/common_defs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ipsec-secgw/test/common_defs.sh b/examples/ipsec-
> secgw/test/common_defs.sh
> index 3ef06bc761..6e04ffc1a6 100644
> --- a/examples/ipsec-secgw/test/common_defs.sh
> +++ b/examples/ipsec-secgw/test/common_defs.sh
> @@ -26,7 +26,7 @@ fi
> 
>  LOCAL_IFACE=dtap0
> 
> -LOCAL_MAC="00:64:74:61:70:30"
> +LOCAL_MAC="02:64:74:61:70:30"
> 
>  REMOTE_IPV4=192.168.31.14
>  LOCAL_IPV4=192.168.31.92
> --
> 2.31.1
  

Patch

diff --git a/examples/ipsec-secgw/test/common_defs.sh b/examples/ipsec-secgw/test/common_defs.sh
index 3ef06bc761..6e04ffc1a6 100644
--- a/examples/ipsec-secgw/test/common_defs.sh
+++ b/examples/ipsec-secgw/test/common_defs.sh
@@ -26,7 +26,7 @@  fi
 
 LOCAL_IFACE=dtap0
 
-LOCAL_MAC="00:64:74:61:70:30"
+LOCAL_MAC="02:64:74:61:70:30"
 
 REMOTE_IPV4=192.168.31.14
 LOCAL_IPV4=192.168.31.92