From patchwork Thu Apr 27 11:55:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 126604 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF56142A0F; Thu, 27 Apr 2023 13:55:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A24D42D2D; Thu, 27 Apr 2023 13:55:49 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 889D042B8C for ; Thu, 27 Apr 2023 13:55:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682596547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zjC/S3TaM4nuOe9zAbOecWNRRx2UNOt4xJmaSB1bZ7E=; b=Jux2+prvRwm1cTfQUVyVWKLSMob+Mrk9XSQDFufNqKGpPPo3OxAn2wgFHVtCTU4S8G0f8o hyQlzR7/qLo/8l8TxBDfKvW4DoNxt1G99EPBRvgwVcGb9TPXXLEp0tCT+22GLAkhpJzNlw a965GdAuy0wrW6z4NIJdPKwW9LvIBH8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-50-Z2o1H7K8OxC0wD-Vjf1mLQ-1; Thu, 27 Apr 2023 07:55:41 -0400 X-MC-Unique: Z2o1H7K8OxC0wD-Vjf1mLQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 029DE3C0F1A2; Thu, 27 Apr 2023 11:55:41 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1929492B03; Thu, 27 Apr 2023 11:55:39 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, Matan Azrad , Viacheslav Ovsiienko , Gregory Etelson Subject: [PATCH] net/mlx5: enhance error log for tunnel offloading Date: Thu, 27 Apr 2023 13:55:34 +0200 Message-Id: <20230427115534.1277154-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Tunnel offloading is linked to running a port with the non-obvious dv_xmeta_en=3 devargs. Hint at it for "normal" users. Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Signed-off-by: David Marchand Reviewed-by: Gregory Etelson Acked-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index d0275fdd00..51f6ecd25d 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -11295,7 +11295,7 @@ mlx5_flow_tunnel_validate(struct rte_eth_dev *dev, if (!is_tunnel_offload_active(dev)) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, - "tunnel offload was not activated"); + "tunnel offload was not activated, consider setting dv_xmeta_en=3"); if (!tunnel) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL,