diff mbox series

test/crypto: fix IPsec AES CCM test vector

Message ID 20230512125933.1131522-1-ktejasree@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series test/crypto: fix IPsec AES CCM test vector |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS

Commit Message

Tejasree Kondoj May 12, 2023, 12:59 p.m. UTC 
  Fixing IPsec AES-CCM test vector IV length.

Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
Cc: stable@dpdk.org

Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
---
 app/test/test_cryptodev_security_ipsec_test_vectors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anoob Joseph May 12, 2023, 2:02 p.m. UTC | #1 
> 
> Fixing IPsec AES-CCM test vector IV length.
> 
> Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> ---
>  app/test/test_cryptodev_security_ipsec_test_vectors.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Anoob Joseph <anoobj@marvell.com>
Akhil Goyal May 16, 2023, 10:18 a.m. UTC | #2 
> Subject: [PATCH] test/crypto: fix IPsec AES CCM test vector
> 
> Fixing IPsec AES-CCM test vector IV length.

Please add appropriate description.

> 
> Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> ---
>  app/test/test_cryptodev_security_ipsec_test_vectors.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test/test_cryptodev_security_ipsec_test_vectors.h
> b/app/test/test_cryptodev_security_ipsec_test_vectors.h
> index 2686bbeb62..462cef6785 100644
> --- a/app/test/test_cryptodev_security_ipsec_test_vectors.h
> +++ b/app/test/test_cryptodev_security_ipsec_test_vectors.h
> @@ -417,7 +417,7 @@ struct ipsec_test_data pkt_aes_256_ccm = {
>  				.op = RTE_CRYPTO_AEAD_OP_ENCRYPT,
>  				.algo = RTE_CRYPTO_AEAD_AES_CCM,
>  				.key.length = 32,
> -				.iv.length = 12,
> +				.iv.length = 11,

Add a comment here that IV includes 3 bytes of salt and 8 bytes of IV.

>  				.iv.offset = IV_OFFSET,
>  				.digest_length = 16,
>  				.aad_length = 12,
> --
> 2.25.1
diff mbox series

Patch

diff --git a/app/test/test_cryptodev_security_ipsec_test_vectors.h b/app/test/test_cryptodev_security_ipsec_test_vectors.h
index 2686bbeb62..462cef6785 100644
--- a/app/test/test_cryptodev_security_ipsec_test_vectors.h
+++ b/app/test/test_cryptodev_security_ipsec_test_vectors.h
@@ -417,7 +417,7 @@  struct ipsec_test_data pkt_aes_256_ccm = {
 				.op = RTE_CRYPTO_AEAD_OP_ENCRYPT,
 				.algo = RTE_CRYPTO_AEAD_AES_CCM,
 				.key.length = 32,
-				.iv.length = 12,
+				.iv.length = 11,
 				.iv.offset = IV_OFFSET,
 				.digest_length = 16,
 				.aad_length = 12,