[v2] doc: updated libcrypto dependencies in QAT guide

Message ID 20230516132006.577354-1-samina.arshad@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v2] doc: updated libcrypto dependencies in QAT guide |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Samina Arshad May 16, 2023, 1:20 p.m. UTC
  The documentation needs extra steps for customers to explicitly
 show how to install libcrypto, which is needed for QAT.
 It requires the commands to install libcrypto for
 Ubuntu and RHEL.

Signed-off-by: Samina Arshad <samina.arshad@intel.com>
---
 .mailmap                      |  1 +
 doc/guides/cryptodevs/qat.rst | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
  

Comments

Power, Ciara May 25, 2023, 2:02 p.m. UTC | #1
Hi Samina,

> -----Original Message-----
> From: Samina Arshad <samina.arshad@intel.com>
> Sent: Tuesday 16 May 2023 14:20
> To: Thomas Monjalon <thomas@monjalon.net>; Ji, Kai <kai.ji@intel.com>
> Cc: dev@dpdk.org; gakhil@marvell.com; Arshad, Samina
> <samina.arshad@intel.com>
> Subject: [PATCH v2] doc: updated libcrypto dependencies in QAT guide
> 
>  The documentation needs extra steps for customers to explicitly  show how to
> install libcrypto, which is needed for QAT.
>  It requires the commands to install libcrypto for  Ubuntu and RHEL.
> 
> Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> ---
>  .mailmap                      |  1 +
>  doc/guides/cryptodevs/qat.rst | 14 ++++++++++++++
>  2 files changed, 15 insertions(+)
<snip>

Acked-by: Ciara Power <ciara.power@intel.com>
  
Akhil Goyal June 20, 2023, 12:57 p.m. UTC | #2
>  The documentation needs extra steps for customers to explicitly
>  show how to install libcrypto, which is needed for QAT.
>  It requires the commands to install libcrypto for
>  Ubuntu and RHEL.
> 
> Signed-off-by: Samina Arshad <samina.arshad@intel.com>
Applied to dpdk-next-crypto
Thanks.
  

Patch

diff --git a/.mailmap b/.mailmap
index 0443e461a9..6a0c1924eb 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1179,6 +1179,7 @@  Salem Sol <salems@nvidia.com>
 Sameh Gobriel <sameh.gobriel@intel.com>
 Sam Grove <sam.grove@sifive.com>
 Samik Gupta <samik.gupta@broadcom.com>
+Samina Arshad <samina.arshad@intel.com>
 Samuel Gauthier <samuel.gauthier@6wind.com>
 Sangjin Han <sangjin@eecs.berkeley.edu>
 Sankar Chokkalingam <sankarx.chokkalingam@intel.com>
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index ef754106a8..a3694f7131 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -234,6 +234,20 @@  These are the build configuration options affecting QAT, and their default value
 Both QAT SYM PMD and QAT ASYM PMD have an external dependency on libcrypto, so are not
 built by default.
 
+Ubuntu
+
+.. code-block:: console
+
+  apt install libssl-dev
+
+
+RHEL
+
+.. code-block:: console
+
+  dnf install openssl-devel
+
+
 The QAT compressdev PMD has no external dependencies, so is built by default.
 
 The number of VFs per PF varies - see table below. If multiple QAT packages are