From patchwork Fri May 19 17:46:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127127 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FD1C42B4B; Fri, 19 May 2023 19:47:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEE2A42DAE; Fri, 19 May 2023 19:46:34 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id B350042D8B for ; Fri, 19 May 2023 19:46:31 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-52cbd7d0c37so2403331a12.3 for ; Fri, 19 May 2023 10:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684518390; x=1687110390; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ox2/1DyBdWFGOTpbAGYHhFIlWAE+SizGnBjAsFKISvE=; b=xT3nT8mjGl8U59dInc28Cu/4BjhOq1rTWtd6zNR1C/N8av5YtJeUfu4NxhEPVWln1E ZVDcoyRleTfbJYV4JzewW71/6Mv1kuJ3eW5Cak3YyS6J0X0hiXGbUnjmUPoEz7DGSEFZ CtMUdDsExmQFCCwQA3RRvaV5hjnsZsi7SKFi3k+/tU1Hyh8uMzgcpnwpY+kT4aNBnlTe ORmt8HTc4EWWeFqpcEPrlHkLB2xbzsl76kYBXZBWRIwau4RcBVhKULbgiF1tkyYV9irY 2L/mdN56Wj9lD+W6lPqnG5VioSI+imtnTDrOm+WVRQDH9GNq//QOAt2Cdx3XBYuNNsTx RSvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684518390; x=1687110390; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ox2/1DyBdWFGOTpbAGYHhFIlWAE+SizGnBjAsFKISvE=; b=fnG92gwRDIwro8tYrUGtPLEIhflP78fn2nc3NOIboJ14/YCOSzd/+223mDs53nImm2 ktdE8wJd4Mx4vWP8Mu/6Hvc/Q9iiIFp8kCBnp6ZrMUet3TQ8tkxNVpNVBJC+uIX320nH DQ5kiKtPx/03ZHJ882BN4b56CMaO7Vjd1XzSPnKYDwLy9HcRoekAmSHVWCC+oQ1BKExo SODVGLMmPVZMdq98evxugRtvDwP21V/dGbj+1G0VWcFPSVwpjZm2LKqmvuM9wbjoCWI2 fpoINkQZZV+iHB5p1wJkEgC0WRCFiAxFYc1CMGQIKKH16rP9i3gd6g3Oqw4hrOVnLypd efQA== X-Gm-Message-State: AC+VfDwFyFo/aRUnChLcrsbMf+afHTe/OK5TR6/dTukgIQZM2U0a1udZ Il2yHlB5hfi4zbwtjFnDTp2zmuDPytlguZnRI9Bwnw== X-Google-Smtp-Source: ACHHUZ6J7s9c6QfQ9jXskA82F3QYWGb65HnOIaa884/agW8DgASuM9Aqwrwd8nDKNMNSr5r7CVBaXg== X-Received: by 2002:a17:902:b705:b0:1ae:56ff:74a with SMTP id d5-20020a170902b70500b001ae56ff074amr3088825pls.58.1684518390600; Fri, 19 May 2023 10:46:30 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e3-20020a170902744300b001aaf2e7b06csm3713101plt.132.2023.05.19.10.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 10:46:30 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v3 14/19] cnxk: replace term sanity Date: Fri, 19 May 2023 10:46:06 -0700 Message-Id: <20230519174611.11232-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230519174611.11232-1-stephen@networkplumber.org> References: <20230517161603.117728-1-stephen@networkplumber.org> <20230519174611.11232-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c | 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c index 4e88ad1beb71..d837e2247634 100644 --- a/drivers/common/cnxk/roc_nix_tm_ops.c +++ b/drivers/common/cnxk/roc_nix_tm_ops.c @@ -527,7 +527,7 @@ roc_nix_tm_hierarchy_disable(struct roc_nix *roc_nix) node->flags &= ~NIX_TM_NODE_ENABLED; } - /* Verify sanity of all tx queues */ + /* Verify all tx queues */ for (i = 0; i < sq_cnt; i++) { sq = nix->sqs[i]; if (!sq) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index 20637fbf657c..08e193e6118c 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -341,7 +341,7 @@ npa_aura_pool_pair_alloc(struct npa_lf *lf, const uint32_t block_size, char name[PLT_MEMZONE_NAMESIZE]; const struct plt_memzone *mz; - /* Sanity check */ + /* argument checks */ if (!lf || !block_size || !block_count || !pool || !aura || !aura_handle) return NPA_ERR_PARAM; @@ -769,7 +769,7 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox) uint8_t aura_sz; int rc; - /* Sanity checks */ + /* Input checks */ if (!lf || !base || !mbox) return NPA_ERR_PARAM; diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 1cae3084e184..8fdc3d5a9a96 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -633,7 +633,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid, struct rte_mempool *lpb_pool = mp; struct rte_mempool *spb_pool = NULL; - /* Sanity checks */ + /* input checks */ if (rx_conf->rx_deferred_start == 1) { plt_err("Deferred Rx start is not supported"); goto fail; @@ -1195,7 +1195,7 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) rc = -EINVAL; - /* Sanity checks */ + /* baseline checks */ if (rte_eal_has_hugepages() == 0) { plt_err("Huge page is not configured"); goto fail_configure;